From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A953074003A for ; Wed, 23 Aug 2023 17:21:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7Z9fJHY2m56vpKJ1C6g2Gd3axjAih+Fe3CKCobwz0yM=; c=relaxed/simple; d=groups.io; h=Feedback-ID:User-Agent:Mime-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc:Subject:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692811266; v=1; b=mXZvMY+xuZgbGvrFWsYFb2rRasX50cxq0lGt79xuoZFfarncD8vry7+Lm2vnN2R21yHJBMD6 Oj+oLgaW1P9pgfYHs8DdgjCKMAeDiPQ4sXG+a9b2daUrEXxBbQHWDVgLwc4Hd6qkRdHVDV+VuNS EIymE5qPSSLVqPyDXIqjCOBM= X-Received: by 127.0.0.2 with SMTP id CMp5YY7687511xzskAGFNfLr; Wed, 23 Aug 2023 10:21:06 -0700 X-Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mx.groups.io with SMTP id smtpd.web11.2607.1692811265150241724 for ; Wed, 23 Aug 2023 10:21:05 -0700 X-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5CC915C008B; Wed, 23 Aug 2023 13:21:04 -0400 (EDT) X-Received: from imap43 ([10.202.2.93]) by compute5.internal (MEProxy); Wed, 23 Aug 2023 13:21:04 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdft vggsvggttggrucevrhgrnhdfuceorhgvsggvtggtrgessghsughiohdrtghomheqnecugg ftrfgrthhtvghrnhepvdekieeivdeijeekkefgteehteeiieefgfevveeufeekheekieff vdekgeeifefgnecuffhomhgrihhnpehgrhhouhhpshdrihhonecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdr tghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 65CA72D4008F; Wed, 23 Aug 2023 13:21:03 -0400 (EDT) User-Agent: Cyrus-JMAP/3.9.0-alpha0-647-g545049cfe6-fm-20230814.001-g545049cf Mime-Version: 1.0 Message-Id: <819fcd52-ee34-4a86-88d3-d9a2db69651c@app.fastmail.com> In-Reply-To: <20230823151522.168518-1-quic_llindhol@quicinc.com> References: <20230823151522.168518-1-quic_llindhol@quicinc.com> Date: Wed, 23 Aug 2023 11:21:02 -0600 From: "Rebecca Cran" To: devel@edk2.groups.io, "Leif Lindholm" Cc: "'Ajay Iyengar '" , gaoliming , "'Bob Feng'" , "'Yuwei Chen'" , "Ard Biesheuvel" Subject: Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: u2x6cXrp6Sgw6bH123XWEtz9x7686176AA= Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mXZvMY+x; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Rebecca Cran On Wed, Aug 23, 2023, at 9:15 AM, Leif Lindholm wrote: > The CLANGDWARF progfile sets both -Wno-tautological-compare and > -Wno-tautological-constant-out-of-range-compare, but this prevents > compile-time detection of certain errors. > Drop these flags. > > Signed-off-by: Leif Lindholm > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Ard Biesheuvel > --- > > Does anyone remember why these were added? > I'm not running into any issues across armvirtqemu, qemusbsa, ovmfx64, > ovmfriscv64. > > / > Leif > > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 1bf62362b611..5bd5283655ea 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1859,7 +1859,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS = > -Wl,--defsym=PECOFF_HEADER_SIZE=0x22 > DEFINE CLANGDWARF_IA32_TARGET = -target i686-pc-linux-gnu > DEFINE CLANGDWARF_X64_TARGET = -target x86_64-pc-linux-gnu > > -DEFINE CLANGDWARF_WARNING_OVERRIDES = -Wno-parentheses-equality > -Wno-tautological-compare > -Wno-tautological-constant-out-of-range-compare -Wno-empty-body > -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option > -Wno-unused-but-set-variable -Wno-unused-const-variable > -Wno-unaligned-access -Wno-unneeded-internal-declaration > +DEFINE CLANGDWARF_WARNING_OVERRIDES = -Wno-parentheses-equality > -Wno-empty-body -Wno-unused-const-variable -Wno-varargs > -Wno-unknown-warning-option -Wno-unused-but-set-variable > -Wno-unused-const-variable -Wno-unaligned-access > -Wno-unneeded-internal-declaration > DEFINE CLANGDWARF_ALL_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) > DEF(CLANGDWARF_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields > -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas > -Wno-incompatible-library-redeclaration -fno-asynchronous-unwind-tables > -mno-sse -mno-mmx -msoft-float -mno-implicit-float > -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang > -funsigned-char -fno-ms-extensions -Wno-null-dereference > > ########################### > -- > 2.39.2 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107987): https://edk2.groups.io/g/devel/message/107987 Mute This Topic: https://groups.io/mt/100916818/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-