From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web12.145.1615836143709047875 for ; Mon, 15 Mar 2021 12:22:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LzFbfgk0; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id lr1-20020a17090b4b81b02900ea0a3f38c1so2417284pjb.0 for ; Mon, 15 Mar 2021 12:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=OMUZwfH/IBT7iq34d4+gMrKS3vFuUQzj9BgnNsBPU2k=; b=LzFbfgk0T/KuEKYF8ZTMGBhgVSESklgBlKDm46pclozWCT1M4LWYKYQlNJqBcnccbf LCtQ2GsjVBfRDHFUbz/Qk9ebw5SOD8Tp3+2idOrPq1mwbiUMNY7t1aYfXCtswxy0cuOk +imhWYokJvHqB3x9q+QkKeriR+7E28vYwy2YRjVVvV80eLADd7jbCofd/iDuAhPjfoXI ys88bcpU8Lokyjg54IpjKSN+WQtXJz7DRYZwPWmb61QpfmZdpLDPubHOwJLVgXockKmX /jQ8cDMqhRp/M8SIkHRInHXGLj3Tavu+ZOryGg791ZH7l6vvvZpcVXRRmAstUOsP7imv lXyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OMUZwfH/IBT7iq34d4+gMrKS3vFuUQzj9BgnNsBPU2k=; b=FnenKsf96yRi1RazINB2IPZD6xJCRV9zA4g/PMqz8953tUxor1rZCDCrtgL3dRn122 lE4Hh9bzQHJPNuJXkFsHohgdhdARW7acXj6m0GM4UsVGIUGbBI28O+kAx8JzVOBo37PY Wr2soXqgZfPx4H23+73zp4nyRbh+nX1rtSwH1kjBxNjOJ71873Kbb1VlVjYH+o5YCR1M lhufjXlM6M7hoBHaSoZM4EUnRtzv4P3EqO66zq1kpTJQrw6murbTXoTpyW3nLyfZReS6 /wd2tw8FjGu3EgwE7hZN2fALfXOj6DJ6VFylBcSrTOYhk4htAaEFykNPCxHe9MBLBdJE 8s6A== X-Gm-Message-State: AOAM533TcAWJRSMYnE7z2WPaYmt5sZEpj1rZ21HBKR8UilXigBqWH91O Ocvx9/U9eZb1a7usysNPD7I= X-Google-Smtp-Source: ABdhPJylYKIHZrWA83fM4JrDmZ3MqhlCe/9s0L+iOx7uT7tVIciGANM6eBifwh4WcWNM2mTQhyAScA== X-Received: by 2002:a17:902:9a06:b029:e6:9241:2779 with SMTP id v6-20020a1709029a06b02900e692412779mr12857004plp.24.1615836143189; Mon, 15 Mar 2021 12:22:23 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id mr5sm403647pjb.53.2021.03.15.12.22.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 12:22:22 -0700 (PDT) Subject: Re: [edk2-staging][PATCH V1 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe From: kuqin12@gmail.com To: devel@edk2.groups.io, Zailiang Sun , Yi Qian References: <20210310200738.1220-1-kuqin12@gmail.com> <20210310200738.1220-5-kuqin12@gmail.com> Message-ID: <81ac9396-02d3-e0e9-d3c0-f7ab41a73175@gmail.com> Date: Mon, 15 Mar 2021 12:22:22 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210310200738.1220-5-kuqin12@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Zailiang/Yi, Could you please help review the patch below? Any input is appreciated. Thanks, Kun On 03/10/2021 12:07, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 > > This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc > file to resolve new dependency by VariableSmmRuntimeDxe. The library > interface is consumed by variable module to better support variable > runtime cache feature. > > Cc: Zailiang Sun > Cc: Yi Qian > > Signed-off-by: Kun Qin > --- > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 409f31c982d7..33e93b74800c 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -311,6 +311,7 @@ [LibraryClasses.IA32] > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf > EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > [LibraryClasses.IA32.DXE_DRIVER] > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 38bd825c8bdc..f7a876353649 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -313,6 +313,7 @@ [LibraryClasses.X64] > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf > EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > [LibraryClasses.X64.DXE_DRIVER] > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf >