From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
devel@edk2.groups.io, michael.d.kinney@intel.com
Subject: Re: 回复: [edk2-devel] [RFC] Adoption of CodeQL in edk2
Date: Mon, 3 Oct 2022 10:29:20 -0400 [thread overview]
Message-ID: <81bace66-07f4-2cc7-e2f1-da579f90b1c3@linux.microsoft.com> (raw)
In-Reply-To: <029801d8d496$9a23a5c0$ce6af140$@byosoft.com.cn>
I believe you are asking, when CodeQL CI is enabled in the edk2 project,
how soon after will all of the issues be fixed so CI passes?
The process that will be used to enable CodeQL in CI will follow what is
described in the "Enable One Query at a Time" section in the RFC
(https://github.com/tianocore/edk2/discussions/3258).
As proposed in that section, there should not be a time when a new
CodeQL CLI query is enabled that does not pass. Queries will be enabled
one at a time. Each time a new query is enabled, the query enable and
the corresponding changes will be staged on a branch that get merged to
edk2 master in a single PR.
CodeQL CI will run in that PR and it must pass for the PR to be completed.
On 9/30/2022 2:33 AM, gaoliming wrote:
> Michael:
>
> Could you estimate when CodeQL CI check can pass after CodeQL check
> is enabled?
>
> Thanks
>
> Liming
>
> *发件人:*devel@edk2.groups.io <devel@edk2.groups.io> *代表 *Michael D Kinney
> *发送时间:*2022年9月30日9:03
> *收件人:*devel@edk2.groups.io; mikuback@linux.microsoft.com; Kinney,
> Michael D <michael.d.kinney@intel.com>
> *主题:*Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2
>
> I just want to reiterate. If there are no concerns or objections raised
> by Oct 4, then the
>
> CodeQL static analysis will be phased into use in the edk2 repo and
> there will be code
>
> changes made to address the issues identified by COdeQL and all future
> code changes
>
> after a CodeQL check is enabled will be blocked until the CodeQL CI
> checks pass.
>
> This will impact all future code changes and all developers will have to
> learn how to
>
> interpret CodeQL reports and fix issues.
>
> Thanks,
>
> Mike
>
> *From:*devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> <devel@edk2.groups.io <mailto:devel@edk2.groups.io>> *On Behalf Of
> *Michael Kubacki
> *Sent:* Thursday, September 29, 2022 5:05 PM
> *To:* Michael Kubacki <mikuback@linux.microsoft.com
> <mailto:mikuback@linux.microsoft.com>>; devel@edk2.groups.io
> <mailto:devel@edk2.groups.io>
> *Subject:* Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2
>
> If there's any further feedback on this RFC, please respond by Tuesday,
> October 4th. We plan to start implementing the changes later in the week.
>
> Thanks,
> Michael
>
>
>
next prev parent reply other threads:[~2022-10-03 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 22:18 [RFC] Adoption of CodeQL in edk2 Michael Kubacki
2022-09-30 0:05 ` [edk2-devel] " Michael Kubacki
2022-09-30 1:02 ` Michael D Kinney
2022-09-30 2:53 ` Ni, Ray
2022-10-03 14:19 ` Michael Kubacki
2022-09-30 6:33 ` 回复: " gaoliming
2022-10-03 14:29 ` Michael Kubacki [this message]
2022-10-08 1:26 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81bace66-07f4-2cc7-e2f1-da579f90b1c3@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox