From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.511.1664807362163300496 for ; Mon, 03 Oct 2022 07:29:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=SoDlZ8lB; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 4CAE820E6ADA; Mon, 3 Oct 2022 07:29:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4CAE820E6ADA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1664807361; bh=3UDAEV6o9ZQzJLpq92/e0ShMfqLs6lOoIFqggj9bLB8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=SoDlZ8lBlaV2RivEN9qWUfMG94FxUk+oSyjBKWz3Qx5olk3p9QBBgqaLj+6KMdVmY fwwz8mIAEqrvaqZc6XFTQnWrQ/iu/8Mt6EDh6yNl0GpJg+ia764paFiLAO6uhwMshR gKLDIMiKz7T9rZnumtxcXhFWCpky8pgz/TH33gZg= Message-ID: <81bace66-07f4-2cc7-e2f1-da579f90b1c3@linux.microsoft.com> Date: Mon, 3 Oct 2022 10:29:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtSRkNdIEFkb3B0aW9uIG9mIENvZGVRTCBpbiBlZGsy?= To: gaoliming , devel@edk2.groups.io, michael.d.kinney@intel.com References: <0da4bc04-851e-7028-9c34-e0b37bdf105c@linux.microsoft.com> <8117.1664496315698093072@groups.io> <029801d8d496$9a23a5c0$ce6af140$@byosoft.com.cn> From: "Michael Kubacki" In-Reply-To: <029801d8d496$9a23a5c0$ce6af140$@byosoft.com.cn> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable I believe you are asking, when CodeQL CI is enabled in the edk2 project,=20 how soon after will all of the issues be fixed so CI passes? The process that will be used to enable CodeQL in CI will follow what is=20 described in the "Enable One Query at a Time" section in the RFC=20 (https://github.com/tianocore/edk2/discussions/3258). As proposed in that section, there should not be a time when a new=20 CodeQL CLI query is enabled that does not pass. Queries will be enabled=20 one at a time. Each time a new query is enabled, the query enable and=20 the corresponding changes will be staged on a branch that get merged to=20 edk2 master in a single PR. CodeQL CI will run in that PR and it must pass for the PR to be completed. On 9/30/2022 2:33 AM, gaoliming wrote: > Michael: >=20 > =C2=A0Could you estimate when =C2=A0CodeQL CI =C2=A0check can pass after= CodeQL check=20 > is enabled? >=20 > Thanks >=20 > Liming >=20 > *=E5=8F=91=E4=BB=B6=E4=BA=BA:*devel@edk2.groups.io = *=E4=BB=A3=E8=A1=A8 *Michael D Kinney > *=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:*2022=E5=B9=B49=E6=9C=8830=E6=97=A5= 9:03 > *=E6=94=B6=E4=BB=B6=E4=BA=BA:*devel@edk2.groups.io; mikuback@linux.micros= oft.com; Kinney,=20 > Michael D > *=E4=B8=BB=E9=A2=98:*Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2 >=20 > I just want to reiterate.=C2=A0 If there are no concerns or objections ra= ised=20 > by Oct 4, then the >=20 > CodeQL static analysis will be phased into use in the edk2 repo and=20 > there will be code >=20 > changes made to address the issues identified by COdeQL and all future=20 > code changes >=20 > after a CodeQL check is enabled will be blocked until the CodeQL CI=20 > checks pass. >=20 > This will impact all future code changes and all developers will have to= =20 > learn how to >=20 > interpret CodeQL reports and fix issues. >=20 > Thanks, >=20 > Mike >=20 > *From:*devel@edk2.groups.io =20 > > *On Behalf Of=20 > *Michael Kubacki > *Sent:* Thursday, September 29, 2022 5:05 PM > *To:* Michael Kubacki >; devel@edk2.groups.io=20 > > *Subject:* Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2 >=20 > If there's any further feedback on this RFC, please respond by Tuesday,= =20 > October 4th. We plan to start implementing the changes later in the week. >=20 > Thanks, > Michael >=20 >=20 >=20