From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web10.10667.1614091679298687662
 for <devel@edk2.groups.io>;
 Tue, 23 Feb 2021 06:47:59 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hkdyQwpa;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1614091678;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YIpbUx+C5Rzwg2UAIFxXmxVncSWPR+DxzCCbNImHaYg=;
	b=hkdyQwpabTpMRUBTzmjLECi4jdqgWqOWP21zLk7Qe2aEgigbSLQeXeVw56cCjrhpGwv/7z
	MIP/df7to3bkbMBW3mQC+jb7zjWuMWbAZUpOL5S7JCvw7A/zfcD1u1nBb4q8pWdWagS1b5
	AL3UhCNlJXzUt/vLvnZI4zoqwtvFS5o=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-344-xWVMYGOSPKKRWH6NonSbvw-1; Tue, 23 Feb 2021 09:47:41 -0500
X-MC-Unique: xWVMYGOSPKKRWH6NonSbvw-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2119884E21D;
	Tue, 23 Feb 2021 14:46:19 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-163.ams2.redhat.com [10.36.112.163])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 0EE215D6AB;
	Tue, 23 Feb 2021 14:46:17 +0000 (UTC)
Subject: Re: implement about virtio-keyboard
To: Zhu Yijun <lovemrd@gmail.com>, devel@edk2.groups.io
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <CAF_Z_jpXFnoQ+YeA9t12aEt+-CT_1y=ktzF3paGNUZAk9SXGWw@mail.gmail.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <81c4017a-ef40-f729-d304-956105910947@redhat.com>
Date: Tue, 23 Feb 2021 15:46:17 +0100
MIME-Version: 1.0
In-Reply-To: <CAF_Z_jpXFnoQ+YeA9t12aEt+-CT_1y=ktzF3paGNUZAk9SXGWw@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/23/21 09:48, Zhu Yijun wrote:
> Hi all,
>     I boot vm with the virtio keyboard on aarch64. It looks UEFI lacks
> support for the virtio keyboard, so I can't do any keyboard input
> before the linux kernel driver loads, i.e. edit the grub boot menu. Is
> there any plan to support it?

Not on my side.

My team discussed virtio-input's relevance for ArmVirtQemu in September
2016.

We decided not to bother about it, because:

(1) XHCI was virtualization-friendly, both performance-wise and
configuration-wise (unlike EHCI),

(2) QEMU and libvirt were going to gain (... or had just gained ...)
XHCI support, on aarch64 / "virt".


So today, just use a "qemu-xhci" controller in your domain config
please, in combination with a USB keyboard. (If you define a new aarch64
domain with libvirt, this should happen out of the box for you.)

ArmVirtQemu includes all the edk2 drivers necessary for driving those
devices, and ArmVirtQemu's PlatformBootManagerLib instance will connect
the USB keyboard automatically. There shouldn't be a problem when typing
in "grub".

Thanks
Laszlo

>     I find UsbKeyboardDevice attach on UsbIO which implements its
> protocol interface structure(such as UsbGetInterfaceDescriptor,
> UsbAsyncInterruptTransfer) defined by UEFI spec, but virtio not. So is
> there some way to implement similar interfaces?
> 
> Best regards,
> Cheng Mao
>