From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 78AD92243693D for ; Fri, 23 Feb 2018 02:11:48 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7228FEB6F0; Fri, 23 Feb 2018 10:17:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-112.rdu2.redhat.com [10.10.120.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 84B5CB3006; Fri, 23 Feb 2018 10:17:48 +0000 (UTC) To: Meenakshi Aggarwal , "Ni, Ruiyu" , "Carsey, Jaben" , "edk2-devel@lists.01.org" References: <1518770711-6331-1-git-send-email-meenakshi.aggarwal@nxp.com> <246c3714-d6b9-9ae7-5e66-13192931d824@Intel.com> From: Laszlo Ersek Message-ID: <81caf724-764f-e9b5-2266-76ab6aaab8bb@redhat.com> Date: Fri, 23 Feb 2018 11:17:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 23 Feb 2018 10:17:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 23 Feb 2018 10:17:49 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [RFC] ShellPkg/Ping: fix loss of first packet X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 10:11:49 -0000 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/23/18 10:57, Meenakshi Aggarwal wrote: > Hi All, > > Any comments on this patch or is it good to go? > > Reviewed-by: Jaben Carsey > Reviewed-by: Ruiyu Ni Are you asking for someone to commit & push the patch? Laszlo >> -----Original Message----- >> From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com] >> Sent: Thursday, February 22, 2018 2:03 PM >> To: Meenakshi Aggarwal ; Carsey, Jaben >> ; edk2-devel@lists.01.org; lersek@redhat.com >> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet >> >> On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote: >>> Hi Ray, >>> >>> Please share your comments. >>> >>> >>> Thanks, >>> Meenakshi >>> >>>> -----Original Message----- >>>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com] >>>> Sent: Friday, February 16, 2018 8:51 PM >>>> To: Meenakshi Aggarwal ; Ni, Ruiyu >>>> ; edk2-devel@lists.01.org; lersek@redhat.com >>>> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet >>>> >>>> Seems good to me. I will let Ray review also. >>>> >>>> Reviewed-by: Jaben Carsey >>>> >>>>> -----Original Message----- >>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf >> Of >>>>> Meenakshi >>>>> Sent: Friday, February 16, 2018 12:45 AM >>>>> To: Ni, Ruiyu ; Carsey, Jaben >>>>> ; edk2-devel@lists.01.org; >> lersek@redhat.com >>>>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet >>>>> Importance: High >>>>> >>>>> From: Meenakshi Aggarwal >>>>> >>>>> Issue: >>>>> Reply for first ping packet was getting dropped. >>>>> >>>>> Cause: >>>>> Sometimes reply message comes even before trasmit >>>>> function returns, hence missing 1st reply >>>>> >>>>> Fix: >>>>> Prepare the TxList before calling Transmit function. >>>>> >>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>> Signed-off-by: Meenakshi Aggarwal >>>>> --- >>>>> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++- >>>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>>> index bec9535..46ba701 100644 >>>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>>> @@ -784,14 +784,17 @@ PingSendEchoRequest ( >>>>> } >>>>> >>>>> ASSERT(Private->ProtocolPointers.Transmit != NULL); >>>>> + >>>>> + InsertTailList (&Private->TxList, &TxInfo->Link); >>>>> + >>>>> Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, >> TxInfo- >>>>>> Token); >>>>> >>>>> if (EFI_ERROR (Status)) { >>>>> + RemoveEntryList (&TxInfo->Link); >>>>> PingDestroyTxInfo (TxInfo, Private->IpChoice); >>>>> return Status; >>>>> } >>>>> >>>>> - InsertTailList (&Private->TxList, &TxInfo->Link); >>>>> Private->TxCount++; >>>>> >>>>> return EFI_SUCCESS; >>>>> -- >>>>> 1.9.1 >>>>> >>>>> _______________________________________________ >>>>> edk2-devel mailing list >>>>> edk2-devel@lists.01.org >>>>> >>>> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist >>>> s.01.org%2Fmailman%2Flistinfo%2Fedk2- >>>> >> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b >>>> >> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 >>>> >> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq >>>> 4aQLVSNNti8%3D&reserved=0 >> Reviewed-by: Ruiyu Ni >> >> >> -- >> Thanks, >> Ray