Re: [PATCH 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application

[Pete Batard <pete@akeo.ie>]

Hi Jiewen,

Thanks for clarifying the dependency restrictions. This is something I 
had been wondering about when I ported the app.

I'll work on removing the unwanted libraries and submit a v2.

Regards,

/Pete

On 2016.11.24 12:40, Yao, Jiewen wrote:
> Thank you Peter. I like this porting work.
>
> One comment is that we have special restriction on package dependency.
>  -- The MdeModulePkg should not depend upon ShellPkg.
>  -- The MdeModulePkg can only depend upon MdePkg.
>
> I know you want to parse the shell argument, such as Argc and Argv.
> If an application has ShellPkg dependency issue, the recommended way is to use EFI_SHELL_PARAMETERS_PROTOCOL, which is defined in UEFI SHELL 2.x specification.
>  -- It is located in MdePkg\Include\Protocol\ShellParameters.h
>
> An application may use ShellLib, if and only if it can depend upon ShellPkg, such as a platform Package, or ShellPkg itself.
>
> You can refer to MdeModulePkg\Application\CapsuleApp\AppSupport.c, GetArg() to see how to get Argv and Argc via EFI_SHELL_PARAMETERS_PROTOCOL. :-)
>
> Other part looks good to me.
>
> Thank you
> Yao Jiewen