From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F17581ED8 for ; Thu, 24 Nov 2016 05:06:27 -0800 (PST) Received: by mail-wm0-x230.google.com with SMTP id g23so113828185wme.1 for ; Thu, 24 Nov 2016 05:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=trSC0210ZSixy3pjsJZbo2VSOdHXUzowJC6t7uJ7g3s=; b=EGvWTvcyAtFf4vrB4b1oUA9uR/5VzF7x8Vn/k7bJm4SBMMYTk8Y0K8QpJwYp+IKsmW o15YAJWBfBVJiw51+mE0LQzWpfifeYXqrpiebEFeaYeMEYzT2MiXmRhi5JCBBDjA+rn4 MZtMV6Sw5oh1sIIlXyvVR/5sV4aePjL0PBY4RstBzTKu1NAIecWJg19I2cc0AKZCeY7W 2tEozyK+K0EamKDQ9mI83QZq5dumcph1G/Iu/T8aJ90dOjGoHk59P9EXgjBnM1a4rnum WLydz65Gk3GzHa2PHxgqCFao74KwXVfTMGrCvtt+mnxbCcct4YDoqbz2TiZzzBj5pAre d2Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=trSC0210ZSixy3pjsJZbo2VSOdHXUzowJC6t7uJ7g3s=; b=MYQ+2Q60T/9vKyT6UhQZn8CcXhY5y03E2NwC5+jwNt2tU2t0TaL0A8QzGUXJHH3RQ7 gz5V3+bbxtv3RsW/bQ0J+2QORtY+iGSHL0AaFuJlxgNTLwxnKKeDQ/E1sW0sNOo/OVXb H8X7g7mUVLv203B1JriB+wbmahwAXoozdcM3ybvyk7boJrMMPPriHkHOtDclAyFJ/qxX 32R+Xa9b48B77bwHNmem0ErKpsiCarSX4kEfG5XzLuGcFwQHGKrjtX1apkXFV1k83P+G jRF0F0svF9RtLLjMAXy5YZQF0Hg79irgOzj0s8S5xY5mr6EWqosvoxhitHKEm1mmBHit SO+w== X-Gm-Message-State: AKaTC017CRJSYfvO4ygEAqQn1LzADyddHz5thxe5EGD4WlDxQGIVf2qJxi+GzxV+gDFAfw== X-Received: by 10.28.158.148 with SMTP id h142mr2352015wme.59.1479992785525; Thu, 24 Nov 2016 05:06:25 -0800 (PST) Received: from [10.0.0.101] ([84.203.62.38]) by smtp.googlemail.com with ESMTPSA id l67sm8100104wmf.0.2016.11.24.05.06.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Nov 2016 05:06:24 -0800 (PST) To: "Yao, Jiewen" , "edk2-devel@lists.01.org" References: <20161124112956.3960-1-pete@akeo.ie> <20161124112956.3960-2-pete@akeo.ie> <74D8A39837DF1E4DA445A8C0B3885C50386DA4D5@shsmsx102.ccr.corp.intel.com> From: Pete Batard Message-ID: <81f1910c-8ed9-bd76-1363-962bd82dca4b@akeo.ie> Date: Thu, 24 Nov 2016 13:06:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386DA4D5@shsmsx102.ccr.corp.intel.com> Subject: Re: [PATCH 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 13:06:27 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Jiewen, Thanks for clarifying the dependency restrictions. This is something I had been wondering about when I ported the app. I'll work on removing the unwanted libraries and submit a v2. Regards, /Pete On 2016.11.24 12:40, Yao, Jiewen wrote: > Thank you Peter. I like this porting work. > > One comment is that we have special restriction on package dependency. > -- The MdeModulePkg should not depend upon ShellPkg. > -- The MdeModulePkg can only depend upon MdePkg. > > I know you want to parse the shell argument, such as Argc and Argv. > If an application has ShellPkg dependency issue, the recommended way is to use EFI_SHELL_PARAMETERS_PROTOCOL, which is defined in UEFI SHELL 2.x specification. > -- It is located in MdePkg\Include\Protocol\ShellParameters.h > > An application may use ShellLib, if and only if it can depend upon ShellPkg, such as a platform Package, or ShellPkg itself. > > You can refer to MdeModulePkg\Application\CapsuleApp\AppSupport.c, GetArg() to see how to get Argv and Argc via EFI_SHELL_PARAMETERS_PROTOCOL. :-) > > Other part looks good to me. > > Thank you > Yao Jiewen