From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3303678003C for ; Wed, 20 Dec 2023 22:17:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bZ55oCFvpvPgPgjWGGuvesL0AKjDUh26nrx43tQ4f7g=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703110646; v=1; b=oGjcf2mQCiZB6BXI+y/8DQZ6E6U7UK+y5h/XRopdQXwJx7CyH/y+3WOMmgm89t6fM5JxHSda tet9JcyqI+GeycMhEqzlHDYUEh9MTWZUeDXy8IkS7UJTuu2S6AadHYtG4NSVDsoI8qYGFh46q8V nhBLVppnr2Wim43XLmht7Ycs= X-Received: by 127.0.0.2 with SMTP id lx8wYY7687511xT2O8FZtB4i; Wed, 20 Dec 2023 14:17:26 -0800 X-Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mx.groups.io with SMTP id smtpd.web10.34125.1703110646159074423 for ; Wed, 20 Dec 2023 14:17:26 -0800 X-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0EE3F5C0889; Wed, 20 Dec 2023 17:17:25 -0500 (EST) X-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 20 Dec 2023 17:17:25 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduvddgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgse htkeertddtvdejnecuhfhrohhmpeftvggsvggttggrucevrhgrnhcuoehrvggsvggttggr segsshguihhordgtohhmqeenucggtffrrghtthgvrhhnpeffkeevffekfeefveevhfelue ejveeuueegkefhkefhgfduvdegledvheduffevhfenucffohhmrghinhepghhithhhuhgs rdgtohhmpdhtihgrnhhotghorhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Dec 2023 17:17:23 -0500 (EST) Message-ID: <82022884-bbcb-48ac-9529-9a20d1d6e2b3@bsdio.com> Date: Wed, 20 Dec 2023 15:17:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSF0gQmFzZVRvb2xzOiBGTU1UIEd1aWRUb29sIEF1dG8gU2VsZWN0IENvbmZpZyBmaWxlIEVuYWJsaW5n?= To: gaoliming , devel@edk2.groups.io, gua.guo@intel.com, "'Chen, Christine'" Cc: "'Feng, Bob C'" References: <20231215091151.62-1-yuwei.chen@intel.com> <00ea01da327b$ab80c480$02824d80$@byosoft.com.cn> From: "Rebecca Cran" In-Reply-To: <00ea01da327b$ab80c480$02824d80$@byosoft.com.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8Mw10n8daqjznG4C2zHRCmfYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oGjcf2mQ; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Queued as https://github.com/tianocore/edk2/pull/5177 . On 12/19/2023 6:02 AM, gaoliming wrote: > The change is good. > > Reviewed-by: Liming Gao > >> -----邮件原件----- >> 发件人: devel@edk2.groups.io 代表 Guo, Gua >> 发送时间: 2023年12月19日 15:32 >> 收件人: devel@edk2.groups.io; Chen, Christine ; >> Rebecca Cran ; Gao, Liming >> >> 抄送: Feng, Bob C >> 主题: Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config >> file Enabling >> >> Hi @Gao, Liming and @Rebecca Cran >> >> I may need to get your help for review it, any concern you can also share > for >> us. >> >> Thanks, >> Gua >> >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Yuwei >> Chen >> Sent: Friday, December 15, 2023 5:12 PM >> To: devel@edk2.groups.io >> Cc: Rebecca Cran ; Gao, Liming >> ; Feng, Bob C >> Subject: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config >> file Enabling >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624 >> >> Currently, Python FMMT tool does not support automatically select >> FMMTConf.ini file which saves GuidTool settings. >> This patch supports this features. >> >> Cc: Rebecca Cran >> Cc: Liming Gao >> Cc: Bob Feng >> >> Signed-off-by: Yuwei Chen >> --- >> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py >> b/BaseTools/Source/Python/FMMT/core/GuidTools.py >> index a25681709b..f6bdeffa50 100644 >> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py >> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py >> @@ -110,7 +110,7 @@ class GUIDTools: >> if os.environ['FmmtConfPath']: self.tooldef_file = >> os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini') else:- >> PathList = os.environ['PATH']+ PathList = >> os.environ['PATH'].split(os.pathsep) for CurrentPath in > PathList: >> if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')): >> self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')-- >> 2.42.0.windows.2 >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112772): https://edk2.groups.io/g/devel/message/112772 Mute This Topic: https://groups.io/mt/103261683/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-