From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c00::242; helo=mail-pf0-x242.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48649207DF2AD for ; Tue, 3 Jul 2018 23:47:14 -0700 (PDT) Received: by mail-pf0-x242.google.com with SMTP id j3-v6so2181373pfh.11 for ; Tue, 03 Jul 2018 23:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=CFxaz9xFd83306xzTNY8HqTPsgvMbyeUIC42C7EoeaQ=; b=cDQeryu0X/hhY2SJYiOTScm9B0eBEqdPmgWVRukOFoUNaboKDLA2EncwfqZAWAG3qZ sBHh+w6XRxiE9P4eptoOwwd1TP+NLczoSuBIcj4RQFqR2UHQJK4q9HRP4PWs4OD77yKZ nnFoTeaxsRSU8ugd8Gk2D1JKqIVwVjD3s7pbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=CFxaz9xFd83306xzTNY8HqTPsgvMbyeUIC42C7EoeaQ=; b=qXirJaZNT+hAy2pNGsH4l/E75+aiJ8PtGVufqzuAzu/J/IWc8f8i69NNdx/9QWJrAU MjltDja2MuEcuW67BjBdOInyRAXWNF6c4OERTB+TbgRc4RtTJok+/i7S3QttxyfjOd1P gYOAYVn8l4h8rC3hAriCsnxWdmVRuNP85OMcYPUuNWqgiFVxMaAw4KDhinRfL3f2QHkt anWGX+icYzwFJAlv2roSFo/WyngMwMpq9ioQV4cmA3/ytAB5+ziu2n9Fhh+ei+Dfm+Tw H9MVDwLqH+rvZnZpC3sAWs3MOyY7NljbPg0JIyBMZ4ryfBIc3ysPpQkA1aZK5RnLhwGh RDmw== X-Gm-Message-State: APt69E2xcyo+RaBl9qq/A+Y+aUjbOQzVRNsg3hlK3UU9gbCYcX9rTrzu rcTlnshzni20WdgBTtSpcpZxyw== X-Google-Smtp-Source: AAOMgpdICOd/1Bwy13A52tBfsE4XLYRQoTWF4WJ8r/xIN4whSPsosOMdascx8ZULaMIegH1b+kwJEA== X-Received: by 2002:a63:3444:: with SMTP id b65-v6mr758798pga.396.1530686834640; Tue, 03 Jul 2018 23:47:14 -0700 (PDT) Received: from [10.116.2.14] ([64.64.108.75]) by smtp.gmail.com with ESMTPSA id y2-v6sm10242470pfa.43.2018.07.03.23.47.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 23:47:14 -0700 (PDT) To: Ard Biesheuvel Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , huangming , Jason Zhang , huangdaode@hisilicon.com, John Garry , Heyi Guo References: <20180627070443.42886-1-ming.huang@linaro.org> <20180627070443.42886-2-ming.huang@linaro.org> From: Ming Message-ID: <82041668-378a-13c1-0f64-78a805b80457@linaro.org> Date: Wed, 4 Jul 2018 14:46:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH edk2-platforms v1 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 06:47:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit 在 27/06/2018 15:20, Ard Biesheuvel 写道: > On 27 June 2018 at 09:04, Ming Huang wrote: >> The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe should run early. >> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >> gDS->SetMemorySpaceAttributes is invoked by several drivers. >> >> Add several drives to APRIORI scope for implementing the ordering. >> > > Please solve this by adding DEPEXes on gEfiCpuArchProtocolGuid to the > drivers in question. > Sorry, I made some mistakes about depandence in previous email. This issue can solve by adding Depex on gEfiCpuArchProtocolGuid to RealTimeClockLib and SFCDriver(flash driver). Thanks. >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo >> --- >> Platform/Hisilicon/D03/D03.fdf | 10 +++++++++- >> Platform/Hisilicon/D05/D05.fdf | 6 +++++- >> 2 files changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf >> index 1383aa1091..027b53a6cf 100644 >> --- a/Platform/Hisilicon/D03/D03.fdf >> +++ b/Platform/Hisilicon/D03/D03.fdf >> @@ -146,6 +146,14 @@ READ_STATUS = TRUE >> READ_LOCK_CAP = TRUE >> READ_LOCK_STATUS = TRUE >> >> + APRIORI DXE { >> + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> + INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> + INF Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf >> + INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> + } >> + >> INF MdeModulePkg/Core/Dxe/DxeMain.inf >> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> >> @@ -153,6 +161,7 @@ READ_LOCK_STATUS = TRUE >> # >> # PI DXE Drivers producing Architectural Protocols (EFI Services) >> # >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf >> >> @@ -186,7 +195,6 @@ READ_LOCK_STATUS = TRUE >> >> # Simple TextIn/TextOut for UEFI Terminal >> >> - INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf >> >> INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf >> index 4503776d63..37d9cc0c18 100644 >> --- a/Platform/Hisilicon/D05/D05.fdf >> +++ b/Platform/Hisilicon/D05/D05.fdf >> @@ -148,6 +148,10 @@ READ_LOCK_STATUS = TRUE >> >> APRIORI DXE { >> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> + INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> + INF Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf >> + INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> } >> >> INF MdeModulePkg/Core/Dxe/DxeMain.inf >> @@ -157,6 +161,7 @@ READ_LOCK_STATUS = TRUE >> # >> # PI DXE Drivers producing Architectural Protocols (EFI Services) >> # >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf >> >> @@ -190,7 +195,6 @@ READ_LOCK_STATUS = TRUE >> >> # Simple TextIn/TextOut for UEFI Terminal >> >> - INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf >> >> INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> -- >> 2.17.0 >>