Re: [edk2-announce] Community Meeting Minutes

[Andrew Fish <afish@apple.com>]

> On Feb 8, 2019, at 9:33 AM, Rebecca Cran via edk2-devel <edk2-devel@lists.01.org> wrote:
> 
> 
> On February 8, 2019 at 2:01:59 AM, Laszlo Ersek (lersek@redhat.com(mailto:lersek@redhat.com)) wrote:
> 
>> I don't see the workflow modification as viable. The "patch series"
>> concept is integral to every single open source project that I've ever
>> worked with. The evolution of a feature or a bug fix over a series of
>> patches is a core facet of programming and reviewing. It communicates a
>> thinking process, and that's what programming is about.  
> 
> I don’t recall coming across the patch series (e.g. the 1/5 email patches) in other projects. In other projects people post a single patch and then update it following feedback on the same review. This can be either in a single, rebased commit, or new commits on a bug/feature branch - review systems deal with both.
> 

Rebecca,

I think the patch workflow is kind of like a coding standards. Some folks advocate for lots of small patches (common in open source projects), and some folks advocate for a patch per bug. I think the biggest upside to the patch granularity is it is much easier to bisect a failure. 

So I've used Bitbucket with a branch per commit (you name your branch with a standard pattern and the bugzilla  ) model and if your branch has a patch series (set of commits) you can view each commit independently from the UI and the default view is the entire patch series. So you can see both. 

Thanks,

Andrew Fish


>> So how long do we wait?
>> 
> 
> 
> Good point!  
> 
>> 
>> 
>> What I find practical at this moment is what Stephano has been working
>> on (thank you for all that Stephano) -- collect & file official
>> improvement requests with GitHub, and then see how those things are
>> addressed. In my opinion (not having seen Gerrit anyway, which remains
>> to be evaluated, but not by me), GitHub is the direct runner up to the
>> mailing list, so improving GitHub would be the most practical. In
>> particular I envision the context improvements for the GitHub email
>> notifications as something very doable for GitHub.  
> 
> 
> 
> 
> 
> I’d certainly be happy to use Github, but I do worry about tieing ourselves to such a closed system.
> 
> 
> 
> 
> 
> 
> Rebecca
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel