public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, ard.biesheuvel@arm.com
Cc: leif@nuviainc.com
Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 7/8] Platform/ARM/VExpressPkg: incorporate Lan9118 driver
Date: Mon, 4 May 2020 13:44:29 +0200	[thread overview]
Message-ID: <82168186-9c7e-d00a-e236-6ce3398dd45f@redhat.com> (raw)
In-Reply-To: <ed9fd267-526d-f32b-7c2c-633044043445@redhat.com>

On 5/4/20 1:42 PM, Philippe Mathieu-Daudé wrote:
> On 4/30/20 7:16 PM, Ard Biesheuvel wrote:
>> Incorporate the Lan91x driver from EmbeddedPkg, which is only used
>> on obsolete ARM development platforms and does not follow the UEFI
>> driver model. This will allow us to drop if from the core EDK2
>> repository.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> ---
>>   Platform/ARM/JunoPkg/ArmJuno.dsc                             |    8 +-
>>   Platform/ARM/JunoPkg/ArmJuno.fdf                             |    2 +-
>>   Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc            |    6 +-
>>   Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf            |    2 +-
>>   Platform/ARM/VExpressPkg/ArmVExpressPkg.dec                  |    8 +
>>   Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c     | 1539 
>> ++++++++++++++++++++
>>   Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h     |  304 
>> ++++
>>   Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf   |   58 +
>>   Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h   |  401 
>> +++++
>>   Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 1039 
>> +++++++++++++
>>   Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h |  283 
>> ++++
>>   11 files changed, 3641 insertions(+), 9 deletions(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Without acute on EDK2:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


  reply	other threads:[~2020-05-04 11:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 17:16 [PATCH edk2-platforms v3 0/8] move obsolete platform drivers out of core edk2 Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 1/8] Omap35xxPkg/LcdGraphicsOutputDxe: add missing protocol reference Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 2/8] Platform/ARM/VExpressPkg: incorporate PL180 driver Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 3/8] Platform/ARM/JunoPkg: incorporate SiI3132 SATA controller driver Ard Biesheuvel
2020-05-04 10:57   ` Leif Lindholm
2020-04-30 17:16 ` [PATCH edk2-platforms v3 4/8] Silicon/Synopsys/DesignWare: import eMMC DXE driver from EmbeddedPkg Ard Biesheuvel
2020-05-04 10:58   ` Leif Lindholm
2020-05-04 11:40     ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-04 11:44       ` Philippe Mathieu-Daudé
2020-04-30 17:16 ` [PATCH edk2-platforms v3 5/8] Platform/HiKey: switch to relocated version of eMMC driver Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 6/8] Platform/ARM/VExpressPkg: incorporate Lan91x driver Ard Biesheuvel
2020-05-04 11:41   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-04 11:44     ` Philippe Mathieu-Daudé
2020-04-30 17:16 ` [PATCH edk2-platforms v3 7/8] Platform/ARM/VExpressPkg: incorporate Lan9118 driver Ard Biesheuvel
2020-05-04 11:42   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-04 11:44     ` Philippe Mathieu-Daudé [this message]
2020-04-30 17:16 ` [PATCH edk2-platforms v3 8/8] Platform/ARM/VExpressPkg: incorporate ISP 1761 USB host driver Ard Biesheuvel
2020-05-04 11:00   ` Leif Lindholm
2020-05-04 11:00 ` [PATCH edk2-platforms v3 0/8] move obsolete platform drivers out of core edk2 Leif Lindholm
2020-05-04 13:19   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82168186-9c7e-d00a-e236-6ce3398dd45f@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox