From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9AF41740038 for ; Thu, 4 Jul 2024 11:43:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sBXsL0vkYaFPTCb8/wiACThi6h3kd4xjXoAh3D0Vkds=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20240206; t=1720093394; v=1; b=rUpxgC+q+VvlZnFvgPph9kDnn8gKb1uaFjvLzYG5rr/JOHG/xscMmXbfFbo3nscQYEa1/ofs EsVgvCly6sCEF/YbvhOpOJA61oWSZzx1G6xwY0OlfKKeopRUlUw4rqO9Jy5/+F9UsxQnfbYknOS WveUkkTa2brvU7bVeICuUafiiPDBSJt7wpPdoV3Kk3ZnhyCjcVXHJKwoXWbsjISFEogN0DftQ0Y dIdeL8Wn//ywQxY6l7LsYFVdEl8SIxpanfQMoVqjwO4W5aljUajfsEaUSYgCaBrxhDKMBcH+k57 4AiDnk4lnoHPKD5QADwb6mspkJ29hKe9NhguyOCY3MNIg== X-Received: by 127.0.0.2 with SMTP id Swv9YY7687511x1mPOroT40S; Thu, 04 Jul 2024 04:43:12 -0700 X-Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by mx.groups.io with SMTP id smtpd.web11.8163.1720093386922077129 for ; Thu, 04 Jul 2024 04:43:07 -0700 X-Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a7527afa23cso64037966b.2 for ; Thu, 04 Jul 2024 04:43:06 -0700 (PDT) X-Gm-Message-State: Pzvlk1c6mnGrvZ6McLYmtOPHx7686176AA= X-Google-Smtp-Source: AGHT+IFmZaD5AA9yMgju9KfRn/xf9LayN1IGYaecHwsgWsZBAGAWZ/2Q0CRQcBSTgs/zMXLBatvVdg== X-Received: by 2002:a17:906:d0cd:b0:a72:5715:f7b9 with SMTP id a640c23a62f3a-a77ba4557a3mr112342666b.15.1720093384117; Thu, 04 Jul 2024 04:43:04 -0700 (PDT) X-Received: from puchatek.local (83.8.74.165.ipv4.supernova.orange.pl. [83.8.74.165]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a76841c4ffcsm188615366b.41.2024.07.04.04.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 04:43:03 -0700 (PDT) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io, Leif Lindholm Cc: Ard Biesheuvel , Graeme Gregory Subject: Re: [edk2-devel] [PATCH edk2-platforms v2] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL Date: Thu, 04 Jul 2024 13:40:51 +0200 Message-ID: <82403622.khezKcZkOS@puchatek.local> In-Reply-To: References: <20240703-efi-rng-protocol-v2-1-73a486537538@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 04 Jul 2024 04:43:07 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rUpxgC+q; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Dnia czwartek, 4 lipca 2024 13:27:38 CEST Leif Lindholm pisze: > > By default we have Neoverse-N2 cpu which supports FEAT_RNG feature. Thi= s > > allows us to add RngDxe to have EFI_RNG_PROTOCOL available on > > Neoverse-N2 and 'max' cpu cores. > >=20 > > Commit 5de5e230a80bed083360da95ba16a2c4a001620d (in EDK2) enabled that = for > > ArmVirt platform. > >=20 > > RNDR is implemented by both Neoverse-N2 and 'max' cpu implemented by QE= MU. > > Other cpu models lack it which prevents the RngDxe driver from running, > > resulting in the same situation as before. > >=20 > > TRNG is not implemented in TCG mode but is required by RngDxe to run. > >=20 > > On older cpu cores nothing changes. > >=20 > > Signed-off-by: Marcin Juszkiewicz >=20 > Thanks! >=20 > Reviewed-by: Leif Lindholm > With one niggle below: Thanks. Fixed and pushed as 25d66c5b9e5cd672b6e2723d4308cd815639f880 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119794): https://edk2.groups.io/g/devel/message/119794 Mute This Topic: https://groups.io/mt/107018350/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-