From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F0213D810CD for ; Wed, 18 Oct 2023 13:36:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Z/qwVJIjcc8738p+3MOVesVyCxFZeOty97O+JCcone4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697636212; v=1; b=XiHW9GO02jU85tj5RQR0AG9Uebfspy6oOcQvSD5F72WuyA52//XjROve3nwvp86a1YPCv4VK nBs0YqcZkbBS4Shfj0ehBO39lSWWzkFZkQH9REqUaMIwev5odKxxikXnamgiMhmwlOExADw92xp FvrPrixPy8+TSQNJ4QLyHjyA= X-Received: by 127.0.0.2 with SMTP id JKnWYY7687511xnl1tPmO3t0; Wed, 18 Oct 2023 06:36:52 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.281354.1697636211810663159 for ; Wed, 18 Oct 2023 06:36:51 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-416-atCtNKXgNyOESstClkiR7Q-1; Wed, 18 Oct 2023 09:36:47 -0400 X-MC-Unique: atCtNKXgNyOESstClkiR7Q-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AA0ED88B77E; Wed, 18 Oct 2023 13:36:46 +0000 (UTC) X-Received: from [10.39.192.202] (unknown [10.39.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E85D11C060AE; Wed, 18 Oct 2023 13:36:44 +0000 (UTC) Message-ID: <8267a6da-307a-ffc6-5ad4-250245b18a28@redhat.com> Date: Wed, 18 Oct 2023 15:36:43 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org, Pedro Falcato Cc: Nhi Pham , Leif Lindholm , Ard Biesheuvel , Jeremy Linton , Chuong Tran , Rebecca Cran References: <20231018-ehci-xhci-fix-v4-0-aa53138997a5@linaro.org> <20231018-ehci-xhci-fix-v4-4-aa53138997a5@linaro.org> <75b23ede-8f50-4d44-a786-fb04cd4abd00@os.amperecomputing.com> <2d881cf4-d12b-4ddb-8a5c-deb5f070c1cc@linaro.org> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: B76eaS6cMW8CyOoKLoqJCM3tx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XiHW9GO0; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 10/18/23 13:28, Marcin Juszkiewicz wrote: > W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: >> On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz >> wrote: >>> >>> W dniu 18.10.2023 o 12:32, Nhi Pham pisze: >>>> Acked-by: Nhi Pham >>>> >>>> Nit: I think you want to run uncrustify for Patch 3 as well :) >>> >>> Done, will check other changes too. >>> >>> I have a strong feeling that Qemu part of EDK2 needs a bit >>> bigger patch when it comes to formatting: >>> >>>    >>> Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h                 |   7 +- >>>    >>> Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c            |  33 +- >>>    >>> Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry.nasm          |  99 ++- >>>    >>> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c                           | 108 +-- >>>    >>> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c                             |  30 +- >>>    >>> Platform/Qemu/QemuOpenBoardPkg/README.md                                          |  43 +- >> >> Something must be wrong with your config because QemuOpenBoardPkg is >> and was, AFAIK, all formatted using uncrustify. And if I run it >> locally, it seems to agree with me. > > EDK2 expects some random version of uncrustify. > > It is not part of BaseTools so I use upstream version. And it looks like > they format in different way using the same config file. Project URL (to clone and build): https://projectmu@dev.azure.com/projectmu/Uncrustify/_git/Uncrustify Command line options to pass to the binary: -c ${EDK2_ROOT}/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg \ --replace \ --no-backup \ --if-changed \ You can specify the pathnames to reformat as operands, or you can additionally pass the "-F -" option, and then the pathnames will be read from stdin. Make sure you have committed or at least staged your changes, before running this command, because these options will update the files in-place. The only really important option is of course the "-c" one. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109748): https://edk2.groups.io/g/devel/message/109748 Mute This Topic: https://groups.io/mt/102035954/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-