From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 01 Aug 2019 17:12:52 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24DD6312FF99; Fri, 2 Aug 2019 00:12:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81A675D9CD; Fri, 2 Aug 2019 00:12:51 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print. To: "Johnson, Michael" , devel@edk2.groups.io References: <93d4a7e7-9b86-b3c9-a476-ac1a40dc4723@redhat.com> <4873.1564610679757881540@groups.io> From: "Laszlo Ersek" Message-ID: <8293959e-4fe0-a9d5-ef02-cd84c9ba4701@redhat.com> Date: Fri, 2 Aug 2019 02:12:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4873.1564610679757881540@groups.io> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 02 Aug 2019 00:12:52 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08/01/19 00:04, Johnson, Michael wrote: > I do not see a downside to making MAX_DEBUG_MESSAGE_LENGTH a fixed at b= uild PCD.=C2=A0 It's currently #define'd in a variety of places, which in= my opinion is just asking for trouble. A fixed-at-build PCD sounds good to me. (Not ignoring the rest, just got nothing to add :)) Thanks! Laszlo