From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.87]) by mx.groups.io with SMTP id smtpd.web10.6773.1628003367926439316 for ; Tue, 03 Aug 2021 08:09:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ATtBrpAJ; spf=pass (domain: arm.com, ip: 40.107.20.87, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQwHYtcEnx7v/1TSrRSjY+r53d1co/+rINu7wY+WaGI=; b=ATtBrpAJGhOOJqMI+duJ42i+aJC4e0zV/pB6j/xPKg8g7qjF68ZUqiD3/eahIg9mdr10Tm2TgI51Sraa+vOoiddm5MxU0q5+NdrdIm5LEGdCXYkUNSv5NEqru0u7X6hZ87cp9F+f8uaqwSV+pAeIIJff//swSqxQv5U7kxr/M10= Received: from DB6PR0201CA0005.eurprd02.prod.outlook.com (2603:10a6:4:3f::15) by AM8PR08MB6401.eurprd08.prod.outlook.com (2603:10a6:20b:361::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.31; Tue, 3 Aug 2021 15:09:25 +0000 Received: from DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::16) by DB6PR0201CA0005.outlook.office365.com (2603:10a6:4:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 3 Aug 2021 15:09:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT020.mail.protection.outlook.com (10.152.20.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 3 Aug 2021 15:09:25 +0000 Received: ("Tessian outbound 7b804b1d9bbf:v101"); Tue, 03 Aug 2021 15:09:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 00a0cee3cce9a147 X-CR-MTA-TID: 64aa7808 Received: from ecc45f6ebc69.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D4C2086C-12A9-40B5-B668-5FEE385DB156.1; Tue, 03 Aug 2021 15:09:19 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ecc45f6ebc69.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Aug 2021 15:09:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jvfkgUAuvBYiU9f3sPjbX/vOnqBWtmO1FAysrVW6A9nc3xGUzgAV6gXO5JewgC3DS2XFclwN3edS3CUEw04zWqGFEBDp3+lfAYNnBe7thIqjxzfWthkbSdwTfW8wz7x1Cb/VpvUOpjRvHZMhkPCWIp9X9bMWTSRXqTBFxEN/Ie/mv/iXi7zqyBKMGztVi7+hvojb+4XqPaNZBfOQKuEHBLK5QRQ4RqFeEpsHrpYg5nTd0UO1P9vkXnxlWfWxen0mBMczaPY09DAXxrBqlj3uSMzrEC5U5PLqOy+c6YLoWET+Seq2+BYkgDCi+e+t30zBOTwe0HpaM92FUeOvMxLOXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQwHYtcEnx7v/1TSrRSjY+r53d1co/+rINu7wY+WaGI=; b=hecpLPEFzQEPSgelGU71O/6NU0OQZoU9VBliBHISaZ0WSCdvKfjIX8+YdpIU00uPm7eXxHxEmQC14R6k5yil7cVPle6niZNljIWIIqoUXcHvqq4o8mAeafcck0G4IJKblV/ul4qkfMLFBVBTuENsMwiro3GtGzFCusIGOc7a6jb5pUdIpQlFetrFkESLfDQBPV6+u76Vged/noGnVe7cAGi9/O30HoYvDXsvuftX4ofiyvBFBmrmHIQsy5bm+4aJtTuUS1JziqcJbWPjnS6yDFb7lx4hr1MikvwYlr239E+Sh6CbEBx6JbXMhMcjFTfEGNYZlbC4nWxFoZpd8rF6uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQwHYtcEnx7v/1TSrRSjY+r53d1co/+rINu7wY+WaGI=; b=ATtBrpAJGhOOJqMI+duJ42i+aJC4e0zV/pB6j/xPKg8g7qjF68ZUqiD3/eahIg9mdr10Tm2TgI51Sraa+vOoiddm5MxU0q5+NdrdIm5LEGdCXYkUNSv5NEqru0u7X6hZ87cp9F+f8uaqwSV+pAeIIJff//swSqxQv5U7kxr/M10= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6216.eurprd08.prod.outlook.com (2603:10a6:20b:29c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Tue, 3 Aug 2021 15:09:18 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ca6:6171:e2f1:3d40]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ca6:6171:e2f1:3d40%4]) with mapi id 15.20.4373.026; Tue, 3 Aug 2021 15:09:17 +0000 Subject: Re: [PATCH v2 4/4] ArmPlatformPkg: Add helpers for HEST table generation To: Omkar Anand Kulkarni , devel@edk2.groups.io Cc: Ard Biesheuvel , nd References: <20210710161831.30433-1-omkar.kulkarni@arm.com> <20210710161831.30433-5-omkar.kulkarni@arm.com> From: "Sami Mujawar" Message-ID: <82d1e2f0-f142-4356-cc0b-30c75eb39dd4@arm.com> Date: Tue, 3 Aug 2021 16:09:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210710161831.30433-5-omkar.kulkarni@arm.com> X-ClientProxiedBy: LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.54) by LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 3 Aug 2021 15:09:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e18baf55-f9cb-43b4-b1fb-08d95690aedb X-MS-TrafficTypeDiagnostic: AS8PR08MB6216:|AM8PR08MB6401: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cWNf40YbX/M5ElK9jdYZ4Ua9o3Cs/4z9Rqta0hT8XU6f5sTFhYOWN9uKj57xZUrdeNXyVDf5jX+Ozn2zp8cIP7IOPnga1LIqB+SzLXKHJ/kTRtqiqSm9W7bkUlR07p5/ys0Gm72wgiy+vC2oz5Rn0qFIIUxYFXiYFOFdCiUHJyKk0QueUbxR4cLo9rgH/UGbBA6VtDwcYKOfb4urwpqS/dHrLUXqkasOHOvvqLfcj/+R2FNykadsO0pKeqBxX2fpSDD/IkOOQBqVoTuN2WS0cd1hm1C4JkDsLX+wrLRQ7R0ZDgYDIsUBg8WNxwlE/l9YA0s8arUEXoVrvbWtqZvkpTkNLPljt4LNkRustTIZ0Wy11mbAm4jCVyP+e2PV8MA/md9OTIjb2BmNZDIuwmuV39XL9MVxSS9M2UnSulCBTKHeuspCfWNowHbAIEA6s1i3wy3ULRvrU7gPQZUs7Hc2mY7FOTDVzQlKudYeXZdJy+Y0WpYxH0m9RVWmnBBb7WMPflBr+hkZ1+bklJM0aDc4N2IvmK99SAQ0GxxNr07WQ7VWBc6p6jw0YuI8dBSGZvxk3sKrrh9+6szKKt9e37r94co1LBcvcYbWDhkKiWSb0HlNKtDYhKDlGAOu1/sQRq/sv9igAZ1IjRlCmZGJQWZKxN6UJFX8ZKT35c2yPZgdCqNI8craQEOXnxLuPwJwRWaWOmyF4K6jEhcXs7zlxqfY/tT++3i0Yvjcxxg9Xe3LrBY7QGco/pZSC3dL13aIOWiG+bLDVv2b/0ibYPvn8b07AA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(346002)(366004)(396003)(376002)(136003)(36756003)(86362001)(478600001)(6666004)(8936002)(31696002)(54906003)(4326008)(316002)(16576012)(44832011)(38100700002)(5660300002)(186003)(26005)(38350700002)(31686004)(2616005)(956004)(2906002)(52116002)(8676002)(6486002)(66476007)(66946007)(83380400001)(53546011)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTF0UFJSOTF6aCtSQUJ0RTZiYnEwTzIyYVNHUythUkVSSS82NXhBSG5NTW1W?= =?utf-8?B?NXVSbHc2MFFvckZvZFBNVXZ2emgrYXpDZGt5eWJBYzR1K0F3QmQ4azBJenlI?= =?utf-8?B?Y0VVakhSdlJEeWJneGxjUnFSbUdyVWVpMTFGdkFiRlVQUWdFQXhlZXNWTzJ4?= =?utf-8?B?bE1UWDNYYWl6SUVieWRtbnZxQVg3b1AwaTNzZytxZjl5WFZpODN4bHpIS0Jv?= =?utf-8?B?ejE0V01TQi9NUDRVRjQ2Y2NJSkVqSHpaVTB1dDJoRGJFOTJ6TnNTSmw2Vmpr?= =?utf-8?B?eEprR2hTQTdUdnFaNUZBZ0p0WXh1YU5VNitIc0tvbkk0S2xCY0FpTnU0d3c4?= =?utf-8?B?U2JVNE12dnM1TkdyNzczbU1qRDZZM1o1dzBDODcrcVc3MUdXVEo1YUZlYkFu?= =?utf-8?B?SXlIK3V0R0dlc1JpNVpDMnh4UThhQnN4NUNzYmVCdjNsUk5TYUZlaXVwNits?= =?utf-8?B?S2dVWXJtajBUMjd5U2pwRno1K3ZZUnZSTFAzM0tlRFRyZ3BZTFdwbEtpZ3pB?= =?utf-8?B?TjFhVmh3c29zU1BHT3ZLQnhBUy9vTnAyTVhGekpXUGhGOWllUVkrSjdob1Fz?= =?utf-8?B?M2VPQkFYbDhleHFLbFVzQ281S0RkZ0VReGhIRGVQd3dmRWFTK3pGT3JONjlz?= =?utf-8?B?TnppV3JlckZ5V0VXMng5T1liaEZXdzczbE05TkpURVdRc3d2TVd6TXY2UjI3?= =?utf-8?B?MTBuTWNDdGlIM0ZRNVA4Q1E1cE5OUkpWZEgvcXdUWFJaeG9VRUJRS2M3ZXFY?= =?utf-8?B?ekdaWGkvMzE3RlU4MzRKclYwSVJxejNlRjRyNlUyS2t2YWw5WFBuK3hwOHcw?= =?utf-8?B?dFd3QythVlRQd1d3azdtRnRiVDZHVEx5VjM1SjJiaVBiREhYS1FzWVNqcDRW?= =?utf-8?B?ZGplVlFrT1JPK3RiREtFKzdlYllpLzUrTEZqZXl2SDhoSG9vZHljU3JYRldk?= =?utf-8?B?ZitWbVp0eStZWmU2bFpIaU55eVg2cmNMLzBiNndueWFjWkRPYklNWmxyQTFi?= =?utf-8?B?SGd2Yk5jS3ZzN0h5eHlId3V6WjArVmVDdUZGMVJpQVN5ZWcvUHVVOWVVSlBv?= =?utf-8?B?SlhqOWFMWVNQSndSdGZ4S3U3VFlNdHdMR1JlY3RBbzdZVEMxYUltUmhMWUE5?= =?utf-8?B?T245TFA3ZGdhNmNYeTZhSTBIcS82TXRsWGJNeXJMOTZXYkwxcENYVnhwUGdt?= =?utf-8?B?MUo5eGxrYkVmTXl3bStrNGRCTlhPdFBmSUVIM2N4YkNLZVVNTjlpUUpOUmZa?= =?utf-8?B?c0JBSzdJT3dYNWhWVmdzR21pSWVlUllqdmUxQ3RhRjBGNVZBN2lPWXBRdURR?= =?utf-8?B?eHBuMXE2bG40SDRRdm03T2UxaDNxd2txa05qVlJqYWVHMWkvVTlaNHhtRnAr?= =?utf-8?B?aVMvV3p6VVVUMnQ2ZytYWXVBUGdnTW5kUnRzOEtvNkFhYzdPaU9QK2Y2Rnhl?= =?utf-8?B?Z1ZuR2lJWit5cWxDUVBiZUtMYkIwelRpZGdVY2JLdEhpcWsvYmVDQm5PSTFh?= =?utf-8?B?Z1FkMkpzeWtWQU1PN0VNTWtxUUJwZ05FVllBK0VtZ0UvWkIzRU1EUjd3cHlB?= =?utf-8?B?TURydC8vOGw1T1J4M0gya3ZKUFF2NWVkRFlSdVlMR3N6WUNGNUt3RklMWEZB?= =?utf-8?B?MGtFTTRGMkdKVVFxaTlneFY2aVJnRWlCT3FpYnF0cVV3Z0xpNFBldnNCeUh3?= =?utf-8?B?ODIwRFBKeHpJQ3lpaUdNLzhDTDUvWTFXMEdqTksyWitVTWxscExya1FKOVFG?= =?utf-8?Q?aqiWdkY4Q34C/cNa+urV0rlKUhCwLQTL8JUV+9h?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6216 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: adedb382-0ccf-417f-3400-08d95690a9aa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F2AMgjwbHRyrZDnaIxHsuJgaQgsqL2LwMRfokPoxweGaCA9dQGHHQA1i63jbJgmfiocOhwnDipgCRlAtxMwOjHFQDZOpw/9infg68C/l5dE7GuqeGWYR2vXF8wVsZ0GPFt2MxmSNMSoFOZpXkl2XDDQ7bTtaPhos0Zk43QzL5X1bwI02wxqkdjDR5XxgP0xPSHBD/uwefWczoIgeeeaNpuXIfDHw7n5F/kHNZ5+wQjD8Gaij5SWcaAbwihZ8KttFQ4pQvqVicZEF4QUslJq4R8RLK8clffbrdwZ/uU3Oa6Ur3LaiWXH6NUV7cnmTIHuWRvjvHelFR68/exKPnxVEq/j5kgED/tvgkdg1wzz6BDBa/bMvt0rL3yzcATFmIKoLsXN5Sgcjc/uSUfIksqrrdG2gCWpmbKHuhv4Ogrb/NnzPNGVriCXDRd+OEz0nfFBg9AKJEPkobb3rJsS9QAEL1PHeWgZdTtH0BfV4K4tOmwx+bicCh5YYjz+DP513JVwgCJD8NJZ2KDQF9S0SMpCVdewb23eQP7puoaWmNNw3tdKjv1m4azZ/wrRgYWzDjaRB0s8Sd/sdgIwXJJv9CJ9SQx+ZXoXf7Sx2mkVHnW2yaCxH/n1j7BtQZG/xG03uhhl0PQepWV66UFOGCxWt4CLcmH9ofiCW2VM5MJ8emwQE+vdcffeaopn1SiGGW9wXz65u+xx5x19eSETntVZMvzxjcWJU2/i0Pj9ph13cOBFaekk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(376002)(39850400004)(136003)(346002)(36840700001)(46966006)(86362001)(4326008)(82310400003)(16576012)(70206006)(8936002)(478600001)(336012)(70586007)(6666004)(6486002)(31686004)(5660300002)(82740400003)(956004)(356005)(54906003)(81166007)(47076005)(53546011)(36756003)(186003)(36860700001)(44832011)(316002)(31696002)(26005)(83380400001)(2906002)(8676002)(2616005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2021 15:09:25.8468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e18baf55-f9cb-43b4-b1fb-08d95690aedb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6401 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Omkar, Thank you for this patch. I have a minor suggestion marked inline as [SAMI], other than that this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: > Add helper macros for the generation of the HEST ACPI table. Macros to > initialize the HEST GHESv2 Notification Structure and Error Status > Structure are introduced. > > Signed-off-by: Omkar Anand Kulkarni > --- > ArmPlatformPkg/Include/HestAcpiHeader.h | 49 ++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/ArmPlatformPkg/Include/HestAcpiHeader.h b/ArmPlatformPkg/Include/HestAcpiHeader.h > new file mode 100644 > index 000000000000..5112ee5b22c5 > --- /dev/null > +++ b/ArmPlatformPkg/Include/HestAcpiHeader.h > @@ -0,0 +1,49 @@ > +/** @file > + HEST table helper macros. > + > + Macro definitions to initialize the HEST ACPI table specific structures. > + > + Copyright (c) 2021, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Specification Reference: > + - ACPI Reference Specification 6.3 > + - UEFI Reference Specification 2.8 > +**/ > + > +#ifndef HEST_ACPI_HEADER_ > +#define HEST_ACPI_HEADER_ > + > +#include > + > +// > +// HEST table GHESv2 type related structures. > +// > +// Helper Macro to initialize the HEST GHESv2 Notification Structure. > +// Refer Table 18-394 in ACPI Specification, Version 6.3. > +#define EFI_ACPI_6_3_HARDWARE_ERROR_NOTIFICATION_STRUCTURE_INIT(Type, \ > + PollInterval, EventId) \ > + { \ > + Type, \ > + sizeof (EFI_ACPI_6_3_HARDWARE_ERROR_NOTIFICATION_STRUCTURE), \ > + {0, 0, 0, 0, 0, 0, 0}, /* ConfigurationWriteEnable */ \ > + PollInterval, \ > + EventId, \ > + 0, /* Poll Interval Threshold Value */ \ > + 0, /* Poll Interval Threshold Window */ \ > + 0, /* Error Threshold Value */ \ > + 0 /* Error Threshold Window */ \ > + } > + > +// Helper Macro to initialize the HEST GHESv2 Error Status Structure. > +// Refer Section 5.2.3.2 in ACPI Specification, Version 6.3. > +#define EFI_ACPI_6_3_GENERIC_ERROR_STATUS_STRUCTURE_INIT(Address) \ [SAMI] Would it be possible to define ARM_GAS64() in EmbeddedPkg\Include\Library\AcpiLib.h instead of this macro? Similarly, can EFI_ACPI_6_3_HARDWARE_ERROR_NOTIFICATION_STRUCTURE_INIT() macro also be placed in EmbeddedPkg\Include\Library\AcpiLib.h [/SAMI] > + { \ > + 0, /* UINT8 Address Space ID */ \ > + 64, /* Register Bit Width */ \ > + 0, /* Register Bit Offset */ \ > + 4, /* Access Size */ \ > + Address /* CPER/Read Ack Addr */ \ > + } > + > +#endif /* HEST_ACPI_HEADER_ */