public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, kuqin12@gmail.com
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Andrew Fish <afish@apple.com>, Leif Lindholm <leif@nuviainc.com>,
	Hao A Wu <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/6] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update
Date: Wed, 23 Jun 2021 12:02:34 +0200	[thread overview]
Message-ID: <82e2e6ef-2334-0b12-2b5d-27aa8fdac783@redhat.com> (raw)
In-Reply-To: <20210618090243.2517-2-kuqin12@gmail.com>

On 06/18/21 11:02, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430
> 
> This change includes specification update markdown file that describes
> the proposed PI Specification v1.7 Errata A in detail and potential
> impact to the existing codebase.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
> 
> Notes:
>     v2:
>     - Updated change impact analysis regarding SmmLockBoxDxeLib [Hao]
> 
>  BZ3430-SpecChange.md | 90 ++++++++++++++++++++
>  1 file changed, 90 insertions(+)

Placing such a document in the edk2 root directory looks very strange to me.

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process#tianocore-github

    [...] Specification text changes are held within the affected source
    repository, using the GitHub flavor of markdown, in a file (or split
    across several files) with .md suffix [...]

The wiki does not seem to specify what directory should contain the spec
change document.

Should we create a "CodeFirst" top-level directory?

Thanks,
Laszlo


  reply	other threads:[~2021-06-23 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  9:02 [PATCH v2 0/6] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER Kun Qin
2021-06-18  9:02 ` [PATCH v2 1/6] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update Kun Qin
2021-06-23 10:02   ` Laszlo Ersek [this message]
2021-06-24  0:28     ` [edk2-devel] " Kun Qin
2021-06-18  9:02 ` [PATCH v2 2/6] MdeModulePkg: PiSmmIpl: Update MessageLength calculation for MmCommunicate Kun Qin
2021-06-18  9:02 ` [PATCH v2 3/6] MdeModulePkg: MemoryProfileInfo: Updated MessageLength calculation Kun Qin
2021-06-23  1:33   ` [edk2-devel] " Wu, Hao A
2021-06-18  9:02 ` [PATCH v2 4/6] MdeModulePkg: SmiHandlerProfileInfo: " Kun Qin
2021-06-23  1:33   ` [edk2-devel] " Wu, Hao A
2021-06-18  9:02 ` [PATCH v2 5/6] MdeModulePkg: SmmLockBoxDxeLib: " Kun Qin
2021-06-23  1:33   ` Wu, Hao A
2021-06-18  9:02 ` [PATCH v2 6/6] MdePkg: MmCommunication: Extend MessageLength field size to UINT64 Kun Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82e2e6ef-2334-0b12-2b5d-27aa8fdac783@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox