From: "Heinrich Schuchardt" <xypron.glpk@gmx.de>
To: Daniel Schaefer <daniel.schaefer@hpe.com>, devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>,
Abner Chang <abner.chang@hpe.com>,
Gilbert Chen <gilbert.chen@hpe.com>,
Eric Jin <eric.jin@intel.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg
Date: Tue, 1 Dec 2020 18:37:34 +0100 [thread overview]
Message-ID: <82ec80ae-679e-ae37-6a13-8ef957789a7b@gmx.de> (raw)
In-Reply-To: <cdc211bf-afd8-7355-002d-c045e7e5f3fb@hpe.com>
On 12/1/20 6:11 PM, Daniel Schaefer wrote:
> On 12/2/20 12:59 AM, Heinrich Schuchardt wrote:
>> On 12/1/20 5:17 PM, Daniel Schaefer wrote:
>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>>>
>>> With this patch series we can build the UEFI SCT for RISCV64. It was
>>> confirmed
>>> to be working on the U-Boot UEFI implementation by Heinrich.
>>> It hasn't been tested on EDK2 yet.
>>>
>>> Build requirements are the same as for the EDK2 RISCV64 port and
>>> detailed here:
>>> https://github.com/riscv/riscv-uefi-edk2-docs
>>>
>>> The second patch is a big one because it adds architecture specific
>>> files by
>>> copying them from the Aarch64 directory. Only a single file, an
>>> assembly file
>>> needed modifications. I'm not sure why the other ones are in an
>>> architecture
>>> specific directory. They're all C files and seem to be generic. We
>>> can probably
>>> unify them.
>>
>> Hello Daniel,
>>
>> thanks a lot for your patches.
>>
>> You address the uefi-sct/SctPkg/TestCase/UEFI/EFI directory.
>>
>> Are you planning future patches for uefi-sct/SctPkg/TestCase/UEFI/IHV
>> too?
>
> I grepped the repo for strings related to arm64 and aarch64. I ported
> what I found.
> Do you see anything that's not ported?
uefi-sct/SctPkg/UEFI/IHV_SCT.dsc is the only IHV related file with
AARCH64 in it and that one is covered by your patch series.
>
> The only thing I see, is in
> Protocol/UsbIo/BlackBoxTest/UsbIoTestConformance.c
> where some code is not used for ARM because:
>
> // Note: This function uses the EDKII Glu library from EDKII
> compatibility pkg.
>
> // which is not ported to ARM yet. Hence for the time being just
> return success.
>
>
> I'm not yet sure what library that's referring to, but most likely it's
> also
> not implemented for RISC-V.
I assume this refers to:
https://github.com/tianocore/edk/tree/master/Foundation/Library/EdkIIGlueLib
The files of this library are in edk2/MdePkg/Library now.
>
> Thanks for testing!
> Does the SCT result look like what you expect? Or are some tests failing
> that you expect to succeed?
Not all tests have run yet. Running SCT on QEMU is really slow.
But from what I can see there is no difference to AARCH64 results on QEMU.
Best regards
Heinrich
next prev parent reply other threads:[~2020-12-01 17:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 16:17 [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg Daniel Schaefer
2020-12-01 16:17 ` [edk2-test PATCH v1 1/2] SctPkg: Add RISCV64 support Daniel Schaefer
2020-12-02 11:44 ` [edk2-devel] " Leif Lindholm
2021-02-08 15:09 ` Daniel Schaefer
2020-12-01 16:17 ` [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources Daniel Schaefer
2020-12-02 12:04 ` [edk2-devel] " Leif Lindholm
2021-02-08 15:09 ` Daniel Schaefer
2021-02-08 17:04 ` Heinrich Schuchardt
2021-02-09 12:42 ` Leif Lindholm
2021-02-09 13:47 ` Heinrich Schuchardt
2021-02-09 14:58 ` Leif Lindholm
2021-02-09 15:11 ` Daniel Schaefer
2020-12-01 16:59 ` [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg Heinrich Schuchardt
2020-12-01 17:11 ` Daniel Schaefer
2020-12-01 17:37 ` Heinrich Schuchardt [this message]
2021-02-08 14:30 ` Daniel Schaefer
2021-02-08 15:50 ` Heinrich Schuchardt
2020-12-02 12:07 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82ec80ae-679e-ae37-6a13-8ef957789a7b@gmx.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox