From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by mx.groups.io with SMTP id smtpd.web11.13876.1606844288182377046 for ; Tue, 01 Dec 2020 09:38:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=YFVS+C7A; spf=pass (domain: gmx.de, ip: 212.227.17.20, mailfrom: xypron.glpk@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606844258; bh=LMoclPkdNoUmHY90c7qLAEViApwrfo+IYrylJpM0YPI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=YFVS+C7A6XVBTcfAU+fBOXsGhI9uPQORcP5byYsHNcolcLLQwAuPNWJKs3FEs19+H alf6RT/KhcYbSvIfahqWk1hsLby2Ev6qil16RLTin16uGt55JKn/5SGmY+m+JokHJu u8bmiMeUqD1W3sC5W7W1jQbXO6ldxipxFR5AB914= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.63] ([62.143.246.89]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4hvb-1k0oCL0GAx-011mt0; Tue, 01 Dec 2020 18:37:38 +0100 Subject: Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg To: Daniel Schaefer , devel@edk2.groups.io Cc: Leif Lindholm , Abner Chang , Gilbert Chen , Eric Jin , G Edhaya Chandran , Barton Gao , Samer El-Haj-Mahmoud References: <20201201161752.23734-1-daniel.schaefer@hpe.com> From: "Heinrich Schuchardt" Message-ID: <82ec80ae-679e-ae37-6a13-8ef957789a7b@gmx.de> Date: Tue, 1 Dec 2020 18:37:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:dmnJebyR4RsYZ9zqCZIWT1T4Cg2fuksfY8JlNlnI/jJwUO/BV/o WeUFMTv8Kdm+4HXDYB03Utgt/40HtoEobdvXJG4xlYdbLYxIx+PuTUGzWqo1SNtWb96Hk/F dK05G+QI6zAcqT9S5dxAAEMC3V3ClhtV1epVLCrKXh6W6LDCNv6psUnp5h3DVk688KbBX1D vJzWCGluL3MGyVoSAPgEQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:faIMkVcWNjQ=:XxnTm1+EpgmBNzZDn5EuRx 5HScHw5BkjO/gimpVvIrxTo+sykDBMucAGTzS719wQ5P5DlBbSeoO6HL0jWu0JJ1BaN4l1XPM TbV28s9F9kT61PfbDXvpe6+YWfxqQbscBjk8dHTOps+/Udhj/TIp9RT1kK7tLtZkCuObFXMq/ bQDjJh/QDgYTq4t1mxu8YfgA0WaBf++y4mdGkNCJUybpPTRaBCU9xnkrGAou51hhZ3FEqqLyP g7vIuaHxQDea9uTY7AEd8WvwpnTBWGrTAuYGn51/ZQizll1Hk8A8RYWnp+g7e1WZMMN3qixO4 aafvNvq+7oP8hYJ11gte8DtS5lRvxqDaJXEdN+0+ft0AxA5IrkZvwhoBhi34SjcQEOZl5df7d qlyf0wCxYY5hLo9F/AA02Qr9r+4aBILytWkF2gkUYqLXPgQMyAIBo+1hPvSDk2jBMqRS9Rvjf Y31rXwrhxxscn8t1vIWG/RYdG7Wqp7Ro3lzgfcDfkhwu46Orrco7NCLPkKl4fg0/UMJ8JmRX9 I/swawhzs+x7WAMYBs8B3XJKeauuEKO00HN3nBK4xbBzaQsqItiro+a/4AKtljZ2IZbZ2a3JX P9mzOTdk9g39rz1LQk4rWDlwEVpmpqNkbXwcSVu1unLet+k2hHb7ir/YQr98oC+f0i9PUQs74 p+hTJZFeXYRlKmmTWXdq/faTdaEiq+ZAx+3ci3BOQ7J9h1CVA98ZZ/aXDoK6p9wIoPayWJdSq tCqo+03Ts8EXolGwBMcjJOOCu3yYAeKZVbX9SGyGdN/L576dWr9juwbWMuxM0t6vAqOZkBE8y sfm5XHhw+/B0LMuDSPDgWmSL+FLh8TeMV0g9zO02/11Lrujmc3SAjDNv5lARNXQfSemoXYIKg UghKgj7PdF+XV0a9rUBg== Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/1/20 6:11 PM, Daniel Schaefer wrote: > On 12/2/20 12:59 AM, Heinrich Schuchardt wrote: >> On 12/1/20 5:17 PM, Daniel Schaefer wrote: >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3042 >>> >>> With this patch series we can build the UEFI SCT for RISCV64. It was >>> confirmed >>> to be working on the U-Boot UEFI implementation by Heinrich. >>> It hasn't been tested on EDK2 yet. >>> >>> Build requirements are the same as for the EDK2 RISCV64 port and >>> detailed here: >>> https://github.com/riscv/riscv-uefi-edk2-docs >>> >>> The second patch is a big one because it adds architecture specific >>> files by >>> copying them from the Aarch64 directory. Only a single file, an >>> assembly file >>> needed modifications. I'm not sure why the other ones are in an >>> architecture >>> specific directory. They're all C files and seem to be generic. We >>> can probably >>> unify them. >> >> Hello Daniel, >> >> thanks a lot for your patches. >> >> You address the uefi-sct/SctPkg/TestCase/UEFI/EFI directory. >> >> Are you planning future patches for uefi-sct/SctPkg/TestCase/UEFI/IHV >> too? > > I grepped the repo for strings related to arm64 and aarch64. I ported > what I found. > Do you see anything that's not ported? uefi-sct/SctPkg/UEFI/IHV_SCT.dsc is the only IHV related file with AARCH64 in it and that one is covered by your patch series. > > The only thing I see, is in > Protocol/UsbIo/BlackBoxTest/UsbIoTestConformance.c > where some code is not used for ARM because: > > =C2=A0 // Note: This function uses the EDKII Glu library from EDKII > compatibility pkg. > > =C2=A0 // which is not ported to ARM yet. Hence for the time being just > return success. > > > I'm not yet sure what library that's referring to, but most likely it's > also > not implemented for RISC-V. I assume this refers to: https://github.com/tianocore/edk/tree/master/Foundation/Library/EdkIIGlueL= ib The files of this library are in edk2/MdePkg/Library now. > > Thanks for testing! > Does the SCT result look like what you expect? Or are some tests failing > that you expect to succeed? Not all tests have run yet. Running SCT on QEMU is really slow. But from what I can see there is no difference to AARCH64 results on QEMU. Best regards Heinrich