From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.13666.1583155088678801799 for ; Mon, 02 Mar 2020 05:18:08 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 05:18:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,507,1574150400"; d="scan'208";a="273717005" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 02 Mar 2020 05:18:07 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Mar 2020 05:18:06 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 2 Mar 2020 21:18:04 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 2 Mar 2020 21:18:04 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "daniel.schaefer@hpe.com" CC: Abner Chang , Gilbert Chen , Leif Lindholm , "Dong, Eric" , "Ni, Ray" , "Wu, Hao A" , "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: Restrict libraries using SMM to x86 Thread-Topic: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: Restrict libraries using SMM to x86 Thread-Index: AQHV8H4TbZAO/OGyOkqDhVLywYgOmKg1R45w Date: Mon, 2 Mar 2020 13:18:04 +0000 Message-ID: <82f59bf802c84a63a07afb30f9b7874d@intel.com> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> <20200302103238.25726-2-daniel.schaefer@hpe.com> In-Reply-To: <20200302103238.25726-2-daniel.schaefer@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Daniel: Those modules consumes LockBox for S3 boot path. If the different ARCH d= oesn't depend on LockBox for S3 boot, it can use LockBoxNullLib.inf library= instance. For EBC arch, LockBoxNullLib.inf has been specified. You can app= end more ARCHs with LockBoxNullLib library instance.=20 [LibraryClasses.EBC] LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Daniel Sc= haefer > Sent: Monday, March 2, 2020 6:33 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Gilbert Chen ; Leif Lindholm ; Dong, Eric > ; Ni, Ray ; Wu, Hao A ; Bi, Dandan ; Gao, > Liming > Subject: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: Restrict libraries us= ing SMM to x86 >=20 > The modules: >=20 > MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf > MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePe= rformanceDxe.inf >=20 > seem like they are independent of SMM but they actually do requires SMM'= s > LockBoxLib. Ideally they would be rewritten to not require SMM on non x8= 6. >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2549 >=20 > Signed-off-by: Daniel Schaefer > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Leif Lindholm > Cc: Eric Dong > Cc: Ray Ni > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > --- >=20 > Notes: > v2: > - Fix IA86 -> IA32 [Mike] >=20 > MdeModulePkg/MdeModulePkg.dsc | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.d= sc > index f7dbb27ce25d..5a20722a4270 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -109,6 +109,8 @@ [LibraryClasses.common.PEIM] > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf >=20 >=20 > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAl= locationLib.inf >=20 >=20 > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/Pei= ExtractGuidedSectionLib.inf >=20 >=20 > + >=20 >=20 > +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM] >=20 >=20 > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf >=20 >=20 >=20 >=20 >=20 > [LibraryClasses.common.DXE_CORE] >=20 >=20 > @@ -228,7 +230,6 @@ [Components] > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf >=20 >=20 > MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/IncompatiblePciD= eviceSupportDxe.inf >=20 >=20 > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf >=20 >=20 > - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf >=20 >=20 > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf >=20 >=20 > MdeModulePkg/Bus/Pci/SdMmcPciHcPei/SdMmcPciHcPei.inf >=20 >=20 > MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcBlockIoPei.inf >=20 >=20 > @@ -251,7 +252,6 @@ [Components] > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >=20 >=20 > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf >=20 >=20 > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf >=20 >=20 > - MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf >=20 >=20 > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf >=20 >=20 > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf >=20 >=20 > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf >=20 >=20 > @@ -395,7 +395,6 @@ [Components] > >=20 >=20 > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf >=20 >=20 > } >=20 >=20 > - MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwareP= erformanceDxe.inf >=20 >=20 > MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphics= ResourceTableDxe.inf >=20 >=20 > MdeModulePkg/Universal/SectionExtractionDxe/SectionExtractionDxe.inf = { >=20 >=20 > >=20 >=20 > @@ -447,6 +446,8 @@ [Components.IA32, Components.X64, Components.ARM, Co= mponents.AARCH64] > [Components.IA32, Components.X64] >=20 >=20 > MdeModulePkg/Universal/DebugSupportDxe/DebugSupportDxe.inf >=20 >=20 > MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.= inf >=20 >=20 > + MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf >=20 >=20 > + MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf >=20 >=20 > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf >=20 >=20 > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf >=20 >=20 > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { >=20 >=20 > @@ -478,6 +479,7 @@ [Components.IA32, Components.X64] > MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.= inf >=20 >=20 > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaArchCustomDecompress= Lib.inf >=20 >=20 > MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorD= xe.inf >=20 >=20 > + MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwareP= erformanceDxe.inf >=20 >=20 > MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf >=20 >=20 > MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.inf >=20 >=20 > MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwareP= erformanceSmm.inf >=20 >=20 > @@ -487,6 +489,7 @@ [Components.IA32, Components.X64] > MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBuff= erDxe.inf >=20 >=20 > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >=20 >=20 >=20 >=20 >=20 > + >=20 >=20 > [Components.X64] >=20 >=20 > MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf >=20 >=20 >=20 >=20 >=20 > -- > 2.25.0 >=20 >=20 >=20