From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.65; helo=mail-wm1-f65.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B99F8201B0405 for ; Tue, 12 Feb 2019 09:16:12 -0800 (PST) Received: by mail-wm1-f65.google.com with SMTP id r17so3803211wmh.5 for ; Tue, 12 Feb 2019 09:16:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qQtuj0Gm3qNeSt2+Rt4GJ2yY7K3vtArsKZTzueFq0jw=; b=snsfLh82McXtUmcl4HNdwfR6VWraPva2PwLYxwJ4C1te1r0U4OS5mof7HWeHeDXP7z 5T6y60DiokANN2sY3/JpsQYTPvw3VxPVLjvq25u2tW6jbCHp1kOeVPvNK/14CyPom2Bd Xo7AnXaKlodC752AHHO2SoO1C5fWweTLEk+BHN1BAzko15uJ2NF5iA/cnQocph8fhoSc pQIPE6Hn48zeb9XbloR7vdqMeJZrzZVv6P/e4DOL+5w9u7JyHAUwuWe9eVxkmyis8Af+ prTBeT9jt8WhD9akuhPOAmK6x8M0whNWHx33AUQg8OFXCwe38s0i3Dfib0rM+iSvDzC1 wMhA== X-Gm-Message-State: AHQUAuZP6tg+GkKdY2G96SDH0L8ODjiXBBXByt4wE9CdJN/1d8J2Z1ns nBL+4ITHDiplbYPYlaQUhRqmk3/iRpw= X-Google-Smtp-Source: AHgI3IZ5YHxM1TvzJIMzTxV7XVN4PtJ+PNiggVtWNJBe+gNWwBpTJ7plseYDlEiV3NQGoRBkzCm1PA== X-Received: by 2002:a7b:cb82:: with SMTP id m2mr4012651wmi.135.1549991771059; Tue, 12 Feb 2019 09:16:11 -0800 (PST) Received: from [192.168.1.103] (10.red-83-35-153.dynamicip.rima-tde.net. [83.35.153.10]) by smtp.gmail.com with ESMTPSA id x21sm3108284wmi.28.2019.02.12.09.16.09 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 09:16:10 -0800 (PST) To: Laszlo Ersek , "Gao, Liming" , "Feng, Bob C" , "Bi, Dandan" Cc: "edk2-devel@lists.01.org" References: <20190203055515.18336-1-bob.c.feng@intel.com> <31516193-5bd7-8c97-9a18-03e569f57d94@redhat.com> <64947d2b-9a8a-f7ff-5221-e40416f39531@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3DBC84@SHSMSX104.ccr.corp.intel.com> <46f28c37-826a-f0b2-38f5-b04cfe45e389@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <82faa156-d26f-ba9a-9769-3788c63a92d1@redhat.com> Date: Tue, 12 Feb 2019 18:16:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <46f28c37-826a-f0b2-38f5-b04cfe45e389@redhat.com> Subject: Re: [Patch 0/3] BaseTools: Implement splitquoted function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 17:16:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/19 3:02 PM, Laszlo Ersek wrote: > On 02/12/19 14:33, Gao, Liming wrote: >> Laszlo: >> To install python3-distutils should resolve this issue. I expect BaseTools build functionality doesn't depend on the third party python lib. > > I completely agree with your expectation, regarding *3rd party* python > packages. We shouldn't expect developers to install packages from > repositories that fall outside of their normal distro repos. > > However, my understanding was that python3-distutils should be available > as a normal (not 3rd party) component on Ubuntu 18. I think we can > expect developers to install additional packages if those packages are > readily available in their normal (distro-provided) repos. The documentation is not precise about the python package to install, it simply states "Install Python 2.7.10": https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with-EDK-II -- Except python, there is a precise list of packages to install for this distro: "sudo apt-get install build-essential uuid-dev iasl git gcc-5 nasm", per: https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC#Install_required_software_from_apt Maybe we simply need to update the doc to ask python3 and add python3-distutils in the list? > >> So, I suggest to check whether python3-distutils is the native python library. If it is native python library, why Ubuntu18 doesn't include it. I will work with Dandan to collect more information. > > Right, that's exactly what I'm asking for. Thank you very much! > Laszlo > >>> -----Original Message----- >>> From: Laszlo Ersek [mailto:lersek@redhat.com] >>> Sent: Tuesday, February 12, 2019 8:24 PM >>> To: Feng, Bob C ; Bi, Dandan >>> Cc: edk2-devel@lists.01.org; Gao, Liming >>> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function >>> >>> On 02/04/19 20:12, Laszlo Ersek wrote: >>>> On 02/03/19 06:55, Feng, Bob C wrote: >>>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >>>>> On some Linux environment, there may be no distutils.util >>>>> library for python3 that will cause build tool crash. >>>>> This patch implement distutils.util.split_quoted >>>>> in BaseTools so that the Basetools will be independent with >>>>> distutils.util library. >>>>> >>>>> Feng, Bob C (3): >>>>> BaseTools: Implement splitquoted function in Build tool >>>>> BaseTools: Implement splitquoted function in UPT >>>>> BaseTools: unit test for splitquoted function >>>>> >>>>> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 ++++++++++++++++++++++++++++++++++++++++++++++---- >>>>> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 ++++++++++++++++++++++++++++++++++++++++++++--- >>>>> BaseTools/Tests/TestStringSplit.py | 38 ++++++++++++++++++++++++++++++++++++++ >>>>> 3 files changed, 128 insertions(+), 7 deletions(-) >>>>> create mode 100644 BaseTools/Tests/TestStringSplit.py >>>>> >>>> >>>> Is this really necessary? BZ#1509 references Ubuntu18; however it looks >>>> like the issue can be resolved by a simple package installation on >>>> Ubuntu 18: >>>> >>>> https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux >>>> >>>> """ >>>> sudo apt-get install python3-distutils >>>> """ >>>> >>>> I'm not a Ubuntu user myself; so all I can do here (without installing a >>>> Ubuntu18 VM) is check the Ubuntu package directory: >>>> >>>> https://packages.ubuntu.com/search?keywords=python3-distutils&searchon=names&suite=all§ion=all >>>> >>>> python3-distutils appears available for both "bionic (18.04LTS)" and >>>> "cosmic (18.10)". >>>> >>>> Dandan, if you install python3-distutils, does that solve the issue for you? >>> >>> I'd still like to get an answer to my question, before the series is pushed. >>> >>> Thanks, >>> Laszlo > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >