Re: [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

["Pete Batard" <pete@akeo.ie>]

On 2020.04.19 14:33, Ard Biesheuvel wrote:
> On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote:
>> Fix an ASSERT with the TFTP dynamic Shell command on the
>> RPi3 and RPi4 when running DEBUG builds. Also, enable the
>> command by default for all builds.
>>
> 
> Fixing the ASSERT is fine but I am reluctant to enable this by default.

I'm going to second this.

To answer a question Samer was asking elsewhere, this is actually part 
of the reason why TFTP is not enabled in the DEBUG builds we produce at 
https://github.com/pftf/RPi4 (See build_firmware.sh), the reasoning 
being that if someone encounters an issue with RELEASE and we ask them 
to troubleshoot with the DEBUG artifact, we want to eliminate potential 
troublemakers when they try that.

> It is a non-standard hack that ARM contributed in the past, and is not 
> covered by the EFI of Shell specifications. If RPi4 is intended to be a 
> showcase for UEFI on ARM done right, we should not enable this at all.

Here I have to point out that RPi4 becoming a showcase because we intend 
to is not what we are pursuing (because if it was a matter of "willing" 
a showcase into existence, we would have picked a platform with a lot 
less quirks, more comprehensive documentation, and so on).

Instead, we estimate that due to its price point and widespread 
availability, it *is* going to become a de facto showcase, whether 
everybody likes it or not. And that is the reason we want to treat is as 
a showcase where possible.

Regards,

/Pete