From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.17115.1587305990179443412 for ; Sun, 19 Apr 2020 07:19:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=jkFWeTZF; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.65, mailfrom: pete@akeo.ie) Received: by mail-wr1-f65.google.com with SMTP id j1so3336886wrt.1 for ; Sun, 19 Apr 2020 07:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yyjBjHIvuqwDWerf4HXWH4Yw+790xBymLwCUVCAF10k=; b=jkFWeTZF40fjP/8ly70b66Qw/Nt+U1uBg9Okg+00C/5qdDEHREN3a/9RM32R7KNK+C IrDdN5LUJcnuzEfnnswI290scVgKpQSnJktngEJVXrAcBjSXu2RHDVioT/AGkJGajKWX N/6FasCUhwDa4CMV2Bcy1PuBhYAfNX/866r8azHg+7WhK2prh0RhCSEf07OKs58tadqX Tb2OChfbav+Xun81MuF4Xu3d3KXP/t/q57WuKja9QyvxphcqPYtEwgIpk7tt+8t6E6/p JgYlttBMuKPeLyxB0+jwWNDmRXhZ7gHtdEL8jvdcoI5Dj0q8+Qm7kwZjXMSUNokHS0Re pJgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yyjBjHIvuqwDWerf4HXWH4Yw+790xBymLwCUVCAF10k=; b=mAH3gTZuWqG4N1nVemQ53dxhX+2MWeitCQQnGgJFc+5d4aTCfp6J61mFBBdFoUA7M+ 6U2ELXivQ2vw9d9lD6BrNui+xqkCzFSXY52pIVeg+cZzpiOFpZsDqCL3qP9wqW+cQoGk 58y11eLjI3HNnRrJGGjbSTmgWL/HGQgxPEZQO/rtpexZGrrqrqF1TFVJ63r0k/5q7X1z RLTIgInptMGKfMGRFN3ZbZPL63GKoKgzIziKZ/3n2auStah58AeGKTvWBdP+Ov/XlhEQ IWHQjJ1oVIsEYf5YCXQq2fueUBMWUpvCJaDPW+qJXcb1XbfrEjOphPubDWg1y2Ixuldm U5pg== X-Gm-Message-State: AGi0PuZCzQlWyFjaZSH4TPjRYR+IWbokAVH1jzNg1VSBwNozqEj32Uam 02q2g539dH1gHEWJKZqvNMyDVA== X-Google-Smtp-Source: APiQypI7tQ10jV+sk6aUwwhckfAMHX9FtgkJ8OOuN0noAkyrw5IZ7QGiHdQdSnESNCteKCPI2KwHng== X-Received: by 2002:a05:6000:10c2:: with SMTP id b2mr14829061wrx.118.1587305988777; Sun, 19 Apr 2020 07:19:48 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.47.66]) by smtp.googlemail.com with ESMTPSA id f2sm40083683wro.59.2020.04.19.07.19.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 07:19:48 -0700 (PDT) Subject: Re: [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command To: Ard Biesheuvel , Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Andrei Warkentin References: <20200419130417.3298-1-samer@elhajmahmoud.com> <8d59e616-9910-4935-2e1f-5da75fc1d34a@arm.com> From: "Pete Batard" Message-ID: <831705c6-0915-ba1a-adc0-3078b2af1a43@akeo.ie> Date: Sun, 19 Apr 2020 15:19:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <8d59e616-9910-4935-2e1f-5da75fc1d34a@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.04.19 14:33, Ard Biesheuvel wrote: > On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote: >> Fix an ASSERT with the TFTP dynamic Shell command on the >> RPi3 and RPi4 when running DEBUG builds. Also, enable the >> command by default for all builds. >> > > Fixing the ASSERT is fine but I am reluctant to enable this by default. I'm going to second this. To answer a question Samer was asking elsewhere, this is actually part of the reason why TFTP is not enabled in the DEBUG builds we produce at https://github.com/pftf/RPi4 (See build_firmware.sh), the reasoning being that if someone encounters an issue with RELEASE and we ask them to troubleshoot with the DEBUG artifact, we want to eliminate potential troublemakers when they try that. > It is a non-standard hack that ARM contributed in the past, and is not > covered by the EFI of Shell specifications. If RPi4 is intended to be a > showcase for UEFI on ARM done right, we should not enable this at all. Here I have to point out that RPi4 becoming a showcase because we intend to is not what we are pursuing (because if it was a matter of "willing" a showcase into existence, we would have picked a platform with a lot less quirks, more comprehensive documentation, and so on). Instead, we estimate that due to its price point and widespread availability, it *is* going to become a de facto showcase, whether everybody likes it or not. And that is the reason we want to treat is as a showcase where possible. Regards, /Pete