From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Dann Frazier <dannf@ubuntu.com>,
"Dong, Eric" <eric.dong@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()
Date: Fri, 24 Nov 2017 01:01:21 +0100 [thread overview]
Message-ID: <831b3082-2554-8196-5f79-d018e6d4ce37@redhat.com> (raw)
In-Reply-To: <ee082c20-df22-d955-2a69-499845a4f2ea@redhat.com>
On 23/11/2017 14:08, Laszlo Ersek wrote:
> On 11/23/17 03:20, Ni, Ruiyu wrote:
>> I cannot explain precisely why the S4 resume fails.
>> I can just guess: Windows might have some assumptions on the BM bit.
> Can we make this configurable on the platform level somehow?
>
> On one hand, I certainly don't want to break Windows 10, even in case
> this issue ultimately turns out to be a Windows 10 bug.
>
> On the other hand, OVMF does not support S4, and disabling BMDMA at
> ExitBootServices() in PCI drivers is specifically what the Driver
> Writers' Guide recommends. Otherwise pending DMA could corrupt OS memory.
S4 can be done by the OS even if firmware says it doesn't support it.
Once hibernation is done, it is merely a "courtesy" for the OSPM to turn
off the computer using the _S4 ACPI object rather than _S5.
Paolo
next prev parent reply other threads:[~2017-11-23 23:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 15:48 [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices() Laszlo Ersek
2017-10-26 19:56 ` dann frazier
2017-10-27 3:23 ` Zeng, Star
2017-10-27 12:25 ` Laszlo Ersek
2017-10-27 14:57 ` Aleksei
2017-10-27 16:09 ` Laszlo Ersek
2017-11-22 10:05 ` Ni, Ruiyu
2017-11-22 10:26 ` Zeng, Star
2017-11-23 2:20 ` Ni, Ruiyu
2017-11-23 13:08 ` Laszlo Ersek
2017-11-23 14:58 ` Ni, Ruiyu
2017-11-23 17:19 ` Laszlo Ersek
2017-11-23 23:06 ` Ni, Ruiyu
2017-11-24 0:01 ` Paolo Bonzini [this message]
2017-11-24 1:04 ` Ni, Ruiyu
2017-11-24 1:40 ` Yao, Jiewen
2017-11-27 12:29 ` Laszlo Ersek
2017-11-27 12:58 ` Zeng, Star
2017-11-27 13:41 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831b3082-2554-8196-5f79-d018e6d4ce37@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox