Re: [edk2-devel] [edk2-platforms][PATCH 3/3] Platform/RPi: Report core clock frequency during early init

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 5/4/20 1:15 PM, Pete Batard wrote:
> The previous commit ensures that gSerialLibCoreClockFreq contains the VPU
> core frequency by the time we execute ArmPlatformGetVirtualMemoryMap ().
> 
> This value can prove useful for troubleshooting, so report it.
> 
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
>   Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c
> index aae189ec8136..015d3dccc27c 100644
> --- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c
> +++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c
> @@ -22,7 +22,12 @@ extern UINT64 mSystemMemoryEnd;
>   UINT64 mVideoCoreBase;
>   UINT64 mVideoCoreSize;
>   UINT32 mBoardRevision;
> -
> +//
> +// gSerialLibCoreClockFreq, which resides in DualSerialLib is set
> +// to the VPU Core Clock frequency by ArmPlatformPeiBootAction ().
> +// We use it to report the core frequency during early boot.
> +//
> +extern UINT32 gSerialLibCoreClockFreq;
>   
>   // The total number of descriptors, including the final "end-of-table" descriptor.
>   #define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 11
> @@ -66,6 +71,7 @@ ArmPlatformGetVirtualMemoryMap (
>     DEBUG ((DEBUG_INFO, "Board Rev: 0x%lX\n", mBoardRevision));
>     DEBUG ((DEBUG_INFO, "Base RAM : 0x%ll08X (Size 0x%ll08X)\n", mSystemMemoryBase, mSystemMemoryEnd + 1));
>     DEBUG ((DEBUG_INFO, "VideoCore: 0x%ll08X (Size 0x%ll08X)\n", mVideoCoreBase, mVideoCoreSize));
> +  DEBUG ((DEBUG_INFO, "Core Freq: %d MHz\n", gSerialLibCoreClockFreq / 1000000));
>   
>     ASSERT (mSystemMemoryBase == 0);
>     ASSERT (VirtualMemoryMap != NULL);
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>