From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.8629.1624631794936509502 for ; Fri, 25 Jun 2021 07:36:35 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.43, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: 5hb+vKHt51uJKL5QhTJUANqQSv/8XO48ersoYy17MLDn+K1OaWQC5nSGLPJPagDQh00ra0CMar bvZksLVuilfA== X-IronPort-AV: E=McAfee;i="6200,9189,10026"; a="293313870" X-IronPort-AV: E=Sophos;i="5.83,299,1616482800"; d="scan'208";a="293313870" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2021 07:36:32 -0700 IronPort-SDR: GeTmYeKj7K5Zif16bXgmpp2PeGw9C1sM5UzVwarNpU0vdzcdMMECSGP1e1FuWai3IsshrDVZJj 1lALM00k3p7A== X-IronPort-AV: E=Sophos;i="5.83,299,1616482800"; d="scan'208";a="453832284" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.214.221.115]) ([10.214.221.115]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2021 07:36:30 -0700 Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg:UEFIPXEBC To: devel@edk2.groups.io, emergingsiva@gmail.com Cc: Sivaraman References: <1b052eda1c038b2d9e3502c679e0014db143a39b.1624516592.git.sivaramann@ami.com> From: "Maciej Rabeda" Message-ID: <83446051-e9de-5dcf-bcd8-23b486ef8dc0@linux.intel.com> Date: Fri, 25 Jun 2021 16:35:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1b052eda1c038b2d9e3502c679e0014db143a39b.1624516592.git.sivaramann@ami.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: pl Hi Siva, I am fine with the patch per se, but I still have problems applying it. Have you tried following my suggestions from our meeting? Thanks, Maciej On 24-Jun-21 09:33, INDIA\sivaramann wrote: > Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver. > In this function any non allowed events are recieved as input it > will exit in beginning itself. But the switch case handling the > default and Dhcp4SendRequest which is not reachable. > > Signed-off-by: Sivaraman > --- > NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c > index fb63cf61a9..e85176f9bb 100644 > --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c > +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c > @@ -1256,19 +1256,10 @@ PxeBcDhcp4CallBack ( > > > // > > // Cache the DHCPv4 discover packet to mode data directly. > > - // It need to check SendGuid as well as Dhcp4SendRequest. > > + // It need to check SendGuid. > > // > > CopyMem (&Mode->DhcpDiscover.Dhcpv4, &Packet->Dhcp4, Packet->Length); > > > > - case Dhcp4SendRequest: > > - if (Packet->Length > PXEBC_DHCP4_PACKET_MAX_SIZE) { > > - // > > - // If the to be sent packet exceeds the maximum length, abort the DHCP process. > > - // > > - Status = EFI_ABORTED; > > - break; > > - } > > - > > if (Mode->SendGUID) { > > // > > // Send the system Guid instead of the MAC address as the hardware address if required. > > @@ -1332,6 +1323,7 @@ PxeBcDhcp4CallBack ( > break; > > > > default: > > + ASSERT (FALSE); > > break; > > } > > >