public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com
Cc: Chasel Chiu <chasel.chiu@intel.com>,
	Ankit Sinha <ankit.sinha@intel.com>,
	Michael Kubacki <michael.kubacki@microsoft.com>,
	Sai Chaganty <rangasai.v.chaganty@intel.com>,
	Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>,
	Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1 3/4] CometlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT
Date: Mon, 6 Jun 2022 18:58:00 -0400	[thread overview]
Message-ID: <834743c2-343f-9e16-6c2f-ff4161004a1f@linux.microsoft.com> (raw)
In-Reply-To: <20220606225030.3403-4-nathaniel.l.desimone@intel.com>

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/6/2022 6:50 PM, Nate DeSimone wrote:
> Set the location of the DUTY_CYCLE field in the P_CNT register
> and indicate the width of the clock duty cycle to OS power management
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>   .../CometlakeURvp/OpenBoardPkgPcd.dsc                    | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd.dsc
> index 589b002d06..68dd08423b 100644
> --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd.dsc
> +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd.dsc
> @@ -1,7 +1,7 @@
>   ## @file
>   #  PCD configuration build description file for the CometlakeURvp board.
>   #
> -# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.<BR>
>   #
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -253,6 +253,13 @@
>     gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuCoreCount|8
>     gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuThreadCount|2
>   
> +  #
> +  # Set the location of the DUTY_CYCLE field in the P_CNT register
> +  # and indicate the width of the clock duty cycle to OS power management
> +  #
> +  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset|0x1
> +  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth|0x3
> +
>     #
>     # The PCDs are used to control the Windows SMM Security Mitigations Table - Protection Flags
>     #

  reply	other threads:[~2022-06-06 22:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 22:50 [edk2-platforms] [PATCH V1 0/4] Enable CPU pwr mgmt in FADT for Intel client boards Nate DeSimone
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT Nate DeSimone
2022-06-06 22:56   ` [edk2-devel] " Michael Kubacki
2022-06-06 23:17     ` Nate DeSimone
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 2/4] WhiskeylakeOpenBoardPkg: " Nate DeSimone
2022-06-06 22:56   ` [edk2-devel] " Michael Kubacki
2022-06-06 23:12   ` Sinha, Ankit
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 3/4] CometlakeOpenBoardPkg: " Nate DeSimone
2022-06-06 22:58   ` Michael Kubacki [this message]
2022-06-06 23:13   ` Sinha, Ankit
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: " Nate DeSimone
2022-06-06 22:59   ` [edk2-devel] " Michael Kubacki
2022-06-06 23:14   ` Sinha, Ankit
2022-06-07  1:07   ` Heng Luo
2022-06-08 22:00     ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834743c2-343f-9e16-6c2f-ff4161004a1f@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox