From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.5005.1622110672658251496 for ; Thu, 27 May 2021 03:17:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WsRT2ydS; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622110671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xsGRMDYJ56S1CHEKSoLenDkW5cXQuczDpTS+xxosZPg=; b=WsRT2ydSOo39OTr/HxEsNqQc5nLxTx9dZ2XDRzQhgPP+j1361nAgRlHNy9IquArZhPZiwt w9OjTlZbdfpyC0IAkmoCxhNVF2K09v8qwtFJ5eW5dGO/pRWXYWjXsNYICfCz4THfb1Rz5V azcunK3Shgsf+zzwfoIh/Yb1vUYEM1I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-1vnogxTsMiKKzn2mdV1RQg-1; Thu, 27 May 2021 06:17:50 -0400 X-MC-Unique: 1vnogxTsMiKKzn2mdV1RQg-1 Received: by mail-wm1-f72.google.com with SMTP id y129-20020a1c32870000b029016920cc7087so1767057wmy.4 for ; Thu, 27 May 2021 03:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xsGRMDYJ56S1CHEKSoLenDkW5cXQuczDpTS+xxosZPg=; b=RkGlgzRDHDvT+NWZW0/e3SuvmHxiXlesIFMI0WY/AAidP2A610Lu/9Bz/a+KMpDl1N qQHyWK0E/GqqNc1/Ow0snTc45cqevWWldQ8TPhzo1AqWKwkzz6+oyHsdydiRf/wnX/uR sfybuB1U/Hdp09q5Pn/kGmVBXt4bMWJcKrTBQbawyl2kYsyZtjwd26EkGe1/JwNF+Ul0 89td2VpP5Cgr2+jEZm8pGo0lfqWQ9WqO3Lwq8TiY+mQ6DrtjMTKyT06AVDftQlFnIfYs qfULEkhmjVfED2x+j6lKSZAma0/owZd/panDE2mqucfUUeu3ZsECdyzPOqjMw33o/Sbd zblA== X-Gm-Message-State: AOAM5306wbMvMpCcvhn1j/rSalDA9VBbtvd7uFl0LdyRmt+m6fx0dK2B 3FH3HgpwhdU3WPEnPxWc/wC8k3OiYJNJ/WP8Ryg+MC/yfVDU7wN6blWMgkva9gZZWWHfP2y14lC klIoWNQzMUZ73wg== X-Received: by 2002:a5d:6b09:: with SMTP id v9mr2501809wrw.297.1622110668884; Thu, 27 May 2021 03:17:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqvu2En4WPHtbA7J4CJ6g3Kvqc6ymCWzjGVCds/U5OiN9FXCdPJaz7W5MqlJzszFacjEuJVw== X-Received: by 2002:a5d:6b09:: with SMTP id v9mr2501790wrw.297.1622110668756; Thu, 27 May 2021 03:17:48 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id l8sm2341785wrw.71.2021.05.27.03.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 03:17:48 -0700 (PDT) Subject: Re: [PATCH 12/43] OvmfPkg/AcpiPlatformDxe: remove the "AcpiPlatformDxe.inf" driver To: Laszlo Ersek , devel@edk2.groups.io Cc: Andrew Fish , Ard Biesheuvel , Jordan Justen , Leif Lindholm , Michael D Kinney References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-13-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <834d9886-019a-1df1-f6b9-6756370d18db@redhat.com> Date: Thu, 27 May 2021 12:17:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-13-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The "OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf" module is no longer > referenced in any platform DSC file; remove it. > > That orphans the "AcpiPlatform.c", "Qemu.c" and "Xen.c" files in the > "OvmfPkg/AcpiPlatformDxe/" directory; remove them. > > That in turn removes the only definitions of the InstallAcpiTable(), > QemuDetected(), QemuInstallAcpiTable(), InstallXenTables() functions in > the "OvmfPkg/AcpiPlatformDxe/" directory, so remove their declarations > from "AcpiPlatform.h". > > Remove "OvmfPkg/AcpiPlatformDxe/Xen.c" from the "OvmfPkg: Xen-related > modules" section of "Maintainers.txt", as well. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 69 --- > Maintainers.txt | 1 - > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 29 -- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 267 ---------- > OvmfPkg/AcpiPlatformDxe/Qemu.c | 512 -------------------- > OvmfPkg/AcpiPlatformDxe/Xen.c | 315 ------------ > 6 files changed, 1193 deletions(-) Reviewed-by: Philippe Mathieu-Daude