From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 11F6D941C0C for ; Fri, 17 May 2024 22:31:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=L/wFDpwSa+1T7bFcNsbvVAiJkQNI19OVRviRQvD4FeE=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715985090; v=1; b=GoT5p1zK0qNNICBwqU4unBS3czyP7wwZ6NDNqfwqg+oE4Y8T2exOf9W5d+yeYYlamOBIJIxi MasvVnpAWEl+qg0/1kgOKs3E1d7XpaU3frxtUOydPwPZGopcIu/84vGSt18SFq8yOnzGk8AoqH+ npLbiXFRVnxJlGYOSkZ4iqpWKivuU6/yEVA5FQ07Ik3JUOealuYDIjuQGhPPOE9evf8EDtdA8cf u4KhKDwP9C7qouhYCuNZUdxKdkXnVqcUSUjpmZ2esLVBsGQytFtNFqbjj70SqXGIfgTxSks2v1T jub3k3zgZIoRAS5eD76qvjUyZ4mUG9SttsTKbQrjXoKBg== X-Received: by 127.0.0.2 with SMTP id ak8LYY7687511xMgdOzOhw8G; Fri, 17 May 2024 15:31:30 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.8252.1715985089654483537 for ; Fri, 17 May 2024 15:31:29 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.9]) by linux.microsoft.com (Postfix) with ESMTPSA id 6408C2037CFF; Fri, 17 May 2024 15:31:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6408C2037CFF Message-ID: <8354dafc-6c4c-4981-9561-bd46f5b6b14d@linux.microsoft.com> Date: Fri, 17 May 2024 18:31:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Feng, Bob C" , Joey Vagedes , Liming Gao , Rebecca Cran , Sean Brogan , "Chen, Christine" References: <20240517210902.1510-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 17 May 2024 15:31:29 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lGIlgpxHMiCCqIum5G5aGvCqx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=GoT5p1zK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Mike. Are you okay with me completing the PR now? On 5/17/2024 5:31 PM, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney >=20 >> -----Original Message----- >> From: mikuback@linux.microsoft.com >> Sent: Friday, May 17, 2024 2:09 PM >> To: devel@edk2.groups.io >> Cc: Feng, Bob C ; Joey Vagedes >> ; Liming Gao ; Kinney, >> Michael D ; Rebecca Cran = ; >> Sean Brogan ; Chen, Christine >> >> Subject: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 >> >> From: Michael Kubacki >> >> This fixes an issue where the CodeQL queries currently fetched in the >> pipeline are incompatible with the current executable used. >> >> Update to pick up functional and security fixes. See the following >> comparison for detailed differences: >> >> https://github.com/github/codeql-cli-binaries/compare/v2.16.1...v2.17.3 >> >> Cc: Bob Feng >> Cc: Joey Vagedes >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Rebecca Cran >> Cc: Sean Brogan >> Cc: Yuwei Chen >> Signed-off-by: Michael Kubacki >> --- >> >> Notes: >> This change fixes an immediate compatibility issue between >> the latest queries being pulled and the CodeQL CLI being >> used. >> >> A follow up change will attempt to lock queries against a >> compatibile version to prevent queries from pulling ahead >> to incompatible versions in the future. >> >> --- >> >> This change was tested in edk2 CI: >> >> https://github.com/tianocore/edk2/pull/5667 >> >> BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml | 6 +++--- >> BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml | 6 +++--- >> BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 +++--- >> 3 files changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >> index 5ec56c6bf06f..dbc9c2ba0290 100644 >> --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >> @@ -16,9 +16,9 @@ >> "scope": "codeql-ext-dep", >> "type": "web", >> "name": "codeql_cli", >> - "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.16.1/codeql.zip", >> - "version": "2.16.1", >> - "sha256": >> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6", >> + "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.17.3/codeql.zip", >> + "version": "2.17.3", >> + "sha256": >> "e5ac1d87ab38e405c9af5db234a338b10dffabc98a648903f1664dd2a566dfd5", >> "compression_type": "zip", >> "internal_path": "/codeql/", >> "flags": ["set_shell_var", ], >> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >> b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >> index 5b4a919f1de4..536322f2b331 100644 >> --- a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >> @@ -14,9 +14,9 @@ >> "scope": "codeql-linux-ext-dep", >> "type": "web", >> "name": "codeql_linux_cli", >> - "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.16.1/codeql-linux64.zip", >> - "version": "2.16.1", >> - "sha256": >> "40dbb6c0c4064bd14601a02e60c61661fdc0271469f90eb91a2e7d51d4cbc171", >> + "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.17.3/codeql-linux64.zip", >> + "version": "2.17.3", >> + "sha256": >> "9fba000c4b821534d354bc16821aa066fdb1304446226ea449870e64a8ad3c7a", >> "compression_type": "zip", >> "internal_path": "/codeql/", >> "flags": ["set_shell_var", ], >> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >> b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >> index c0c018c9538f..93a81ffd5020 100644 >> --- a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >> @@ -14,9 +14,9 @@ >> "scope": "codeql-windows-ext-dep", >> "type": "web", >> "name": "codeql_windows_cli", >> - "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.16.1/codeql-win64.zip", >> - "version": "2.16.1", >> - "sha256": >> "9ebe5ea8a7d0a77425428d50d49912319117fccee24ecb62f6219c12584f4f28", >> + "source": "https://github.com/github/codeql-cli- >> binaries/releases/download/v2.17.3/codeql-win64.zip", >> + "version": "2.17.3", >> + "sha256": >> "4c6fbf2ea2eaf0f47bf0347eacf54c6b9d6bdf7acb6b63e17f9e6f2dd83b34e7", >> "compression_type": "zip", >> "internal_path": "/codeql/", >> "flags": ["set_shell_var", ], >> -- >> 2.45.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119061): https://edk2.groups.io/g/devel/message/119061 Mute This Topic: https://groups.io/mt/106161774/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-