Re: F29 Build Issue.

[Laszlo Ersek <lersek@redhat.com>]

On 03/13/19 14:27, Andrew J. Hutton wrote:
> Unsure if this is a missing build dependency (since there doesn't appear
> to be a check for this) am I missing a make dep or configure step
> somewhere?
> 
> This is stock F29, following the website instructions; the make -C
> BaseTools/Source/C results in the following errror:
> 
> make[1]: Entering directory
> '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf'
> cc  -c -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror
> -Wno-deprecated-declarations -nostdlib -c -g  -I .. -I ../Include/Common
> -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I .
> -I ../Include/X64/  GenVtf.c -o GenVtf.o
> GenVtf.c: In function ‘CreateFitTableAndInitialize’:
> GenVtf.c:1473:3: error: ‘strncpy’ output truncated before terminating
> nul copying 8 bytes from a string of the same length
> [-Werror=stringop-truncation]
>    strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8);  //
> "_FIT_ "
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[1]: *** [../Makefiles/footer.makefile:27: GenVtf.o] Error 1
> make[1]: Leaving directory
> '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf'
> make: *** [GNUmakefile:73: GenVtf] Error 2
> make: Leaving directory '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C'

The edk2 codebase that you are consuming is too old. The above symptom
should not be present since commit 1d212a83df0e
("BaseTools/header.makefile: add "-Wno-stringop-truncation"", 2018-03-05).

The command line you quoted also misses "-Wno-unused-result", so I think
you must be missing commit 202726b3ceb3 ("BaseTools Makefile: Enable O2
option for GCC tool chain", 2016-10-08) as well.

I assume clover still uses an edk2 checkout that's 2.5+ years old at
this point.

Thanks,
Laszlo