From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DF0272194EB75 for ; Thu, 14 Mar 2019 02:34:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A471D368FF; Thu, 14 Mar 2019 09:34:25 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-35.rdu2.redhat.com [10.10.120.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 119C66B8F2; Thu, 14 Mar 2019 09:34:24 +0000 (UTC) To: "Andrew J. Hutton" , edk2-devel@lists.01.org References: <47e72b0d-2257-3149-0741-0a06f3ffde18@gmail.com> From: Laszlo Ersek Message-ID: <83767b8d-3e1c-f803-e3b2-7481655d2c4d@redhat.com> Date: Thu, 14 Mar 2019 10:34:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <47e72b0d-2257-3149-0741-0a06f3ffde18@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 14 Mar 2019 09:34:25 +0000 (UTC) Subject: Re: F29 Build Issue. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 09:34:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/13/19 14:27, Andrew J. Hutton wrote: > Unsure if this is a missing build dependency (since there doesn't appear > to be a check for this) am I missing a make dep or configure step > somewhere? > > This is stock F29, following the website instructions; the make -C > BaseTools/Source/C results in the following errror: > > make[1]: Entering directory > '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf' > cc  -c -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror > -Wno-deprecated-declarations -nostdlib -c -g  -I .. -I ../Include/Common > -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . > -I ../Include/X64/  GenVtf.c -o GenVtf.o > GenVtf.c: In function ‘CreateFitTableAndInitialize’: > GenVtf.c:1473:3: error: ‘strncpy’ output truncated before terminating > nul copying 8 bytes from a string of the same length > [-Werror=stringop-truncation] >    strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8);  // > "_FIT_ " >    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[1]: *** [../Makefiles/footer.makefile:27: GenVtf.o] Error 1 > make[1]: Leaving directory > '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf' > make: *** [GNUmakefile:73: GenVtf] Error 2 > make: Leaving directory '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C' The edk2 codebase that you are consuming is too old. The above symptom should not be present since commit 1d212a83df0e ("BaseTools/header.makefile: add "-Wno-stringop-truncation"", 2018-03-05). The command line you quoted also misses "-Wno-unused-result", so I think you must be missing commit 202726b3ceb3 ("BaseTools Makefile: Enable O2 option for GCC tool chain", 2016-10-08) as well. I assume clover still uses an edk2 checkout that's 2.5+ years old at this point. Thanks, Laszlo