From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.1591.1689196431562085986 for ; Wed, 12 Jul 2023 14:13:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=LXUAupHV; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: osde@linux.microsoft.com) Received: from [10.137.194.171] (unknown [131.107.1.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 09DFA21C44E8; Wed, 12 Jul 2023 14:13:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 09DFA21C44E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1689196431; bh=J/kWJmUPLS7N7Tq7NVoyWu8JG9B//HcDB0S/xA4kpRI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LXUAupHV8oFIK7R1F202O9xi/oO6h/UTkhDt8SgioSnVE9B126pYNP3zzYHlBex8N tcVBpeEHvwhmqd0gi1rduVPS4KSQjXLmYA6puNgfKpUisrN6QjGIYLQ9SYe5Yc4GfL 3Ow2B45Ciq4gXRWwRZkmNRj6iNjxAoShpy2j0mPc= Message-ID: <838ab72c-f959-c168-9104-49ab4bb7e0ba@linux.microsoft.com> Date: Wed, 12 Jul 2023 14:13:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 00/20] Add the support for ARM Firmware First Framework To: devel@edk2.groups.io, nishant.sharma@arm.com Cc: Ard Biesheuvel , Sami Mujawar , Thomas Abraham , Sayanta Pattanayak , Achin Gupta References: <20230711143658.781597-1-nishant.sharma@arm.com> From: "Oliver Smith-Denny" In-Reply-To: <20230711143658.781597-1-nishant.sharma@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for sending out the patchset! I may be missing it, where is the StMM FF-A partition manifest as part of this? I see where it gets parsed, but not the actual information. My understanding, which may be flawed, is that there should be a separate file defining the StMM manifest. Is that going in TF-A? This seems mostly complete, I agree with Kun that extending support to MmCommunicatePei would seem to be necessary. Thanks, Oliver On 7/11/2023 7:36 AM, Nishant Sharma wrote: > V1 : > > Following patchset add the support of ARM Firmware Framework protocol to > MM communication. > > Following chagnes are made to enable the support > 1> Changed the FFA enable flag(PcdFfaEnable) to integer to enable it > use in assembly. > 2> Add the support to Reserved SP stack space and program in startup > code. > 3> Added ABI for enabling FFA protocol > 4> Added conditional support in Standalone MM to parse DTB and > populated configuration info required for FFA. > 5> Added FFA support in MmCommunicationDxe module. > > Patches are pushed to > https://github.com/nissha03/edk2/tree/ArmFirmwareFramework > > ARM Firmware Framework Protocol: > https://developer.arm.com/documentation/den0077/latest/ > > Achin Gupta (19): > StandaloneMmPkg: Allocate and initialise SP stack from internal memory > StandaloneMmPkg: Include libfdt in the StMM > ArmPkg: Add data structures to receive FF-A boot information > ArmPkg/ArmFfaSvc: Add helper macros and fids > ArmPkg: Add support for FFA_MEM_PERM_GET/SET ABIs > StandaloneMmPkg: define new data structure to stage FF-A boot > information > StandaloneMmPkg: Add backwards compatible support to detect FF-A v1.1 > StandaloneMmPkg: parse SP manifest and populate new boot information > StandaloneMmPkg: Populate Hoblist for SP init from StMM boot > information > StandaloneMmPkg: Skip zero sized sections while tweaking page > permissions > StandaloneMmPkg: Add global check for FF-A abis > ArmPkg: Bump the StMM SP FF-A minor version to 1 > ArmPkg/MmCommunicationDxe: Introduce FF-A version check > ArmPkg/MmCommunicationDxe: Add support for obtaining FF-A partition ID > ArmPkg/MmCommunicationDxe: Register FF-A RX/TX buffers > ArmPkg/MmCommunicationDxe: Unmap FF-A RX/TX buffers during > ExitBootServices > ArmPkg/MmCommunicationDxe: Discover the StMM SP > ArmPkg/MmCommunicationDxe: Use the FF-A transport for MM requests > StandaloneMmPkg: Add support for MM requests as FF-A direct messages > > Nishant Sharma (1): > ArmPkg: Change PcdFfaEnable flag datatype > > ArmPkg/ArmPkg.dec | 14 +- > StandaloneMmPkg/StandaloneMmPkg.dsc | 3 +- > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 3 + > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 4 +- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf | 8 +- > ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 7 +- > ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 133 ++++- > StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h | 39 +- > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 332 ++++++++++-- > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 140 ++++- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c | 186 ++++++- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c | 18 +- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEntryPoint.c | 561 +++++++++++++++++--- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/AArch64/ModuleEntryPoint.S | 68 +++ > 14 files changed, 1367 insertions(+), 149 deletions(-) > create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/AArch64/ModuleEntryPoint.S >