From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smarthost01c.sbp.mail.zen.net.uk (smarthost01c.sbp.mail.zen.net.uk [212.23.1.5]) by mx.groups.io with SMTP id smtpd.web09.4536.1659685972620266385 for ; Fri, 05 Aug 2022 00:52:53 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 sdn.klaviyomail.com}: permanent DNS error (domain: starlabs.systems, ip: 212.23.1.5, mailfrom: sean@starlabs.systems) Received: from [51.148.147.4] (helo=localhost.localdomain) by smarthost01c.sbp.mail.zen.net.uk with esmtp (Exim 4.90_1) (envelope-from ) id 1oJs8V-0006hN-8p; Fri, 05 Aug 2022 07:52:47 +0000 From: "Sean Rhodes" To: devel@edk2.groups.io Cc: Sean Rhodes , Zhichao Gao , Ray Ni , Jian J Wang , Liming Gao Subject: [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations Date: Fri, 5 Aug 2022 08:52:38 +0100 Message-Id: <83963289b879f8f69e8a385038cb88dd73a8c250.1659685959.git.sean@starlabs.systems> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-smarthost01c-IP: [51.148.147.4] Feedback-ID: 51.148.147.4 Content-Transfer-Encoding: quoted-printable Add an option to position the logo 38.2% from the top of the screen, which follows the recommendations from Microsoft. These can be found here: https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-scre= en-components Cc: Zhichao Gao Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Sean Rhodes --- MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h b/MdeModulePkg/In= clude/Protocol/PlatformLogo.h index 08e1dc35a4..b24d7d5b79 100644 --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h @@ -29,7 +29,8 @@ typedef enum { EdkiiPlatformLogoDisplayAttributeCenterBottom,=0D EdkiiPlatformLogoDisplayAttributeLeftBottom,=0D EdkiiPlatformLogoDisplayAttributeCenterLeft,=0D - EdkiiPlatformLogoDisplayAttributeCenter=0D + EdkiiPlatformLogoDisplayAttributeCenter,=0D + EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended=0D } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;=0D =0D /**=0D diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/= Library/BootLogoLib/BootLogoLib.c index 478ec2d40e..9065e5281b 100644 --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c @@ -169,7 +169,6 @@ BootLogoEnableLogo ( DestX =3D SizeOfX - Image.Width;=0D DestY =3D 0;=0D break;=0D -=0D case EdkiiPlatformLogoDisplayAttributeCenterLeft:=0D DestX =3D 0;=0D DestY =3D (SizeOfY - Image.Height) / 2;=0D @@ -182,7 +181,6 @@ BootLogoEnableLogo ( DestX =3D SizeOfX - Image.Width;=0D DestY =3D (SizeOfY - Image.Height) / 2;=0D break;=0D -=0D case EdkiiPlatformLogoDisplayAttributeLeftBottom:=0D DestX =3D 0;=0D DestY =3D SizeOfY - Image.Height;=0D @@ -195,7 +193,10 @@ BootLogoEnableLogo ( DestX =3D SizeOfX - Image.Width;=0D DestY =3D SizeOfY - Image.Height;=0D break;=0D -=0D + case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended:=0D + DestX =3D (SizeOfX - Image.Width) / 2;=0D + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2;=0D + break;=0D default:=0D ASSERT (FALSE);=0D continue;=0D --=20 2.34.1