From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mx.groups.io with SMTP id smtpd.web10.665.1598376126617848836 for ; Tue, 25 Aug 2020 10:22:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=aNC2Hg9D; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.218.52, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-ej1-f52.google.com with SMTP id o18so17599028eje.7 for ; Tue, 25 Aug 2020 10:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=CnF+dNbe/eIrqZZw264KBFc2hnbFNqWF1LSdIxE0dnY=; b=aNC2Hg9DCgGp6RKDDpjySAQwWfGnDKTAXvacApdWaJhi9l9MpF+CL7B7dxzycvwOPH qth+LstR4VkSympaTv0VDqsQDsvkkF83e2+xKo0LXQnuW5CwZuDtzqfqRCYne/KV7Z4h 1QeetWxyXpCYLPijWo2SG13uBaMCXgcpYJQF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=CnF+dNbe/eIrqZZw264KBFc2hnbFNqWF1LSdIxE0dnY=; b=UrgNr7nO+B1D9eNs2tvdzVeXfbu/EkedKOUxgH9/JFfss6HeZjYu7Klq5jsjvGX9T/ AKAQ6jQ9LDySNUr4ucC7qXU263qvBKfCSPtye6wl/M70hFDZGUty2sbK1KN8308ksjCE K8dCsB+bZ0eg5mbczBoYtA8CHsERv5UkdR6oApck6Ifo2OGQtZhSwNElwisK/aqRUcTN C+hBbhAjLACUo09SLFADwkSdKTu9cJ+1PhUtAn4KglBprbqLe4y8+h+fnknKZt+5ZHHx bzGihMvTvhEKY3eB9aeI0nEVSrNNA9Ft7iSd+r1gnwc280hQ950Y2I8sGq4KUTuBlKA5 Tg6g== X-Gm-Message-State: AOAM531TM3am2IddKxOsyNZUQ9RvWqMbxzMh/6dxvYG78o2lPpy2jYGk sHtnjEVbD8pJDhjrePmNWWqs4N2LUt1/tcsoEN4nhw== X-Google-Smtp-Source: ABdhPJxrxWriCMdSoVZWMJEJL4i/gTTK+CDD6Hblbi6jElM2Ws2EGeaZINdZBzzwfbnxmFliF/Q+ITWzka7lcv6SCYE= X-Received: by 2002:a17:906:6a84:: with SMTP id p4mr12210950ejr.374.1598376124701; Tue, 25 Aug 2020 10:22:04 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200821160555.21436-1-vladimir.olovyannikov@broadcom.com> <20200821160555.21436-2-vladimir.olovyannikov@broadcom.com> <4c300ea0874f19d4138084a4c4bed9a2@mail.gmail.com> <2de1f4e9-af3a-b788-9645-5c2970e4b92c@linux.intel.com> In-Reply-To: <2de1f4e9-af3a-b788-9645-5c2970e4b92c@linux.intel.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQE6eo4XhQB8xmbDp5R2QLUMGGowAQJAGVYAAXgws7MBYR+W8AOF6ggIqjwLylA= Date: Tue, 25 Aug 2020 10:22:01 -0700 Message-ID: <83c9c7993b2d4eefc87967ce8dbcde46@mail.gmail.com> Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: "Rabeda, Maciej" , Laszlo Ersek , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd Content-Type: text/plain; charset="UTF-8" Hi Maciej, Thank you for spotting these. > -----Original Message----- > From: Rabeda, Maciej > Sent: Tuesday, August 25, 2020 4:56 AM > To: Vladimir Olovyannikov ; Laszlo > Ersek ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Jiaxin Wu ; Siyuan Fu > ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, > > Since you are already resending, could you address very minor coding > standard items? > > HttpDynamicCommand.c > Line 60: space after func name call > > Http.c > Line 519: indent > Line 586: ); alignment > Line 879: space between SetTimer and ( > Line 1579: ); to next line > > Upon removing openssl and addressing the items above, you can tie: > Reviewed-by: Maciej Rabeda OK, sure, thanks . I've addressed those and am going to submit v7 patchset. Just wondering if you use any tool other than the python script PatchCheck.py under BaseTools/Scripts? I ran that script before, and it found no issues. If there is a better way please let me know. Thank you, Vladimir > > Thanks, > Maciej > > On 25-Aug-20 06:16, Vladimir Olovyannikov wrote: > > Hi Laszlo, > > > > Sorry, I should've checked. No, there was no intention at all to even > > touch an OpenSSL lib. > > I will re-send tomorrow morning. > > > > Thank you, > > Vladimir > > > >> -----Original Message----- > >> From: Laszlo Ersek > >> Sent: Monday, August 24, 2020 12:43 PM > >> To: devel@edk2.groups.io; vladimir.olovyannikov@broadcom.com > >> Cc: Samer El-Haj-Mahmoud ; > Zhichao Gao > >> ; Maciej Rabeda > >> ; Jiaxin Wu ; > >> Siyuan Fu ; Ray Ni ; Liming > >> Gao ; Nd > >> Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: > add > >> HttpDynamicCommand > >> > >> Hi Vladimir, > >> > >> On 08/21/20 18:05, Vladimir Olovyannikov via groups.io wrote: > >>> Introduce an http client utilizing EDK2 HTTP protocol, to allow fast > >>> image downloading from http/https servers. > >>> HTTP download speed is usually faster than tftp. > >>> The client is based on the same approach as tftp dynamic command, > >>> and uses the same UEFI Shell command line parameters. This makes it > >>> easy integrating http into existing UEFI Shell scripts. > >>> Note that to enable HTTP download, feature Pcd > >>> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set > to > >>> TRUE. > >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > >>> > >>> Signed-off-by: Vladimir Olovyannikov > >>> > >>> Cc: Samer El-Haj-Mahmoud > >>> Cc: Laszlo Ersek > >>> Cc: Zhichao Gao > >>> Cc: Maciej Rabeda > >>> Cc: Jiaxin Wu > >>> Cc: Siyuan Fu > >>> Cc: Ray Ni > >>> Cc: Liming Gao > >>> Cc: Nd > >>> --- > >>> ShellPkg/ShellPkg.dec | 1 + > >>> ShellPkg/ShellPkg.dsc | 5 + > >>> .../HttpDynamicCommand/HttpApp.inf | 58 + > >>> .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + > >>> .../DynamicCommand/HttpDynamicCommand/Http.h | 88 + > >>> ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + > >>> .../DynamicCommand/HttpDynamicCommand/Http.c | 1693 > >> +++++++++++++++++ > >>> .../HttpDynamicCommand/HttpApp.c | 61 + > >>> .../HttpDynamicCommand/HttpDynamicCommand.c | 137 ++ > >>> CryptoPkg/Library/OpensslLib/openssl | 2 +- > >>> .../HttpDynamicCommand/Http.uni | 116 ++ > >>> 11 files changed, 2228 insertions(+), 1 deletion(-) create mode > >>> 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf > >>> create mode 100644 > >>> > >> > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > >> .inf > >>> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h > >>> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > >>> create mode 100644 > >>> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c > >>> create mode 100644 > >>> > >> > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > >> .c > >>> create mode 100644 > >>> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni > >> [...] > >> > >>> diff --git a/CryptoPkg/Library/OpensslLib/openssl > >>> b/CryptoPkg/Library/OpensslLib/openssl > >>> index e2e09d9fba11..c3656cc594da 160000 > >>> --- a/CryptoPkg/Library/OpensslLib/openssl > >>> +++ b/CryptoPkg/Library/OpensslLib/openssl > >>> @@ -1 +1 @@ > >>> -Subproject commit e2e09d9fba1187f8d6aafaa34d4172f56f1ffb72 > >>> +Subproject commit c3656cc594daac8167721dde7220f0e59ae146fc > >> your patch includes a hunk that moves our openssl submodule from > >> 1.1.1g back to ~1.1.1d. > >> > >> I think that must be unintentional; can you please drop this hunk and > >> post v7? > >> > >> Thanks > >> Laszlo