From: Laszlo Ersek <lersek@redhat.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
Andrew Fish <afish@apple.com>,
Daniil Egranov <daniil.egranov@arm.com>
Cc: edk2-devel-01 <edk2-devel@ml01.01.org>,
Leif Lindholm <Leif.Lindholm@arm.com>
Subject: Re: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform
Date: Wed, 5 Oct 2016 23:25:05 +0200 [thread overview]
Message-ID: <83e81892-7359-e998-1e61-154af3013269@redhat.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515C54A843F0@FMSMSX103.amr.corp.intel.com>
On 10/05/16 23:15, Carsey, Jaben wrote:
> All,
> What are your thoughts about Tapan's suggestion to move the protocol location to the only function that needs it?
As I wrote elsewhere in the thread, that will eliminate the assert, but
it will break ShellOpenFileByName() for good (under the same
circumstances where the assert is triggered now).
Is a non-functional ShellOpenFileByName() acceptable, if the platform
doesn't provide the collation protocol? In other words, is it okay to
fail to open any file by name just because we can't compare the filename
against NULL because the collation protocol is missing?
Thanks
Laszlo
next prev parent reply other threads:[~2016-10-05 21:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 22:51 Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform Supreeth Venkatesh
2016-10-05 15:40 ` Carsey, Jaben
2016-10-05 16:02 ` Shah, Tapan
2016-10-05 19:24 ` Daniil Egranov
2016-10-05 19:46 ` Tim Lewis
2016-10-05 19:48 ` Andrew Fish
2016-10-05 20:17 ` Laszlo Ersek
2016-10-05 20:24 ` Shah, Tapan
2016-10-05 20:34 ` Carsey, Jaben
2016-10-05 20:39 ` Shah, Tapan
2016-10-05 20:44 ` Tim Lewis
2016-10-05 20:58 ` Laszlo Ersek
2016-10-05 20:59 ` Andrew Fish
2016-10-05 21:06 ` Laszlo Ersek
2016-10-05 21:06 ` Tim Lewis
2016-10-05 21:17 ` Carsey, Jaben
2016-10-05 21:33 ` Tim Lewis
2016-10-05 22:17 ` Carsey, Jaben
2016-10-06 7:22 ` Laszlo Ersek
2016-10-05 21:05 ` Tim Lewis
2016-10-05 20:48 ` Laszlo Ersek
2016-10-05 20:53 ` Daniil Egranov
2016-10-05 21:04 ` Laszlo Ersek
2016-10-05 21:05 ` Andrew Fish
2016-10-05 21:15 ` Carsey, Jaben
2016-10-05 21:20 ` Andrew Fish
2016-10-05 21:25 ` Laszlo Ersek [this message]
2016-10-05 21:42 ` Daniil Egranov
2016-10-05 21:18 ` Laszlo Ersek
2016-10-05 21:34 ` Kinney, Michael D
2016-10-05 21:48 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83e81892-7359-e998-1e61-154af3013269@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox