From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: Sami Mujawar <sami.mujawar@arm.com>,
Rebecca Cran <quic_rcran@quicinc.com>, <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot
Date: Fri, 7 Oct 2022 07:12:37 -0600 [thread overview]
Message-ID: <84126aae-ad5a-b08f-afd5-5caf219224b0@quicinc.com> (raw)
In-Reply-To: <26156.1665146061357606600@groups.io>
Ah, dangit! I completely forgot to run uncrustify.
I'll send out a v3.
--
Rebecca Cran
On 10/7/22 06:34, Sami Mujawar wrote:
> Hi Rebecca,
>
> Thank you for this patch.
>
> On Fri, Oct 7, 2022 at 04:38 AM, Rebecca Cran wrote:
>
> + CharCount = AsciiSPrint (
> + Buffer,
> + sizeof (Buffer),
> + "UEFI firmware (version %s built at %a on %a)\n\r",
> + (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString),
> + __TIME__,
> + __DATE__
> + );
>
> Can you check if uncrustify reports any issue with the above, please?
> Other than that this patch looks good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
next prev parent reply other threads:[~2022-10-07 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 11:38 [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot Rebecca Cran
2022-10-07 12:34 ` [edk2-devel] " Sami Mujawar
2022-10-07 13:12 ` Rebecca Cran [this message]
2022-10-07 13:44 ` Oliver Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84126aae-ad5a-b08f-afd5-5caf219224b0@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox