From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38])
 by mx.groups.io with SMTP id smtpd.web10.4196.1665148375969305212
 for <devel@edk2.groups.io>;
 Fri, 07 Oct 2022 06:12:56 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=IHEtz26w;
 spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 199.106.114.38, mailfrom: quic_rcran@quicinc.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim;
  t=1665148376; x=1696684376;
  h=from:message-id:date:mime-version:subject:to:references:
   in-reply-to:content-transfer-encoding;
  bh=57vSWV34VoSY7HAqRToHedyD77BBUSyX5ys8bcofipw=;
  b=IHEtz26wSmM2/iKWB9dDQYFYKOK2p5zUaO1DKXNy4bezF9Csb8xjYH6T
   tBCJzEHCaCBB4w8fvwPCb8u08mhJiX7Wrn/CdBOwfpiWHxbZ1J6JKRsq8
   IpPK1SrD6cMysshZ/uyHslpUESBEZuX/kqv4pLm4S54DF/mxWIltIHnWv
   8=;
Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144])
  by alexa-out-sd-01.qualcomm.com with ESMTP; 07 Oct 2022 06:12:55 -0700
From: "Rebecca Cran" <quic_rcran@quicinc.com>
X-QCInternal: smtphost
Received: from nasanex01b.na.qualcomm.com ([10.46.141.250])
  by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 06:12:55 -0700
Received: from [10.110.92.41] (10.80.80.8) by nasanex01b.na.qualcomm.com
 (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Fri, 7 Oct 2022
 06:12:55 -0700
Message-ID: <84126aae-ad5a-b08f-afd5-5caf219224b0@quicinc.com>
Date: Fri, 7 Oct 2022 07:12:37 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot
To: Sami Mujawar <sami.mujawar@arm.com>, Rebecca Cran
	<quic_rcran@quicinc.com>, <devel@edk2.groups.io>
References: <20221007113805.43823-1-rebecca@quicinc.com>
 <26156.1665146061357606600@groups.io>
In-Reply-To: <26156.1665146061357606600@groups.io>
Return-Path: rebecca@quicinc.com
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
 nasanex01b.na.qualcomm.com (10.46.141.250)
Content-Language: en-US
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Ah, dangit! I completely forgot to run uncrustify.
I'll send out a v3.

-- 
Rebecca Cran

On 10/7/22 06:34, Sami Mujawar wrote:
> Hi Rebecca,
>
> Thank you for this patch.
>
> On Fri, Oct 7, 2022 at 04:38 AM, Rebecca Cran wrote:
>
>     + CharCount = AsciiSPrint (
>     + Buffer,
>     + sizeof (Buffer),
>     + "UEFI firmware (version %s built at %a on %a)\n\r",
>     + (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString),
>     + __TIME__,
>     + __DATE__
>     + );
>
> Can you check if uncrustify reports any issue with the above, please?
> Other than that this patch looks good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar