From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.163.1652717573752565293 for ; Mon, 16 May 2022 09:12:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=bdDOpKzk; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 6768D20F3D09; Mon, 16 May 2022 09:12:52 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6768D20F3D09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1652717573; bh=BpPV3meQm4i6iOf8IWeThzV5KofnyOJNCAqsqhneaA0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bdDOpKzkzSO8ET58BjjGk3bYhirTZqGW1i3po0h/FulmICGLFVe7wXNsadbKa0g0Q H74qp1vPrTzEGAI/yZgT3nX0c+yi/pDGorLG/TC5J2ySERsgjcArpw9C1AF0QFO9wh jsNYi8D3iudj2h7YknAwSdiMcQMghRsPpuJ0vHwc= Message-ID: <841d68f6-ca41-1825-5c5e-4a8b1c29915f@linux.microsoft.com> Date: Mon, 16 May 2022 12:12:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [edk2-devel] Some questions about Azure CI To: devel@edk2.groups.io, lichao@loongson.cn, Shenglei Zhang , Bob Feng Cc: "michael.d.kinney@intel.com" , "quic_rcran@quicinc.com" , "spbrogan@outlook.com" , gaoliming@byosoft.com.cn References: <16E7C575D2AAB8FB.27458@groups.io> <1f7676c0.2136.180cb4ae4a0.Coremail.lichao@loongson.cn> From: "Michael Kubacki" In-Reply-To: <1f7676c0.2136.180cb4ae4a0.Coremail.lichao@loongson.cn> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable I added some contacts that might know more about what ECC requires in=20 this case. I didn't see any obvious issues in a few of the snippets=20 reported. Regards, Michael On 5/16/2022 1:15 AM, Chao Li wrote: > Hi All, >=20 > There have one last error about EFI coding style error when buiding the= =20 > package for MdePkg, all errors are register defined.=C2=A0Refer=20 > URL:=C2=A0https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?= buildId=3D42&view=3Dlogs&j=3D39eb2cd7-22b4-5bd2-0a69-7cfb110ec9ce&t=3D05ebc= 774-447e-5082-7d78-51b7641489fd&l=3D511=20 >=20 >=20 >=20 > Such errors=C2=A0come from adding new ARCH support, and=C2=A0Liming has s= uggested=20 > that we=C2=A0update the field ExceptionList in MdePkg.ci.yaml to skip thi= s=20 > issue. I tried it and it=C2=A0passed, but I don't think it is=C2=A0best w= ay. >=20 >=20 > Question: >=20 > Do you or=C2=A0other maintainer know why other ARCH don't=C2=A0need to do= this? If=20 > there is another way, we will try it. Please help me! >=20 >=20 > Thanks, >=20 > Chao >=20 >=20 >=20 > -----=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6----- > *=E5=8F=91=E4=BB=B6=E4=BA=BA:*"Chao Li" > *=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:*2022-04-21 09:34:51 (=E6=98=9F= =E6=9C=9F=E5=9B=9B) > *=E6=94=B6=E4=BB=B6=E4=BA=BA:* "devel@edk2.groups.io" , > "mikuback@linux.microsoft.com" > *=E6=8A=84=E9=80=81:* "\"devel@edk2.groups.io\"" , > "\"michael.d.kinney@intel.com\"" , > "\"quic_rcran@quicinc.com\"" , > "\"spbrogan@outlook.com\"" > *=E4=B8=BB=E9=A2=98:* Re: [edk2-devel] Some questions about Azure CI >=20 > Hi Micheal, >=20 > Sorry for my so carelessness, I actually fixed our code yesterday, I > think this bug was brought on by when I modified the code > formatting, I will check carefully next time. Sorry again. >=20 > -- > Thanks, > Chao > ------------------------ >=20 >=20 > On 4=E6=9C=88 20 2022, at 10:45 =E6=99=9A=E4=B8=8A, "Michael Kubacki" > wrote: >=20 > My understanding is that you were referring to the document on > my fork > being difficult to access and you shared a link to your CI > results that > does not have the message pointing to the wiki page yet. >=20 > This is all correct. The wiki content has moved from my fork to t= he > official wiki page and the patch that adds the message to the CI > results > has not been merged yet. It is posted on the mailing list here an= d > waiting for reviews: >=20 > https://edk2.groups.io/g/devel/message/89098 >=20 > --- >=20 > As for your build failing between yesterday and today, note that > the > builds are based on different commits. >=20 > Yesterday: > https://github.com/loongson/edk2/commit/8d100910a2ad98b71acaabc0d= cdd70be7e0eba63 >=20 >=20 > Today: > https://github.com/loongson/edk2/commit/6ca5d9d6c55ca773a652fe525= 08e980c7aa372d3 >=20 >=20 > The commits have different content. In particular, I took a > quick look > at a build that is failing now (Build_GCC5 > TARGET_MDEMODULE_DEBUG) but > previously succeeded. >=20 > The compilation step is failing for reasons such as the following= : >=20 > INFO - > /home/vsts/work/1/s/MdePkg/Include/LoongArch64/ProcessorBind.h:35= :24: >=20 > error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,=E2=80=99, =E2= =80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or =E2=80=98__attribute__=E2=80=99 = before > =E2=80=98UINT16=E2=80=99 > INFO - 35 | typedef unsigned shor UINT16; >=20 > Notice, that there is a typo introduced in the new commit. > "shor" versus > "short", this is what is causing compilation failure. >=20 > Here is a comparison of those two commits showing the line in > ProcessorBind.h that is causing the problem: >=20 > https://github.com/loongson/edk2/compare/8d10091..6ca5d9d#diff-50= b24eb92c5785d5c70097a70104040fcacfb70225dd8196c1a97ef3bbb305c8R35-R36 >=20 >=20 > Regards, > Michael >=20 > On 4/20/2022 7:08 AM, Chao Li wrote: > > Hi Micheal, > > > > Do you know if anyone has modified the Azure CI today? I did > a CI test > > today, and many modules reported errors, but yesterday, only > two modules > > reported errors, I don't know what happened. Please refer > following two > > links: > > > > Today: > > > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?bu= ildId=3D32&view=3Dresults >=20 > > > >=20 > > Yesterday: > > > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?bu= ildId=3D31&view=3Dresults >=20 > > > >=20 > > > > -- > > Thanks, > > Chao > > ------------------------ > > > > > > On 4=E6=9C=88 20 2022, at 6:10 =E6=99=9A=E4=B8=8A, Chao Li > wrote: > > > > Hi Micheal, > > > > Sorry for late reply, I'm busy with other things, focusing on > > modifying our code, refer to the detailed error log file. > > > > I am learning how to get the detailed log from this link: > > > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncr= ustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-format= ting-errors-in-continuous-integration-ci >=20 > > > . >=20 > > I didn't find the detailed log link in the Azure error log, > it looks > > like: > > > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?bu= ildId=3D31&view=3Dlogs&j=3D9701361e-2546-5093-77e5-58c75d95b7ce&t=3D27131ef= 8-75e1-57c3-3236-d806181f2f1f >=20 > > > . >=20 > > > > -- > > Thanks, > > Chao > > ------------------------ > > > > > > On 4=E6=9C=88 20 2022, at 9:56 =E4=B8=8A=E5=8D=88, "Michael Ku= backi" > > wrote: > > > > Hi Chao, > > > > Are you referring to the change I made to put the link to the > > instructions in the build log. Here's an example of what that > > will look > > like: > > > > > https://github.com/makubacki/tianocore.github.io/blob/temp_show_u= ncrustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-i= nstruction-link-in-build-log.png?raw=3Dtrue >=20 > > > > (some of the words running together are not in the actual > change) > > > > I'm open to moving it elsewhere but developers will need to kn= ow > > how to > > at least find that or they will have trouble fixing build > issues. > > > > Regards, > > Michael > > > > > > On 4/19/2022 9:46 PM, Chao Li wrote: > > > Hi Micheal, > > > Using the way your provided the link, I found the detail log= , > > thanks, > > > but this way is not friendly to newbies, because they don't > > know how to > > > find the tutorial.:) > > > > > > -- > > > Thanks, > > > Chao > > > ------------------------ > > > > > > > > > On 4=E6=9C=88 20 2022, at 7:43 =E6=97=A9=E4=B8=8A, "Michael = Kubacki" > > > wrote: > > > > > > The wiki update is here: > > > > > > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncr= ustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-format= ting-errors-in-continuous-integration-ci >=20 > > > > > > I am waiting for permissions to be updated so I can update > > the actual > > > wiki page and then I'll send a patch for the plugin change > > with the link > > > to that section. > > > > > > Regards, > > > Michael > > > > > > On 4/19/2022 6:15 PM, Michael Kubacki wrote: > > > > I agree that is ideal but I'm not aware of how to do that > > at the > > > moment. > > > > > > > > Thanks, > > > > Michael > > > > > > > > On 4/19/2022 4:52 PM, Michael D Kinney wrote: > > > >> Hi Michael, > > > >> > > > >> Can the build log provide a direct link to the log file > > artifact > > > if an > > > >> error is detected? > > > >> > > > >> Mike > > > >> > > > >>> -----Original Message----- > > > >>> From: devel@edk2.groups.io On > > Behalf Of > > > >>> Michael Kubacki > > > >>> Sent: Tuesday, April 19, 2022 12:42 PM > > > >>> To: devel@edk2.groups.io; quic_rcran@quicinc.com; > > > >>> spbrogan@outlook.com; Chao Li > > > >>> Subject: Re: [edk2-devel] Some questions about Azure CI > > > >>> > > > >>> Hi Rebecca, > > > >>> > > > >>> We are trying to keep the results reporting experience > > > consistent with > > > >>> other plugins and prevent an overwhelming amount of > > information > > > being > > > >>> printed to the build log. > > > >>> > > > >>> In case other errors are present, providing high-level > > > information from > > > >>> each plugin can help point the user in the right > direction to > > > get more > > > >>> detail. > > > >>> > > > >>> I completely understand the concern though, so I'm > > planning to make > > > >>> another step toward providing more information about > how to > > > debug an > > > >>> issue, when it occurs. That is to put the step-by-step > > > information about > > > >>> where to find the file diff into the EDK II Code > Formatting > > > wiki page > > > >>> and then if a failure occurs, print a link to that > section of > > > the wiki > > > >>> page. I am hoping this will provide sufficient > information to > > > get to the > > > >>> file diff at the point of failure. > > > >>> > > > >>> I should be able to send these patches later today. > > > >>> > > > >>> Regards, > > > >>> Michael > > > >>> > > > >>> On 4/19/2022 12:43 PM, Rebecca Cran wrote: > > > >>>> Since people are going to keep running into this, > could we > > > just output > > > >>>> the file diff to the console? That would avoid having > to go > > > hunting for > > > >>>> the log file. > > > >>>> > > > >>> > > > >>> > > > >>> > > > >>> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > > > > > > > Sent from Mailspring > > > > Sent from Mailspring >=20 > Sent from Mailspring=20 >=20 >=20 >=20 > /=E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E5=90=AB= =E6=9C=89=E9=BE=99=E8=8A=AF=E4=B8=AD=E7=A7=91=E7=9A=84=E5=95=86=E4=B8=9A=E7= =A7=98=E5=AF=86=E4=BF=A1=E6=81=AF=EF=BC=8C=E4=BB=85=E9=99=90=E4=BA=8E=E5=8F= =91=E9=80=81=E7=BB=99=E4=B8=8A=E9=9D=A2=E5=9C=B0=E5=9D=80=E4=B8=AD=E5=88=97= =E5=87=BA=E7=9A=84=20 > =E4=B8=AA=E4=BA=BA=E6=88=96=E7=BE=A4=E7=BB=84=E3=80=82=E7=A6=81=E6=AD=A2= =E4=BB=BB=E4=BD=95=E5=85=B6=E4=BB=96=E4=BA=BA=E4=BB=A5=E4=BB=BB=E4=BD=95=E5= =BD=A2=E5=BC=8F=E4=BD=BF=E7=94=A8=EF=BC=88=E5=8C=85=E6=8B=AC=E4=BD=86=E4=B8= =8D=E9=99=90=E4=BA=8E=E5=85=A8=E9=83=A8=E6=88=96=E9=83=A8=E5=88=86=E5=9C=B0= =E6=B3=84=E9=9C=B2=E3=80=81=20 > =E5=A4=8D=E5=88=B6=E6=88=96=E6=95=A3=E5=8F=91=EF=BC=89=E6=9C=AC=E9=82=AE= =E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E4=B8=AD=E7=9A=84=E4=BF=A1=E6= =81=AF=E3=80=82=E5=A6=82=E6=9E=9C=E6=82=A8=E9=94=99=E6=94=B6=E6=9C=AC=E9=82= =AE=E4=BB=B6=EF=BC=8C=E8=AF=B7=E6=82=A8=E7=AB=8B=E5=8D=B3=E7=94=B5=E8=AF=9D= =E6=88=96=E9=82=AE=E4=BB=B6=20 > =E9=80=9A=E7=9F=A5=E5=8F=91=E4=BB=B6=E4=BA=BA=E5=B9=B6=E5=88=A0=E9=99=A4= =E6=9C=AC=E9=82=AE=E4=BB=B6=E3=80=82 > This email and its attachments contain confidential information from=20 > Loongson Technology , which is intended only for the person or entity=20 > whose address is listed above. Any use of the information contained=20 > herein in any way (including, but not limited to, total or partial=20 > disclosure, reproduction or dissemination) by persons other than the=20 > intended recipient(s) is prohibited. If you receive this email in error,= =20 > please notify the sender by phone or email immediately and delete it. / >=20