From: "Laszlo Ersek" <lersek@redhat.com>
To: Dandan Bi <dandan.bi@intel.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [patch 16/28] OvmfPkg: Consume RegisterFilterLibNull instance
Date: Tue, 16 Mar 2021 17:42:06 +0100 [thread overview]
Message-ID: <8436cb5e-f137-8054-b62c-0e2e4cfcf630@redhat.com> (raw)
In-Reply-To: <20210315035844.32756-17-dandan.bi@intel.com>
On 03/15/21 04:58, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> Add RegisterFilterLibNull in dsc which will be consumed
> by IoLib and BaseLib.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 1 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
> OvmfPkg/OvmfPkgX64.dsc | 1 +
> OvmfPkg/OvmfXen.dsc | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index 1eaf3e99c6..46a2bc02a9 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -169,10 +169,11 @@
> QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf
> QemuFwCfgSimpleParserLib|OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf
> VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
> LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf
> MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf
> + RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
> !if $(SMM_REQUIRE) == FALSE
> LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf
> !endif
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 4a5a430147..812c2af48b 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -173,10 +173,11 @@
> QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf
> QemuFwCfgSimpleParserLib|OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf
> VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
> LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf
> MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf
> + RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
> !if $(SMM_REQUIRE) == FALSE
> LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf
> !endif
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index d4d601b444..76a41aa351 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -173,10 +173,11 @@
> QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf
> QemuFwCfgSimpleParserLib|OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf
> VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
> LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf
> MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf
> + RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
> !if $(SMM_REQUIRE) == FALSE
> LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf
> !endif
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index 507029404f..f057c9d7c1 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -163,10 +163,11 @@
> QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf
> MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf
> LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
> + RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
>
> !if $(SOURCE_DEBUG_ENABLE) == TRUE
> PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLibDebug.inf
> DebugCommunicationLib|SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf
> !else
>
(1) There are more DSC files under OvmfPkg -- the total set is:
OvmfPkg/AmdSev/AmdSevX64.dsc
OvmfPkg/Bhyve/BhyveX64.dsc
OvmfPkg/OvmfPkgIa32.dsc
OvmfPkg/OvmfPkgIa32X64.dsc
OvmfPkg/OvmfPkgX64.dsc
OvmfPkg/OvmfXen.dsc
(2) Can we please pick a spot that looks similar in all of those DSC
files? If this new class is going to be a dependency of BaseLib, can we
add it near the BaseLib resolution, in each DSC? (E.g., between BaseLib
and SafeIntLib.)
Thanks
Laszlo
next prev parent reply other threads:[~2021-03-16 16:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 3:58 [patch 00/28] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Dandan Bi
2021-03-15 3:58 ` [patch 01/28] MdePkg: Add RegisterFilterLib class and NULL instance Dandan Bi
2021-03-15 5:21 ` [edk2-devel] " Abner Chang
2021-03-15 12:03 ` Dandan Bi
2021-03-15 3:58 ` [patch 02/28] ArmPkg: Consume RegisterFilterLibNull instance Dandan Bi
2021-03-15 3:58 ` [patch 03/28] ArmPlatformPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 04/28] ArmVirtPkg: " Dandan Bi
2021-03-16 16:38 ` Laszlo Ersek
2021-03-15 3:58 ` [patch 05/28] CryptoPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 06/28] DynamicTablesPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 07/28] EmbeddedPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 08/28] EmulatorPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 09/28] FatPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 10/28] FmpDevicePkg: " Dandan Bi
2021-03-15 3:58 ` [patch 11/28] IntelFsp2Pkg: " Dandan Bi
2021-03-15 4:09 ` Chiu, Chasel
2021-03-15 3:58 ` [patch 12/28] IntelFsp2WrapperPkg: " Dandan Bi
2021-03-15 4:09 ` Chiu, Chasel
2021-03-15 3:58 ` [patch 13/28] MdeModulePkg: " Dandan Bi
2021-03-15 6:02 ` Wu, Hao A
2021-03-15 3:58 ` [patch 14/28] MdePkg: " Dandan Bi
2021-03-15 3:58 ` [patch 15/28] NetworkPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 16/28] OvmfPkg: " Dandan Bi
2021-03-16 16:42 ` Laszlo Ersek [this message]
2021-03-15 3:58 ` [patch 17/28] PcAtChipsetPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 18/28] RedfishPkg: " Dandan Bi
2021-03-15 5:21 ` Abner Chang
2021-03-15 5:27 ` Nickle Wang
2021-03-15 3:58 ` [patch 19/28] SecurityPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 20/28] ShellPkg: " Dandan Bi
2021-03-16 8:08 ` Gao, Zhichao
2021-03-15 3:58 ` [patch 21/28] SignedCapsulePkg: " Dandan Bi
2021-03-15 3:58 ` [patch 22/28] SourceLevelDebugPkg: " Dandan Bi
2021-03-15 6:03 ` Wu, Hao A
2021-03-15 3:58 ` [patch 23/28] StandaloneMmPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 24/28] UefiCpuPkg: " Dandan Bi
2021-03-16 16:42 ` Laszlo Ersek
2021-03-15 3:58 ` [patch 25/28] UefiPayloadPkg: " Dandan Bi
2021-03-15 16:06 ` Ma, Maurice
2021-03-15 3:58 ` [patch 26/28] UnitTestFrameworkPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 27/28] MdePkg/IoLib: Filter/trace port IO/MMIO access Dandan Bi
2021-03-15 3:58 ` [patch 28/28] MdePkg/Baseib: Filter/trace MSR access for IA32/X64 Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8436cb5e-f137-8054-b62c-0e2e4cfcf630@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox