From: "Benjamin Doron" <benjamin.doron00@gmail.com>
To: paytonx.hsieh@intel.com,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true
Date: Thu, 27 Apr 2023 10:36:26 -0700 [thread overview]
Message-ID: <8437.1682616986321607120@groups.io> (raw)
In-Reply-To: <88c2cfeb4dc16d4ae1ee934d79085ee8538ff404.1682571439.git.paytonx.hsieh@intel.com>
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
Hi,
Can you deduplicate this code by moving the functions into a common, or "base" file, and DXE's constructor and event into a separate file? As I see it, it should be alright to reuse DXE's functions for other phases, the ` mBaseSerialPortLibHobAtRuntime` variable will never be changed in this case.
Regards,
Benjamin
[-- Attachment #2: Type: text/html, Size: 386 bytes --]
next prev parent reply other threads:[~2023-04-27 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 6:13 [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true paytonx.hsieh
2023-04-27 6:17 ` Guo, Gua
2023-04-27 17:36 ` Benjamin Doron [this message]
2023-04-27 22:38 ` [edk2-devel] " Guo, Gua
2023-04-28 2:33 ` Hsieh, PaytonX
2023-04-28 13:54 ` Benjamin Doron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8437.1682616986321607120@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox