From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true
To: paytonx.hsieh@intel.com,devel@edk2.groups.io
From: "Benjamin Doron" <benjamin.doron00@gmail.com>
X-Originating-Location: Richmond Hill, Ontario, CA (24.52.200.135)
X-Originating-Platform: Linux Chrome 111
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Thu, 27 Apr 2023 10:36:26 -0700
References: <88c2cfeb4dc16d4ae1ee934d79085ee8538ff404.1682571439.git.paytonx.hsieh@intel.com>
In-Reply-To: <88c2cfeb4dc16d4ae1ee934d79085ee8538ff404.1682571439.git.paytonx.hsieh@intel.com>
Message-ID: <8437.1682616986321607120@groups.io>
Content-Type: multipart/alternative; boundary="kqOVwRlduIjN9heTlTCZ"

--kqOVwRlduIjN9heTlTCZ
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,
Can you deduplicate this code by moving the functions into a common, or "ba=
se" file, and DXE's constructor and event into a separate file? As I see it=
, it should be alright to reuse DXE's functions for other phases, the ` mBa=
seSerialPortLibHobAtRuntime` variable will never be changed in this case.

Regards,
Benjamin

--kqOVwRlduIjN9heTlTCZ
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,<br />Can you deduplicate this code by moving the functions into a commo=
n, or "base" file, and DXE's constructor and event into a separate file? As=
 I see it, it should be alright to reuse DXE's functions for other phases, =
the `<span style=3D"white-space: pre-wrap;">mBaseSerialPortLibHobAtRuntime`=
 variable will never be changed in this case.<br /><br />Regards,<br />Benj=
amin</span>

--kqOVwRlduIjN9heTlTCZ--