From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (NAM04-BN3-obe.outbound.protection.outlook.com [40.107.68.50]) by mx.groups.io with SMTP id smtpd.web11.8591.1596726763284813971 for ; Thu, 06 Aug 2020 08:12:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=1H07dlSe; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.68.50, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqug9xJs8mowJTuNpF+Ey5hnqo7ktpYRD3phzqJlM8uwxeT5hPGMlycXHUkTy69cBXWH7KzVq6kdS+fPPDG1JWa3VBWZylQmTzTWQTkbHGwHtXFWHQUreFSi8QQ10mBEW15PjTVyrJbVLqwXlXuDXkhb2FqfAKIf7pjgr3IKAcDgFEMqTBXH3piZnVxOPnu/zMuprsvuYmfNAjBnB3o0FxcvFpQ6Fld7iBz6a0IVvdEu7VUlBgNdR+cErsl7g0k6E3GOXfhP/qn5hmD16NeDFpKBjAYOXUNAstJKcE+X0kvMsMPmSH56ItJZu3xldg59hvGFvTQiLkz9bKFD3TXeNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R0ryFwUEswN34xn8iAL6TBcY+FH/6QZ4KYSDrwr6L84=; b=HN1EupmK48BUkwFG24C4iRIn3w1wSHDw4hapqkTQccyCO+EbBKDWixSyaLmHtoZkE4102TEccCgGT96Zv84+2vMID7Y1dvCLEUJyxMl8OaXP29VZiA8Z0906Mg7qplBCd5Phb+qetDb3sUVdRoFMVbep4Cfp6wsnPE90DKH3QpaJDB5OgV2MGDAWu3v6KNxfvJGQa4sogC9+rwcu8Ttuhi6/Y1pPc+Ei4F3PQHgJqt7+o89xQWA1fafzZ9/OscTvgrrL5xsMOzpcbUKuwCW4YEICabtBeWupQjPrNllePffwy+Wpitn2wSrOw4oZ6F2G49cdpyTDB/RvJeSLMdrOhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R0ryFwUEswN34xn8iAL6TBcY+FH/6QZ4KYSDrwr6L84=; b=1H07dlSeg5N32AawK/PuhcigdJfagfS27BcSDw9xsGtRN59WZXYeN3T3Y20kcYm2Pm3/EDsagbPWV8W9xoapC4Q7VlKyJkrF/ZnphETYDfcVWbEljHE5xvejHwdoAwPOdWoWbyS7/AXKTVhVvV61EcTUsPGX8rHefANpRSeOUek= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Thu, 6 Aug 2020 15:12:35 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0%8]) with mapi id 15.20.3261.019; Thu, 6 Aug 2020 15:12:35 +0000 Subject: Re: [edk2-devel] [PATCH v13 00/46] SEV-ES guest support To: devel@edk2.groups.io, lersek@redhat.com Cc: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Liming Gao , Michael D Kinney , Ray Ni , Andrew Fish , Anthony Perard , Benjamin You , Dandan Bi , Guo Dong , Hao A Wu , Jian J Wang , Julien Grall , Leif Lindholm , Maurice Ma References: <615581ba-9d2d-2f60-9c5d-f3525b54aa0d@redhat.com> From: "Lendacky, Thomas" Message-ID: <8440fc84-e861-976b-b80f-f4a74ab4084b@amd.com> Date: Thu, 6 Aug 2020 10:12:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <615581ba-9d2d-2f60-9c5d-f3525b54aa0d@redhat.com> X-ClientProxiedBy: SA0PR11CA0084.namprd11.prod.outlook.com (2603:10b6:806:d2::29) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from office-linux.texastahm.com (67.79.209.213) by SA0PR11CA0084.namprd11.prod.outlook.com (2603:10b6:806:d2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Thu, 6 Aug 2020 15:12:33 +0000 X-Originating-IP: [67.79.209.213] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7683ae95-2151-4889-ceb6-08d83a1b260d X-MS-TrafficTypeDiagnostic: DM5PR12MB1355: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 15pJ+nHw7abcpdKN8nCfvhGo1lfJ4vAvuuT40RFPG1e1uJt6S3PygXCsTrIvA0nT1AEJLyX5cquVkjwqBPElv3cjbEp0kmJjHIl+HxEVTOHGiEci4YX2aDf94DhjR0bbx9zUzojEnmDiy1m8KrIV8/+tDbxbkmnWS5e0Y10EaF0k4BljomL0exDmYJCcomOiYuHUAdevkKj8KIY4GGfFF6cItpUnThSobe7Oh3ztzy4urACN8UByQrp/yvmTGRIChc2SHTEd6icOdxnntQzMIl4tLrcOuF79uNvBlmhGc8X5gxpEyGqhsw202q6FsYIR+K0Ca+pc3X03gSbz8lVlCNWkG7I59i0uiB2VCeZK4c5dICilO9woL+pPtMye0ntWRon9quiwFPFWPxfGniHAy9BbN+klsQDZM48UY256Izor6w8w4MjvbmHpBYxAbLXCpclL23wqz9v7TBnbZQVICA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(45080400002)(7416002)(4326008)(83380400001)(5660300002)(8676002)(8936002)(186003)(52116002)(53546011)(16526019)(26005)(478600001)(6506007)(6512007)(54906003)(31686004)(2906002)(316002)(6486002)(66556008)(66476007)(86362001)(2616005)(956004)(31696002)(36756003)(66946007)(966005)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: jHgsCYDTHmD0EgCP2nw0QkUNPo+IMpDElKKWRt9W02LjBDGpU9JMXRnKZUydDCw3jH3jOh1hFna7BliqZQadWIjxhJwCaWr0+DH+/1XSsaZJbd65M7XettAR8W85S9Vqy6kMPzFOQXIkH3DyX7KT9pB/HiqlD+4lKewfOLHVLyHCQezQuRMsXhA7sSxYAzCaskvqU4/G1LzyRtCbHqgNvpEoe88jXJ/eIKS4FMHWvbwbvyCto3ZFDRP4+3u2+UW1v8t2m6lTykBLyLrnrEv0CJvVRms7JEDzftgjy21rrE/a/bT048v7J4SKjneyciiNbCq3/kSpHnjp9mbiRm/MsnbEY+PRPMIXd2YUeIfOsl0VIfqdlXgR7A1vbrmv/5dwRM0oJ3L06ijWN9lvbZY8wxBKIjPAz0HTTHL3f2+LbH/ZhLT8T4uQFyvjL6806bxdycmcWdNWI0q9mWg17dgRm73URuwdRJv2jJgzKJ89wRD4bVFXtY+lgdLp8nXeHWaxazbo4OpFlfCWTKTLDyP+4jQJTLAw/v9c7nIipRP//TPAM01wcHQ7L5HQDumVphuXTwZ90OuMk84XPpV3yHchmpmBL1lALpBwY1k+FPEBM06CNQRGNWi9XBQHfKNhbFLvwf7sqwjiviqfb/+DSBWQ3Q== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7683ae95-2151-4889-ceb6-08d83a1b260d X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2020 15:12:35.2681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gk49ZAUOmHwnpA3cDFqjkkd9hL4NQb/B1akBSZUZf+mM217zqNvILRuMGKoNF7WAHIfI8LNd26lr6R7+XECeWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1355 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit It looks like all the patches will have a Reviewed-by: or Acked-by: tag now. I just need to submit another version with the fix to address the IA32 issue that Laszlo found. After that, assuming it is looking good to include this series, there is still the question of the edk2-platform changes that are needed because of the library prereqs introduced by this series. I've updated the appropriate .dsc files in the edk2-platform tree locally and successfully test built some of the configs in the Intel sub-directory (KabylakeRvp3, WhiskeylakeURvp, CometlakeURvp). How would we approach applying this series and providing the updates to the edk2-platform at the same time? Thanks, Tom On 7/31/20 6:54 AM, Laszlo Ersek via groups.io wrote: > On 07/30/20 20:43, Tom Lendacky wrote: > >> Changes since v12: >> - Change IA32 VMGEXIT .nasm file to issue an int 3. Depending on the >> version of NASM, the "BITS 64" trick to get NASM to recognize the >> VMMCALL instruction (VMGEXIT is a REP VMMCALL) caused an error. Since >> SEV-ES is X64 only, VMGEXIT should never be called in IA32. > > I've build-tested this series with various OvmfPkg and ArmVirtPkg > platforms / settings (including Xen); it looks good. > > Build-tested-by: Laszlo Ersek > > Laszlo > > > >