public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io, nd <nd@arm.com>
Subject: Re: [PATCH edk2-platforms v1 01/10] Platform/ARM: Modify duplicated GUID in PciHostBridgeLib
Date: Fri, 17 Dec 2021 14:14:23 +0000	[thread overview]
Message-ID: <84471d0c-23cf-3467-b415-de7902f7a633@arm.com> (raw)
In-Reply-To: <20211124162330.236813-2-Pierre.Gondois@arm.com>

Hi Pierre,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> The two following modules have the same GUID:
> - Platform/ARM/Morello/Library/PciHostBridgeLib/
>    PciHostBridgeLibFvp.inf
> - Platform/ARM/SgiPkg/Library/PciHostBridgeLib/
>    PciHostBridgeLib.inf
>
> The module in the SgiPkg was created first. Update the GUID
> of the module in the Morello folder.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   .../Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf b/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf
> index 1d6c5b01d13d..8524b8572af8 100644
> --- a/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf
> +++ b/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf
> @@ -10,7 +10,7 @@
>   [Defines]
>     INF_VERSION                    = 0x0001001B
>     BASE_NAME                      = PciHostBridgeLib
> -  FILE_GUID                      = 6879CEAD-DC94-42EB-895C-096D36B8083C
> +  FILE_GUID                      = 972E5394-AF1D-45FE-8DC4-F9E5C896E04D
>     MODULE_TYPE                    = DXE_DRIVER
>     VERSION_STRING                 = 1.0
>     LIBRARY_CLASS                  = PciHostBridgeLib|DXE_DRIVER
> --
> 2.25.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2021-12-17 14:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 16:23 [PATCH edk2-platforms v1 00/10] Fix Arm platforms CI errors PierreGondois
2021-11-24 16:23 ` [PATCH edk2-platforms v1 01/10] Platform/ARM: Modify duplicated GUID in PciHostBridgeLib PierreGondois
2021-12-17 14:14   ` Sami Mujawar [this message]
2021-11-24 16:23 ` [PATCH edk2-platforms v1 02/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLib PierreGondois
2021-12-17 14:14   ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec PierreGondois
2021-12-17 13:59   ` Sami Mujawar
2021-12-17 14:15     ` PierreGondois
2021-12-17 16:30       ` Sami Mujawar
2021-12-17 16:33         ` [edk2-devel] " Ard Biesheuvel
2021-12-17 16:39           ` Sami Mujawar
2021-12-20  9:29             ` wenyi,xie
2021-11-24 16:23 ` [PATCH edk2-platforms v1 04/10] Platform/ARM: Modify duplicated GUID in ArmVExpressPkg.dec PierreGondois
2021-12-17 14:14   ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001 PierreGondois
2021-12-17 14:15   ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 06/10] Platform/ARM: Fix Ecc error 1008 PierreGondois
2021-12-17 14:15   ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 07/10] Platform/ARM: Fix Ecc error 1012 PierreGondois
2021-12-17 14:15   ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 08/10] Platform/ARM: Fix Ecc error 3003 PierreGondois
2021-12-17 14:15   ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 09/10] Platform/ARM: Fix Ecc error 9005 PierreGondois
2021-12-17 14:15   ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 10/10] Platform/ARM: Fix Ecc error 5005 PierreGondois
2021-12-17 14:16   ` Sami Mujawar
2021-11-24 18:34 ` [edk2-devel] [PATCH edk2-platforms v1 00/10] Fix Arm platforms CI errors Chris Jones
2022-01-24 14:31   ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84471d0c-23cf-3467-b415-de7902f7a633@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox