From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@ml01.01.org
Cc: leif.lindholm@linaro.org
Subject: Re: [PATCH v2 3/6] ArmVirtPkg: implement FdtPciHostBridgeLib
Date: Fri, 2 Sep 2016 12:15:37 +0200 [thread overview]
Message-ID: <8453ca17-d498-9eb4-86e6-ab995531732a@redhat.com> (raw)
In-Reply-To: <1472666379-25426-4-git-send-email-ard.biesheuvel@linaro.org>
On 08/31/16 19:59, Ard Biesheuvel wrote:
> Implement PciHostBridgeLib for DT platforms that expose a PCI root bridge
> via a pci-host-ecam-generic DT node. The DT parsing logic is copied from
> the PciHostBridgeDxe implementation in ArmVirtPkg, with the one notable
> difference that we don't set the various legacy PCI attributes for IDE
> and VGA I/O ranges.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Ref: https://tianocore.acgmultimedia.com/show_bug.cgi?id=65
> ---
> ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 400 ++++++++++++++++++++
> ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 56 +++
> 2 files changed, 456 insertions(+)
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
> diff --git a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> new file mode 100644
> index 000000000000..c2aa4a339c19
> --- /dev/null
> +++ b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> @@ -0,0 +1,400 @@
> +/** @file
> + PCI Host Bridge Library instance for pci-ecam-generic DT nodes
> +
> + Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> +
> + This program and the accompanying materials are licensed and made available
> + under the terms and conditions of the BSD License which accompanies this
> + distribution. The full text of the license may be found at
> + http://opensource.org/licenses/bsd-license.php.
> +
> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> + IMPLIED.
> +
> +**/
> +#include <PiDxe.h>
> +#include <Library/PciHostBridgeLib.h>
> +#include <Library/DebugLib.h>
> +#include <Library/DevicePathLib.h>
> +#include <Library/MemoryAllocationLib.h>
> +#include <Library/PcdLib.h>
> +#include <Library/UefiBootServicesTableLib.h>
> +
> +#include <Protocol/FdtClient.h>
> +#include <Protocol/PciRootBridgeIo.h>
> +#include <Protocol/PciHostBridgeResourceAllocation.h>
> +
> +#pragma pack(1)
> +typedef struct {
> + ACPI_HID_DEVICE_PATH AcpiDevicePath;
> + EFI_DEVICE_PATH_PROTOCOL EndDevicePath;
> +} EFI_PCI_ROOT_BRIDGE_DEVICE_PATH;
> +#pragma pack ()
> +
> +STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRootBridgeDevicePath = {
> + {
> + {
> + ACPI_DEVICE_PATH,
> + ACPI_DP,
> + {
> + (UINT8) (sizeof(ACPI_HID_DEVICE_PATH)),
> + (UINT8) ((sizeof(ACPI_HID_DEVICE_PATH)) >> 8)
> + }
> + },
> + EISA_PNP_ID(0x0A08), // PCI Express
> + 0
> + },
> +
> + {
> + END_DEVICE_PATH_TYPE,
> + END_ENTIRE_DEVICE_PATH_SUBTYPE,
> + {
> + END_DEVICE_PATH_LENGTH,
> + 0
> + }
> + }
> +};
> +
> +GLOBAL_REMOVE_IF_UNREFERENCED
> +CHAR16 *mPciHostBridgeLibAcpiAddressSpaceTypeStr[] = {
> + L"Mem", L"I/O", L"Bus"
> +};
> +
> +//
> +// We expect the "ranges" property of "pci-host-ecam-generic" to consist of
> +// records like this.
> +//
> +#pragma pack (1)
> +typedef struct {
> + UINT32 Type;
> + UINT64 ChildBase;
> + UINT64 CpuBase;
> + UINT64 Size;
> +} DTB_PCI_HOST_RANGE_RECORD;
> +#pragma pack ()
> +
> +#define DTB_PCI_HOST_RANGE_RELOCATABLE BIT31
> +#define DTB_PCI_HOST_RANGE_PREFETCHABLE BIT30
> +#define DTB_PCI_HOST_RANGE_ALIASED BIT29
> +#define DTB_PCI_HOST_RANGE_MMIO32 BIT25
> +#define DTB_PCI_HOST_RANGE_MMIO64 (BIT25 | BIT24)
> +#define DTB_PCI_HOST_RANGE_IO BIT24
> +#define DTB_PCI_HOST_RANGE_TYPEMASK (BIT31 | BIT30 | BIT29 | BIT25 | BIT24)
> +
> +STATIC
> +EFI_STATUS
> +ProcessPciHost (
> + OUT UINT64 *IoBase,
> + OUT UINT64 *IoSize,
> + OUT UINT64 *MmioBase,
> + OUT UINT64 *MmioSize,
> + OUT UINT32 *BusMin,
> + OUT UINT32 *BusMax
> + )
> +{
> + FDT_CLIENT_PROTOCOL *FdtClient;
> + INT32 Node;
> + UINT64 ConfigBase, ConfigSize;
> + CONST VOID *Prop;
> + UINT32 Len;
> + UINT32 RecordIdx;
> + EFI_STATUS Status;
> + UINT64 IoTranslation;
> + UINT64 MmioTranslation;
> +
> + //
> + // The following output arguments are initialized only in
> + // order to suppress '-Werror=maybe-uninitialized' warnings
> + // *incorrectly* emitted by some gcc versions.
> + //
> + *IoBase = 0;
> + *MmioBase = 0;
> + *BusMin = 0;
> + *BusMax = 0;
> +
> + //
> + // *IoSize, *MmioSize and IoTranslation are initialized to zero because the
> + // logic below requires it. However, since they are also affected by the issue
> + // reported above, they are initialized early.
> + //
> + *IoSize = 0;
> + *MmioSize = 0;
> + IoTranslation = 0;
> +
> + Status = gBS->LocateProtocol (&gFdtClientProtocolGuid, NULL,
> + (VOID **)&FdtClient);
> + ASSERT_EFI_ERROR (Status);
> +
> + Status = FdtClient->FindCompatibleNode (FdtClient, "pci-host-ecam-generic",
> + &Node);
> + if (EFI_ERROR (Status)) {
> + DEBUG ((EFI_D_INFO,
> + "%a: No 'pci-host-ecam-generic' compatible DT node found\n",
> + __FUNCTION__));
> + return EFI_NOT_FOUND;
> + }
> +
> + DEBUG_CODE (
> + INT32 Tmp;
> +
> + //
> + // A DT can legally describe multiple PCI host bridges, but we are not
> + // equipped to deal with that. So assert that there is only one.
> + //
> + Status = FdtClient->FindNextCompatibleNode (FdtClient,
> + "pci-host-ecam-generic", Node, &Tmp);
> + ASSERT (Status == EFI_NOT_FOUND);
> + );
> +
> + Status = FdtClient->GetNodeProperty (FdtClient, Node, "reg", &Prop, &Len);
> + if (EFI_ERROR (Status) || Len != 2 * sizeof (UINT64)) {
> + DEBUG ((EFI_D_ERROR, "%a: 'reg' property not found or invalid\n",
> + __FUNCTION__));
> + return EFI_PROTOCOL_ERROR;
> + }
> +
> + //
> + // Fetch the ECAM window.
> + //
> + ConfigBase = SwapBytes64 (((CONST UINT64 *)Prop)[0]);
> + ConfigSize = SwapBytes64 (((CONST UINT64 *)Prop)[1]);
> +
> + //
> + // Fetch the bus range (note: inclusive).
> + //
> + Status = FdtClient->GetNodeProperty (FdtClient, Node, "bus-range", &Prop,
> + &Len);
> + if (EFI_ERROR (Status) || Len != 2 * sizeof (UINT32)) {
> + DEBUG ((EFI_D_ERROR, "%a: 'bus-range' not found or invalid\n",
> + __FUNCTION__));
> + return EFI_PROTOCOL_ERROR;
> + }
> + *BusMin = SwapBytes32 (((CONST UINT32 *)Prop)[0]);
> + *BusMax = SwapBytes32 (((CONST UINT32 *)Prop)[1]);
> +
> + //
> + // Sanity check: the config space must accommodate all 4K register bytes of
> + // all 8 functions of all 32 devices of all buses.
> + //
> + if (*BusMax < *BusMin || *BusMax - *BusMin == MAX_UINT32 ||
> + DivU64x32 (ConfigSize, SIZE_4KB * 8 * 32) < *BusMax - *BusMin + 1) {
> + DEBUG ((EFI_D_ERROR, "%a: invalid 'bus-range' and/or 'reg'\n",
> + __FUNCTION__));
> + return EFI_PROTOCOL_ERROR;
> + }
> +
> + //
> + // Iterate over "ranges".
> + //
> + Status = FdtClient->GetNodeProperty (FdtClient, Node, "ranges", &Prop, &Len);
> + if (EFI_ERROR (Status) || Len == 0 ||
> + Len % sizeof (DTB_PCI_HOST_RANGE_RECORD) != 0) {
> + DEBUG ((EFI_D_ERROR, "%a: 'ranges' not found or invalid\n", __FUNCTION__));
> + return EFI_PROTOCOL_ERROR;
> + }
> +
> + for (RecordIdx = 0; RecordIdx < Len / sizeof (DTB_PCI_HOST_RANGE_RECORD);
> + ++RecordIdx) {
> + CONST DTB_PCI_HOST_RANGE_RECORD *Record;
> +
> + Record = (CONST DTB_PCI_HOST_RANGE_RECORD *)Prop + RecordIdx;
> + switch (SwapBytes32 (Record->Type) & DTB_PCI_HOST_RANGE_TYPEMASK) {
> + case DTB_PCI_HOST_RANGE_IO:
> + *IoBase = SwapBytes64 (Record->ChildBase);
> + *IoSize = SwapBytes64 (Record->Size);
> + IoTranslation = SwapBytes64 (Record->CpuBase) - *IoBase;
> +
> + ASSERT (PcdGet64 (PcdPciIoTranslation) == IoTranslation);
> + break;
> +
> + case DTB_PCI_HOST_RANGE_MMIO32:
> + *MmioBase = SwapBytes64 (Record->ChildBase);
> + *MmioSize = SwapBytes64 (Record->Size);
> + MmioTranslation = SwapBytes64 (Record->CpuBase) - *MmioBase;
> +
> + if (*MmioBase > MAX_UINT32 || *MmioSize > MAX_UINT32 ||
> + *MmioBase + *MmioSize > SIZE_4GB) {
> + DEBUG ((EFI_D_ERROR, "%a: MMIO32 space invalid\n", __FUNCTION__));
> + return EFI_PROTOCOL_ERROR;
> + }
> +
> + ASSERT (PcdGet64 (PcdPciMmio32Translation) == MmioTranslation);
> +
> + if (MmioTranslation != 0) {
> + DEBUG ((EFI_D_ERROR, "%a: unsupported nonzero MMIO32 translation "
> + "0x%Lx\n", __FUNCTION__, MmioTranslation));
> + return EFI_UNSUPPORTED;
> + }
> +
> + break;
> + }
> + }
> + if (*IoSize == 0 || *MmioSize == 0) {
> + DEBUG ((EFI_D_ERROR, "%a: %a space empty\n", __FUNCTION__,
> + (*IoSize == 0) ? "IO" : "MMIO32"));
> + return EFI_PROTOCOL_ERROR;
> + }
> +
> + //
> + // The dynamic PCD PcdPciExpressBaseAddress should have already been set,
> + // and should match the value we found in the DT node.
> + //
> + ASSERT (PcdGet64 (PcdPciExpressBaseAddress) == ConfigBase);
> +
> + DEBUG ((EFI_D_INFO, "%a: Config[0x%Lx+0x%Lx) Bus[0x%x..0x%x] "
> + "Io[0x%Lx+0x%Lx)@0x%Lx Mem[0x%Lx+0x%Lx)@0x0\n", __FUNCTION__, ConfigBase,
> + ConfigSize, *BusMin, *BusMax, *IoBase, *IoSize, IoTranslation, *MmioBase,
> + *MmioSize));
> + return EFI_SUCCESS;
> +}
> +
> +STATIC PCI_ROOT_BRIDGE mRootBridge;
> +
> +/**
> + Return all the root bridge instances in an array.
> +
> + @param Count Return the count of root bridge instances.
> +
> + @return All the root bridge instances in an array.
> + The array should be passed into PciHostBridgeFreeRootBridges()
> + when it's not used.
> +**/
> +PCI_ROOT_BRIDGE *
> +EFIAPI
> +PciHostBridgeGetRootBridges (
> + UINTN *Count
> + )
> +{
> + UINT64 IoBase, IoSize;
> + UINT64 Mmio32Base, Mmio32Size;
> + UINT32 BusMin, BusMax;
> + EFI_STATUS Status;
> +
> + if (PcdGet64 (PcdPciExpressBaseAddress) == 0) {
> + DEBUG ((EFI_D_INFO, "%a: PCI host bridge not present\n", __FUNCTION__));
> +
> + *Count = 0;
> + return NULL;
> + }
> +
> + Status = ProcessPciHost (&IoBase, &IoSize, &Mmio32Base, &Mmio32Size, &BusMin,
> + &BusMax);
> + if (EFI_ERROR (Status)) {
> + DEBUG ((EFI_D_ERROR, "%a: failed to discover PCI host bridge: %r\n",
> + __FUNCTION__, Status));
> + *Count = 0;
> + return NULL;
> + }
> +
> + *Count = 1;
> +
> + mRootBridge.Segment = 0;
> + mRootBridge.Supports = EFI_PCI_ATTRIBUTE_ISA_IO_16 |
> + EFI_PCI_ATTRIBUTE_ISA_MOTHERBOARD_IO |
> + EFI_PCI_ATTRIBUTE_VGA_IO_16 |
> + EFI_PCI_ATTRIBUTE_VGA_PALETTE_IO_16;
> + mRootBridge.Attributes = mRootBridge.Supports;
> +
> + mRootBridge.DmaAbove4G = TRUE;
> + mRootBridge.NoExtendedConfigSpace = FALSE;
> + mRootBridge.ResourceAssigned = FALSE;
> +
> + mRootBridge.AllocationAttributes = EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM;
> +
> + mRootBridge.Bus.Base = BusMin;
> + mRootBridge.Bus.Limit = BusMax;
> + mRootBridge.Io.Base = IoBase;
> + mRootBridge.Io.Limit = IoBase + IoSize - 1;
> + mRootBridge.Mem.Base = Mmio32Base;
> + mRootBridge.Mem.Limit = Mmio32Base + Mmio32Size - 1;
> + mRootBridge.MemAbove4G.Base = MAX_UINT64;
> + mRootBridge.MemAbove4G.Limit = 0;
> +
> + //
> + // No separate ranges for prefetchable and non-prefetchable BARs
> + //
> + mRootBridge.PMem.Base = MAX_UINT64;
> + mRootBridge.PMem.Limit = 0;
> + mRootBridge.PMemAbove4G.Base = MAX_UINT64;
> + mRootBridge.PMemAbove4G.Limit = 0;
> +
> + mRootBridge.DevicePath = (EFI_DEVICE_PATH_PROTOCOL *)&mEfiPciRootBridgeDevicePath;
> +
> + return &mRootBridge;
> +}
> +
> +/**
> + Free the root bridge instances array returned from
> + PciHostBridgeGetRootBridges().
> +
> + @param Bridges The root bridge instances array.
> + @param Count The count of the array.
> +**/
> +VOID
> +EFIAPI
> +PciHostBridgeFreeRootBridges (
> + PCI_ROOT_BRIDGE *Bridges,
> + UINTN Count
> + )
> +{
> + ASSERT (Count == 1);
> +}
> +
> +/**
> + Inform the platform that the resource conflict happens.
> +
> + @param HostBridgeHandle Handle of the Host Bridge.
> + @param Configuration Pointer to PCI I/O and PCI memory resource
> + descriptors. The Configuration contains the resources
> + for all the root bridges. The resource for each root
> + bridge is terminated with END descriptor and an
> + additional END is appended indicating the end of the
> + entire resources. The resource descriptor field
> + values follow the description in
> + EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL
> + .SubmitResources().
> +**/
> +VOID
> +EFIAPI
> +PciHostBridgeResourceConflict (
> + EFI_HANDLE HostBridgeHandle,
> + VOID *Configuration
> + )
> +{
> + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;
> + UINTN RootBridgeIndex;
> + DEBUG ((EFI_D_ERROR, "PciHostBridge: Resource conflict happens!\n"));
> +
> + RootBridgeIndex = 0;
> + Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *) Configuration;
> + while (Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR) {
> + DEBUG ((EFI_D_ERROR, "RootBridge[%d]:\n", RootBridgeIndex++));
> + for (; Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR; Descriptor++) {
> + ASSERT (Descriptor->ResType <
> + (sizeof (mPciHostBridgeLibAcpiAddressSpaceTypeStr) /
> + sizeof (mPciHostBridgeLibAcpiAddressSpaceTypeStr[0])
> + )
> + );
> + DEBUG ((EFI_D_ERROR, " %s: Length/Alignment = 0x%lx / 0x%lx\n",
> + mPciHostBridgeLibAcpiAddressSpaceTypeStr[Descriptor->ResType],
> + Descriptor->AddrLen, Descriptor->AddrRangeMax
> + ));
> + if (Descriptor->ResType == ACPI_ADDRESS_SPACE_TYPE_MEM) {
> + DEBUG ((EFI_D_ERROR, " Granularity/SpecificFlag = %ld / %02x%s\n",
> + Descriptor->AddrSpaceGranularity, Descriptor->SpecificFlag,
> + ((Descriptor->SpecificFlag &
> + EFI_ACPI_MEMORY_RESOURCE_SPECIFIC_FLAG_CACHEABLE_PREFETCHABLE
> + ) != 0) ? L" (Prefetchable)" : L""
> + ));
> + }
> + }
> + //
> + // Skip the END descriptor for root bridge
> + //
> + ASSERT (Descriptor->Desc == ACPI_END_TAG_DESCRIPTOR);
> + Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *)(
> + (EFI_ACPI_END_TAG_DESCRIPTOR *)Descriptor + 1
> + );
> + }
> +}
> diff --git a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> new file mode 100644
> index 000000000000..fc1d37fb3c23
> --- /dev/null
> +++ b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> @@ -0,0 +1,56 @@
> +## @file
> +# PCI Host Bridge Library instance for pci-ecam-generic DT nodes
> +#
> +# Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> +#
> +# This program and the accompanying materials are licensed and made available
> +# under the terms and conditions of the BSD License which accompanies this
> +# distribution. The full text of the license may be found at
> +# http://opensource.org/licenses/bsd-license.php.
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> +# IMPLIED.
> +#
> +#
> +##
> +
> +[Defines]
> + INF_VERSION = 0x00010005
> + BASE_NAME = FdtPciHostBridgeLib
> + FILE_GUID = 59fcb139-2558-4cf0-8d7c-ebac499da727
> + MODULE_TYPE = DXE_DRIVER
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = PciHostBridgeLib
> +
> +#
> +# The following information is for reference only and not required by the build
> +# tools.
> +#
> +# VALID_ARCHITECTURES = AARCH64 ARM
> +#
> +
> +[Sources]
> + FdtPciHostBridgeLib.c
> +
> +[Packages]
> + ArmPkg/ArmPkg.dec
> + ArmVirtPkg/ArmVirtPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> + MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> + DebugLib
> + DevicePathLib
> + MemoryAllocationLib
> + PciPcdProducerLib
> +
> +[FixedPcd]
> + gArmTokenSpaceGuid.PcdPciMmio32Translation
> +
> +[Pcd]
> + gArmTokenSpaceGuid.PcdPciIoTranslation
> + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> +
> +[Depex]
> + gFdtClientProtocolGuid
>
next prev parent reply other threads:[~2016-09-02 10:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 17:59 [PATCH v2 0/6] ArmVirtQemu: move to generic PciHostBridgeDxe Ard Biesheuvel
2016-08-31 17:59 ` [PATCH v2 1/6] ArmVirtPkg/PciHostBridgeDxe: don't set linux, pci-probe-only DT property Ard Biesheuvel
2016-08-31 17:59 ` [PATCH v2 2/6] ArmVirtPkg/FdtPciPcdProducerLib: add handling of PcdPciIoTranslation Ard Biesheuvel
2016-09-02 11:19 ` Laszlo Ersek
2016-08-31 17:59 ` [PATCH v2 3/6] ArmVirtPkg: implement FdtPciHostBridgeLib Ard Biesheuvel
2016-09-02 10:15 ` Laszlo Ersek [this message]
2016-08-31 17:59 ` [PATCH v2 4/6] ArmVirtPkg/ArmVirtQemu: switch to generic PciHostBridgeDxe Ard Biesheuvel
2016-08-31 17:59 ` [PATCH v2 5/6] ArmVirtPkg/FdtPciHostBridgeLib: add MMIO64 support Ard Biesheuvel
2016-09-02 10:44 ` Laszlo Ersek
2016-08-31 17:59 ` [PATCH v2 6/6] ArmVirtPkg: remove now unused PciHostBridgeDxe Ard Biesheuvel
2016-09-02 13:09 ` [PATCH v2 0/6] ArmVirtQemu: move to generic PciHostBridgeDxe Laszlo Ersek
2016-09-02 13:17 ` Laszlo Ersek
2016-09-02 14:58 ` Ard Biesheuvel
2016-09-02 15:27 ` Laszlo Ersek
2016-09-02 16:13 ` Laszlo Ersek
2016-09-02 16:26 ` Ard Biesheuvel
2016-09-02 17:21 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8453ca17-d498-9eb4-86e6-ab995531732a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox