From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 23 Sep 2019 08:09:29 -0700 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8277658569 for ; Mon, 23 Sep 2019 15:09:28 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id l6so4997482wrn.2 for ; Mon, 23 Sep 2019 08:09:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iEm9kfd94vUlV8G0TyGpxQgFNu2GkpSRZOwBjjwa8fc=; b=ukT256AE6fcfMHZ+C/pT2vkv8BoVddmHTr2h2ABoOuO/D8qVKUXgHp3hmaFijBn3Sx 4gv+XU8up22G9ZVP/HYVnN4zUqo8o800s9zheIBY/MrmRteF7TiQlN73YG8mEBNZx+qX 2j0FqjDFAYbrAOlBxYzdlcPbVrjU6lcdUBQmnU3GfX6NPoS3gROpIGOZbCC/RCL6BnY3 VLH0DwYoARCyealQg9hzdElPsWXEIutbhprPJDDIytCNZRujzpWZF4NRVLcm/TabfnWB gdV9oOgESwfyKeK3Yio7LJtnBUms84zW79ir1iXvr02x9/68kCL0vR2kTnc1b8N+5ph7 fBdQ== X-Gm-Message-State: APjAAAWO+4HTWXK6YcrC6vQcm3HuRFMnIKGmyI6f2f9Cgs4zR5uXKksf ug712G1QCdIgrtCyku4ugKLjT2Tt/5EtkfLL4KXDJ15DmBkawDvf7SZV//3Uutqf90jpvNvNqws BSonUAnoO+ng9cQ== X-Received: by 2002:adf:e812:: with SMTP id o18mr9026948wrm.398.1569251367336; Mon, 23 Sep 2019 08:09:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwPZsAXjnJ96ww8V/n1NF0bwiT2QDj7Jbfd6LxYgQOXXxcrhDXn9dASJHT9qDyzwvMAwkJZMg== X-Received: by 2002:adf:e812:: with SMTP id o18mr9026931wrm.398.1569251367153; Mon, 23 Sep 2019 08:09:27 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id x5sm11827702wrt.75.2019.09.23.08.09.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 08:09:26 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list To: devel@edk2.groups.io, lersek@redhat.com Cc: Jiaxin Wu , Siyuan Fu References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-22-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <845c7087-aa3d-38f3-41ba-28c40a824da7@redhat.com> Date: Mon, 23 Sep 2019 17:09:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-22-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The SockFreeFoo() callback function for NetbufFromExt() has to match the > NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback argument > (Arg). EFI_EVENT has nothing to do with NET_VECTOR_EXT_FREE. Fix the > SockFreeFoo() parameter list. > > This change is a no-op in practice. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > NetworkPkg/TcpDxe/SockImpl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/TcpDxe/SockImpl.c b/NetworkPkg/TcpDxe/SockImpl.c > index f5e01771e2a8..fb28e2ed40d3 100644 > --- a/NetworkPkg/TcpDxe/SockImpl.c > +++ b/NetworkPkg/TcpDxe/SockImpl.c > @@ -67,13 +67,13 @@ SockBufNext ( > /** > User provided callback function for NetbufFromExt. > > - @param[in] Event The Event this notify function registered to, ignored. > + @param[in] Arg The Arg parameter forwarded by NetbufFromExt(). Ignored. > > **/ > VOID > EFIAPI > SockFreeFoo ( > - IN EFI_EVENT Event > + IN VOID *Arg > ) > { > return; > Reviewed-by: Philippe Mathieu-Daude