From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, liming.gao@intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Ting Ye <ting.ye@intel.com>,
Fu Siyuan <siyuan.fu@intel.com>
Subject: Re: [edk2-devel] [Patch v4 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
Date: Tue, 30 Apr 2019 16:35:17 +0200 [thread overview]
Message-ID: <84852f21-92fc-bf07-e53a-4f5e65f02f99@redhat.com> (raw)
In-Reply-To: <20190429145012.14852-3-liming.gao@intel.com>
Hi Liming,
I posted my v3 review at:
https://edk2.groups.io/g/devel/message/39770
Let me summarize how the v4 posting relates to my v3 review:
- The current patch (v4 2/3) addresses my requests (1) and (2). Thanks
for that.
- In the v3 review, you said that you'd update the release planning
page, if the series matures in time for edk2-stable201905. That covers
my request (3), thanks.
- It seems that you missed the rest of my requests under v3, namely
points (4) through (11). Because, you neither commented on them (in the
v3 thread), nor addressed them (in the v4 posting). Did you stop reading
my v3 email at point (3)?
Please re-read my v3 review in whole, respond to each of my requests,
and address (in a v5 posting) those requests that you agree with.
Thank you,
Laszlo
next prev parent reply other threads:[~2019-04-30 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:50 [Patch v4 0/3] Add package level include DSC/FDF in NetworkPkg Liming Gao
2019-04-29 14:50 ` [Patch v4 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build Liming Gao
2019-04-30 13:40 ` [edk2-devel] " Laszlo Ersek
2019-04-29 14:50 ` [Patch v4 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg Liming Gao
2019-04-30 14:35 ` Laszlo Ersek [this message]
2019-04-29 14:50 ` [Patch v4 3/3] NetworkPkg: Add package level include DSC file Liming Gao
2019-04-30 14:42 ` [edk2-devel] " Laszlo Ersek
2019-05-05 14:53 ` Liming Gao
2019-05-06 11:53 ` Laszlo Ersek
2019-05-06 13:24 ` Liming Gao
2019-05-06 14:28 ` Laszlo Ersek
2019-05-06 14:30 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84852f21-92fc-bf07-e53a-4f5e65f02f99@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox