From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 30 Apr 2019 07:35:27 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 42FDB308FEC1;
	Tue, 30 Apr 2019 14:35:21 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-42.rdu2.redhat.com [10.10.121.42])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E9F3D1001E85;
	Tue, 30 Apr 2019 14:35:18 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch v4 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
To: devel@edk2.groups.io, liming.gao@intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Ting Ye <ting.ye@intel.com>,
 Fu Siyuan <siyuan.fu@intel.com>
References: <20190429145012.14852-1-liming.gao@intel.com>
 <20190429145012.14852-3-liming.gao@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <84852f21-92fc-bf07-e53a-4f5e65f02f99@redhat.com>
Date: Tue, 30 Apr 2019 16:35:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190429145012.14852-3-liming.gao@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 30 Apr 2019 14:35:21 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Liming,

I posted my v3 review at:

  https://edk2.groups.io/g/devel/message/39770

Let me summarize how the v4 posting relates to my v3 review:

- The current patch (v4 2/3) addresses my requests (1) and (2). Thanks
for that.

- In the v3 review, you said that you'd update the release planning
page, if the series matures in time for edk2-stable201905. That covers
my request (3), thanks.

- It seems that you missed the rest of my requests under v3, namely
points (4) through (11). Because, you neither commented on them (in the
v3 thread), nor addressed them (in the v4 posting). Did you stop reading
my v3 email at point (3)?
Please re-read my v3 review in whole, respond to each of my requests,
and address (in a v5 posting) those requests that you agree with.

Thank you,
Laszlo