From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D5E11D80888 for ; Mon, 5 Aug 2024 16:18:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3CS11JmNHoEWprDa0Yu1+cn5x3pMz7c44UQZ+XCJKEs=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722874730; v=1; b=yNoqBR2GXuxBem/KEqGDtaIoiRfEZmzIClUJtnrfBuhKm08HcnmN3Robj/3bsqfh1agF3nFj Da8631h9IW/Oz73G0+Vj9y1Bx22PcYGPj+MqCKmr4jHG1Eig3Gw5Si4Og/mBqdSNA4xtl4FuCuz f813oAlrwr7JVuVjRmRGqF6osx4RZoI+p7exLyQj+l7Gs6IN94M0I1nYuh04pBxgMjyiOcTu/Sa LOZEH34wFBlDzkRFYGU6zhy4ATe+OJ6Arm6ZGFnDRT2+lrQsdBZII7N8a71x3XNYnckbG3pfQBt jngayCaZGIqik1CjLP/Lk4pcw7cV17Wlj3Zqqkr8wg+AQ== X-Received: by 127.0.0.2 with SMTP id CnBZYY7687511x63NDbEQYTs; Mon, 05 Aug 2024 09:18:49 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.12096.1722874728716549717 for ; Mon, 05 Aug 2024 09:18:48 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id 0FD2420B7165; Mon, 5 Aug 2024 09:18:48 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0FD2420B7165 Message-ID: <848549c2-2ef4-4692-bf90-bbca25c3ffba@linux.microsoft.com> Date: Mon, 5 Aug 2024 09:18:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg To: devel@edk2.groups.io, ardb@kernel.org Cc: Leif Lindholm , Sami Mujawar , Michael Kinney , Liming Gao , Zhiguang Liu References: From: "Oliver Smith-Denny" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 05 Aug 2024 09:18:48 -0700 Resent-From: osde@linux.microsoft.com Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wTe0teSVMdCjArn5PfRPWaabx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=yNoqBR2G; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) On 8/2/2024 1:46 AM, Ard Biesheuvel wrote: > On Fri, 2 Aug 2024 at 00:39, Oliver Smith-Denny > wrote: >> >> CompilerIntrinsicsLib and ArmSoftFloatLib add ARM/AARCH64 compiler >> intrinsics and floating point functions required by OpenSSL, >> respectively. CompilerIntrinsicsLib is used almost in every DSC that >> builds ARM/AARCH64 and ArmSoftFloatLib is used by every DSC that builds >> logic from OpenSSL. >=20 > What's even worse: OpenSSL doesn't really use floating point at all - > the only reason we need this is because there is some global double_t > somewhere that records entropy or somesuch, but IIRC that code is not > actually used. >=20 > So perhaps we could add a hack in OpensslLib to work around this in > one way or another for ARM only, and get rid of SoftFloatLib > altogether. I took a quick look at this. Unfortunately, I don't think this is trivial. There are some uses of doubles within OpenSSL and it doesn't look like we can just not build part of it, because the first error I hit is that crypto/params.c uses fp operations: https://github.com/openssl/openssl/blob/de90e54bbe82e5be4fb9608b6f5c308bb83= 7d355/crypto/params.c#L762 and this provides a lot of definitions for other OpenSSL code. A quick search turns up a number of other instances, so for now I will go with moving the submodule, unless you want to take a look at OpenSSL. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120237): https://edk2.groups.io/g/devel/message/120237 Mute This Topic: https://groups.io/mt/107675828/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-