From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Gua Guo <gua.guo@intel.com>, Guo Dong <guo.dong@intel.com>,
James Lu <james.lu@intel.com>,
Sean Rhodes <sean@starlabs.systems>
Subject: Re: [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl
Date: Wed, 06 Mar 2024 13:10:08 -0800 [thread overview]
Message-ID: <848724e8-d5b7-4ffc-f2b3-054d3f79c0e3@redhat.com> (raw)
In-Reply-To: <20240305113843.68812-11-lersek@redhat.com>
Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 12:38, Laszlo Ersek wrote:
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -t GCC5
>
> python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -f \
> -t GCC5
>
> build -a X64 -b DEBUG -p UefiPayloadPkg/UefiPayloadPkg.dsc -t GCC5 \
> -D BUILD_ARCH=X64
>
> Cc: Gua Guo <gua.guo@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: James Lu <james.lu@intel.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ----------
> 4 files changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
> index 01fb3aceb3e4..b87a0989eee3 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
> +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = FitUniversalPayloadEntry
> FILE_GUID = CED5A8A9-B6EA-4D5A-8689-577EE88566CF
> MODULE_TYPE = SEC
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
> index e2af8a4b7c1b..a3ff4b86eaf6 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
> @@ -9,7 +9,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = PayloadEntry
> FILE_GUID = 2119BBD7-9432-4f47-B5E2-5C4EA31B6BDC
> MODULE_TYPE = SEC
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> index 5112cdc1e5df..a62da5c7059d 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = UniversalPayloadEntry
> FILE_GUID = D4F0F269-1209-4A66-8039-C4D5A700EA4E
> MODULE_TYPE = SEC
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
> index ad8a9fd22b66..80ccc5072c55 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
> @@ -51,16 +51,6 @@
> #define E820_PMEM 7
> #define E820_UNDEFINED 8
>
> -/**
> - Auto-generated function that calls the library constructors for all of the module's
> - dependent libraries.
> -**/
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> /**
> Add a new HOB to the HOB List.
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116458): https://edk2.groups.io/g/devel/message/116458
Mute This Topic: https://groups.io/mt/104742531/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-06 21:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
2024-03-06 21:08 ` Laszlo Ersek
2024-03-06 22:22 ` Michael D Kinney
2024-03-06 21:17 ` Rebecca Cran
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix " Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up " Laszlo Ersek
2024-03-05 14:06 ` Sunil V L
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC " Laszlo Ersek
2024-03-05 13:02 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: " Laszlo Ersek
2024-03-05 13:01 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 07/10] EmulatorPkg: " Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-06 22:36 ` Michael D Kinney
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: " Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-07 9:09 ` Zeng, Star
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek [this message]
2024-03-05 12:26 ` [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Yao, Jiewen
2024-03-07 8:24 ` Gerd Hoffmann
2024-03-08 9:13 ` Laszlo Ersek
2024-03-08 9:34 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=848724e8-d5b7-4ffc-f2b3-054d3f79c0e3@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox