From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 50B1674003A for ; Wed, 6 Mar 2024 21:10:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ji0a9LDiAL+UTLGWe+u8pl7Zvpbh66CcI6wKOxiTHCk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709759409; v=1; b=h712e1aH1luc8INKfHTk0+hIxr0K/cH+1N6CHkGzbPECg1zcBK7OScR4rqHO2KjjUZM0UPO/ RpRHWBOipMkskBV2k/cZzaD/T6VyDX1CLrknu3dPTl9t0UPG7ua+WvMJseF1OfSBOGLjRi+S3kD B6yGknr3HlO0t8qiOluaodj/svL6xr1ZkVzsESaTTaQme7q2FKOdFSLafRpnYnq316rJaL4D62j cCnX8GEG/HMaoPPV77foMAzz0AAf5JSE+vQXmdlUw8mXQof/ZHTz6ZVS52Cd51/1NqfDcJgI9MJ IhzVonddLipWlreyPidZYeJ73xB65ipZ46FFQ4Upt8FdA== X-Received: by 127.0.0.2 with SMTP id tbAeYY7687511xDcBoduP2So; Wed, 06 Mar 2024 13:10:09 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.7284.1709759408354783059 for ; Wed, 06 Mar 2024 13:10:08 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-SvCsD7D3MOS3RAkFPqVh2w-1; Wed, 06 Mar 2024 16:10:03 -0500 X-MC-Unique: SvCsD7D3MOS3RAkFPqVh2w-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6F3E800267; Wed, 6 Mar 2024 21:10:02 +0000 (UTC) X-Received: from [10.39.192.14] (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0D06200AE7F; Wed, 6 Mar 2024 21:10:01 +0000 (UTC) Message-ID: <848724e8-d5b7-4ffc-f2b3-054d3f79c0e3@redhat.com> Date: Wed, 06 Mar 2024 13:10:08 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Gua Guo , Guo Dong , James Lu , Sean Rhodes Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20240305113843.68812-1-lersek@redhat.com> <20240305113843.68812-11-lersek@redhat.com> In-Reply-To: <20240305113843.68812-11-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jzuyjwLiP9wZIN8Ez7FLFm4lx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=h712e1aH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Can I please get a quick R-b for this patch -- it's urgent because of . Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). >=20 > Build-tested with: >=20 > python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -t GCC5 >=20 > python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -f \ > -t GCC5 >=20 > build -a X64 -b DEBUG -p UefiPayloadPkg/UefiPayloadPkg.dsc -t GCC5 \ > -D BUILD_ARCH=3DX64 >=20 > Cc: Gua Guo > Cc: Guo Dong > Cc: James Lu > Cc: Sean Rhodes > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 > Signed-off-by: Laszlo Ersek > --- > UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +- > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +- > UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +- > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ------= ---- > 4 files changed, 3 insertions(+), 13 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf= b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf > index 01fb3aceb3e4..b87a0989eee3 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf > +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf > @@ -8,7 +8,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D FitUniversalPayloadEntry > FILE_GUID =3D CED5A8A9-B6EA-4D5A-8689-577EE88566C= F > MODULE_TYPE =3D SEC > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf b/UefiP= ayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > index e2af8a4b7c1b..a3ff4b86eaf6 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > @@ -9,7 +9,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D PayloadEntry > FILE_GUID =3D 2119BBD7-9432-4f47-B5E2-5C4EA31B6BD= C > MODULE_TYPE =3D SEC > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf b/= UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf > index 5112cdc1e5df..a62da5c7059d 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf > +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf > @@ -8,7 +8,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D UniversalPayloadEntry > FILE_GUID =3D D4F0F269-1209-4A66-8039-C4D5A700EA4= E > MODULE_TYPE =3D SEC > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h b/UefiPay= loadPkg/UefiPayloadEntry/UefiPayloadEntry.h > index ad8a9fd22b66..80ccc5072c55 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h > @@ -51,16 +51,6 @@ > #define E820_PMEM 7 > #define E820_UNDEFINED 8 > =20 > -/** > - Auto-generated function that calls the library constructors for all of= the module's > - dependent libraries. > -**/ > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - VOID > - ); > - > /** > Add a new HOB to the HOB List. > =20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116458): https://edk2.groups.io/g/devel/message/116458 Mute This Topic: https://groups.io/mt/104742531/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-